Added bug 18970 for the test each new issue id - approach.



Van: Marcel de Rooy
Verzonden: vrijdag 21 juli 2017 07:58
Aan: koha-devel@lists.koha-community.org
Onderwerp: Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost
 

Not sure if 18966 is the way to go, "halting the system" until we fixed the autoincrement.

The solution of merging the tables, as David refers to, is the ideal one, but it seems too big to implement right now, as we need to fix stable branches right now.
The renumbering fix depended on locking. The locks were removed quickly, but did we search further on that road? Why wouldn't it be possible to lock a table somehow?
If we completely revert the renumbering fix, I think we should test at each insert if the new issue id is greater than the max in old_issues. If not, fix it in that process. This would prevent new clashes. And when we move to old_issues, take some temporary data loss for granted (if the id's clash, choose for the newest one or the one with a fine or so).

Marcel

Van: koha-devel-bounces@lists.koha-community.org <koha-devel-bounces@lists.koha-community.org> namens David Cook <dcook@prosentient.com.au>
Verzonden: vrijdag 21 juli 2017 05:57
Aan: 'Jonathan Druart'; koha-devel@lists.koha-community.org
Onderwerp: Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost
 

Jonathan, have you thought anymore about merging the deleted* tables back in with the active tables? This would have the benefit of fixing problems with things like “Checkout history” where issues containing deleted borrowers or deleted items have these details nullified and thus disappear from the system.

 

I suppose we’d have to make sure the deleted flag is indexed, and it would mean changing many SQL reports not to include deleted records… so that might be easier said than done.

 

Alternatively, maybe we need more robust logical (ie code) ways of managing the relationships between active and inactive (ie deleted) data? I mean… what’s the point of keeping a history of data if we can’t use it?

 

David Cook

Systems Librarian

Prosentient Systems

72/330 Wattle St

Ultimo, NSW 2007

Australia

 

Office: 02 9212 0899

Direct: 02 8005 0595

 

From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Jonathan Druart
Sent: Friday, 21 July 2017 3:23 AM
To: koha-devel@lists.koha-community.org
Subject: Re: [Koha-devel] AUTO_INCREMENT fix - prevent data lost

 

And see bug 18966 for a third (last!?) round. I tried to resume in the description of the bug what has been done and what I propose to move forward.
BE INVOLVED!

 

On Wed, 12 Jul 2017 at 15:11 Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:

It sounds like I should add it somewhere more visible, but do not find where, any ideas?

See also bug 18931 where I would like to add a warning on the about page if data are corrupted.

Please review quickly, that way we can share the tips on the general mailing list.

Cheers,

Jonathan