flaw in C4/Biblio.pm when controlnumber not set
Hi, I was playing around with strange records (one with no setting for control number) and managed to tickle this-- 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1266) sub GetMarcControlnumber { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1267) my ( $record, $marcflavour ) = @_; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1268) my $controlnumber = ""; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1269) # Control number or Record identifier are the same field in MARC21 and UNIMARC 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1270) # Keep $marcflavour for possible later use 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1271) if ($marcflavour eq "MARC21" || $marcflavour eq "UNIMARC") { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1272) $controlnumber = $record->field('001')->data(); 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1273) } 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1274) } which causes-- Can't call method "data" on an undefined value at /home/reedpetone/koha/dev/koha/C4/Biblio.pm line 1272. when I do this-- http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=2 ------- Since it's a small and recent item, advice on IRC was to just send this to the list. -reed
Hi Reed, I am sorry my patch caused this problem. I have worked on the problem and sent a follow-up patch: http://lists.koha-community.org/pipermail/koha-patches/2010-November/013113.... Hope that fixes the problem. Katrin -----Ursprüngliche Nachricht----- Von: koha-devel-bounces@lists.koha-community.org im Auftrag von Reed Wade Gesendet: So 28.11.2010 01:53 An: Koha Devel Betreff: [Koha-devel] flaw in C4/Biblio.pm when controlnumber not set Hi, I was playing around with strange records (one with no setting for control number) and managed to tickle this-- 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1266) sub GetMarcControlnumber { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1267) my ( $record, $marcflavour ) = @_; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1268) my $controlnumber = ""; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1269) # Control number or Record identifier are the same field in MARC21 and UNIMARC 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1270) # Keep $marcflavour for possible later use 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1271) if ($marcflavour eq "MARC21" || $marcflavour eq "UNIMARC") { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1272) $controlnumber = $record->field('001')->data(); 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1273) } 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1274) } which causes-- Can't call method "data" on an undefined value at /home/reedpetone/koha/dev/koha/C4/Biblio.pm line 1272. when I do this-- http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=2 ------- Since it's a small and recent item, advice on IRC was to just send this to the list. -reed _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
works for me ta, -reed On Mon, Nov 29, 2010 at 1:45 AM, Fischer, Katrin <Katrin.Fischer@bsz-bw.de> wrote:
Hi Reed,
I am sorry my patch caused this problem. I have worked on the problem and sent a follow-up patch:
http://lists.koha-community.org/pipermail/koha-patches/2010-November/013113....
Hope that fixes the problem.
Katrin
-----Ursprüngliche Nachricht----- Von: koha-devel-bounces@lists.koha-community.org im Auftrag von Reed Wade Gesendet: So 28.11.2010 01:53 An: Koha Devel Betreff: [Koha-devel] flaw in C4/Biblio.pm when controlnumber not set
Hi,
I was playing around with strange records (one with no setting for control number) and managed to tickle this--
703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1266) sub GetMarcControlnumber { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1267) my ( $record, $marcflavour ) = @_; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1268) my $controlnumber = ""; 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1269) # Control number or Record identifier are the same field in MARC21 and UNIMARC 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1270) # Keep $marcflavour for possible later use 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1271) if ($marcflavour eq "MARC21" || $marcflavour eq "UNIMARC") { 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1272) $controlnumber = $record->field('001')->data(); 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1273) } 703156da (Katrin Fischer 2010-11-24 11:35:43 -0500 1274) }
which causes--
Can't call method "data" on an undefined value at /home/reedpetone/koha/dev/koha/C4/Biblio.pm line 1272.
when I do this--
http://koha/cgi-bin/koha/opac-detail.pl?biblionumber=2
-------
Since it's a small and recent item, advice on IRC was to just send this to the list.
-reed _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (2)
-
Fischer, Katrin -
Reed Wade