Hi, While working on bug 11310 to sync up bootstrap/en/xslt with prog/en/xslt, it occurred to me that at present there's no reason why the OPAC XSLT couldn't be shared by all themes. In particular, CCSR falls back to prog's XSLT, and to date there has been no sign of a need for XSLT specific to the Bootstrap theme. Consequently, I propose to move koha-tmpl/opac-tmpl/prog/en/xslt to (say) koha-tmpl/opac-tmpl/xslt/en, with appropriate adjustments to the translation scripts so that koha-tmpl/opac-tmpl/xslt/fr-FR, etc., can be generated. I would appreciate feedback on the proposal -- in particular, I'd like to know if anybody knows of a concrete reason for needing theme-specific results and details stylesheets. [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
+ 1 One less thing to check for in QA :) Katrin -----Ursprüngliche Nachricht----- Von: koha-devel-bounces@lists.koha-community.org im Auftrag von Galen Charlton Gesendet: Mo 06.01.2014 18:13 An: koha-devel@lists.koha-community.org Betreff: [Koha-devel] RFC: make OPAC XSLT be shared by all themes Hi, While working on bug 11310 to sync up bootstrap/en/xslt with prog/en/xslt, it occurred to me that at present there's no reason why the OPAC XSLT couldn't be shared by all themes. In particular, CCSR falls back to prog's XSLT, and to date there has been no sign of a need for XSLT specific to the Bootstrap theme. Consequently, I propose to move koha-tmpl/opac-tmpl/prog/en/xslt to (say) koha-tmpl/opac-tmpl/xslt/en, with appropriate adjustments to the translation scripts so that koha-tmpl/opac-tmpl/xslt/fr-FR, etc., can be generated. I would appreciate feedback on the proposal -- in particular, I'd like to know if anybody knows of a concrete reason for needing theme-specific results and details stylesheets. [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
+1 On Mon, Jan 6, 2014 at 2:16 PM, Fischer, Katrin <Katrin.Fischer@bsz-bw.de>wrote:
+ 1
One less thing to check for in QA :)
Katrin
-----Ursprüngliche Nachricht----- Von: koha-devel-bounces@lists.koha-community.org im Auftrag von Galen Charlton Gesendet: Mo 06.01.2014 18:13 An: koha-devel@lists.koha-community.org Betreff: [Koha-devel] RFC: make OPAC XSLT be shared by all themes
Hi,
While working on bug 11310 to sync up bootstrap/en/xslt with prog/en/xslt, it occurred to me that at present there's no reason why the OPAC XSLT couldn't be shared by all themes. In particular, CCSR falls back to prog's XSLT, and to date there has been no sign of a need for XSLT specific to the Bootstrap theme.
Consequently, I propose to move koha-tmpl/opac-tmpl/prog/en/xslt to (say) koha-tmpl/opac-tmpl/xslt/en, with appropriate adjustments to the translation scripts so that koha-tmpl/opac-tmpl/xslt/fr-FR, etc., can be generated.
I would appreciate feedback on the proposal -- in particular, I'd like to know if anybody knows of a concrete reason for needing theme-specific results and details stylesheets.
[1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 4333190 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F
I'm no developer, so my comment may be way off track but wouldn't it be a move to make koha less flexible? In general it would be better for themes to be as diverse as possible. Could the same results be accomplished by eliminating the duplicate files by linking them with the default theme's ones? If then one needs the added functionality, the link could be removed and a diverse, discrete file could be created in its (appropriate) place. So, everyone would be happy. Or have I got it wrong? Kind regards, Manos PETRIDIS Από το iPhone μου 6 Ιαν 2014, 7:13 μ.μ., ο/η Galen Charlton <gmc@esilibrary.com> έγραψε:
Hi,
While working on bug 11310 to sync up bootstrap/en/xslt with prog/en/xslt, it occurred to me that at present there's no reason why the OPAC XSLT couldn't be shared by all themes. In particular, CCSR falls back to prog's XSLT, and to date there has been no sign of a need for XSLT specific to the Bootstrap theme.
Consequently, I propose to move koha-tmpl/opac-tmpl/prog/en/xslt to (say) koha-tmpl/opac-tmpl/xslt/en, with appropriate adjustments to the translation scripts so that koha-tmpl/opac-tmpl/xslt/fr-FR, etc., can be generated.
I would appreciate feedback on the proposal -- in particular, I'd like to know if anybody knows of a concrete reason for needing theme-specific results and details stylesheets.
[1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (5)
-
Fischer, Katrin -
Galen Charlton -
Magnus Enger -
Manos PETRIDIS -
Tomas Cohen Arazi