Deletion of changelanguage.pl and opac-changelanguage.pl
Working on Bug 9735 [1] I ended up writing C4::Templates::getlanguagecookie and hooking C4::Auth::get_template_and_user in a way that the language can be changed using URL parameters, and the corresponding is properly set. Using this new code, the language selection could be simplified by using JavaScript + document.location to generate the links to languages. What do u think? Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735
Using this new code, the language selection could be simplified by using JavaScript + document.location to generate the links to languages.
OPAC functionality must not depend on JavaScript. There needs to be a way for it to work without it. -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
On Mar 4, 2013 3:33 AM, "Owen Leonard" <oleonard@myacpl.org> wrote:
Using this new code, the language selection could be simplified by using JavaScript + document.location to generate the links to languages.
OPAC functionality must not depend on JavaScript. There needs to be a way for it to work without it.
Yep, I like the rest, but Owen is right we can not make changing the language dependent on javascript. Chris
-- Owen
-- Web Developer Athens County Public Libraries http://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
I agree, I'll think of a non-js way. Thanks To+ On Sun, Mar 3, 2013 at 11:33 AM, Owen Leonard <oleonard@myacpl.org> wrote:
Using this new code, the language selection could be simplified by using JavaScript + document.location to generate the links to languages.
OPAC functionality must not depend on JavaScript. There needs to be a way for it to work without it.
-- Owen
-- Web Developer Athens County Public Libraries http://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (3)
-
Chris Cormack -
Owen Leonard -
Tomas Cohen Arazi