Hi, HTML::Template has invalid tags from a html point of view : <TMPL_VAR xx> is not closed, and <TMPL_ELSE> neither. But... there is another method to write template : use <!-- TMPL_VAR xx> instead of <TMPL_VAR xx>. with this method, HTML::TreeBuilder create better the string list. So i've written a little script that changed ALL <TMPL > to <!-- TMPL > in both OPAC and INTRANET. I've commited them. So, update your CVS copies, and for future templates, use <!-- TMPL > form and NOT <TMPL > one. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
On 2003-12-09 10:39:08 +0000 paul POULAIN <paul.poulain@free.fr> wrote:
HTML::Template has invalid tags from a html point of view : <TMPL_VAR xx> is not closed, and <TMPL_ELSE> neither.
Actually, they're valid HTML, yet not valid xhtml. I don't like using comments either <!-- TMPL_VAR xx -->, as some tools strip them. Can we request that it uses processing instructions instead? Tags would look like <?tmpl VAR xx ?> -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
MJ Ray a écrit :
On 2003-12-09 10:39:08 +0000 paul POULAIN <paul.poulain@free.fr> wrote:
HTML::Template has invalid tags from a html point of view : <TMPL_VAR xx> is not closed, and <TMPL_ELSE> neither.
Actually, they're valid HTML, yet not valid xhtml. I don't like using comments either <!-- TMPL_VAR xx -->, as some tools strip them. Can we request that it uses processing instructions instead? Tags would look like <?tmpl VAR xx ?>
No, because HTML::Template doesn't support this. I've asked H::T mailing list to accept <TMPL_ELSE /> and <TMPL_VAR name="x"/> syntax, but they said : * with <!-- you can do what you want * H::T releases are very rare, so... -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
On 2003-12-09 11:41:15 +0000 paul POULAIN <paul.poulain@free.fr> wrote:
No, because HTML::Template doesn't support this.
That is why I suggested we ask for it.
I've asked H::T mailing list to accept <TMPL_ELSE /> and <TMPL_VAR name="x"/> syntax, but they said : * with <!-- you can do what you want
That seems broken. Obvious debug comments like <!-- TMPL_IF block starts here --> in the template will be forbidden, I think. PHP correctly uses <?php code goes here; ?> and H:T probably should do similar.
* H::T releases are very rare, so...
If it has an upgrade, surely they won't refuse a release? Is it just that they are unwilling to make changes? If so, a patch shouldn't be too hard. -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
participants (2)
-
MJ Ray -
paul POULAIN