Re: [Koha-devel] Pending PDF::Reuse Release And Koha
That's great! Thanks Mark. Kind Regards, Chris On Wed, Dec 3, 2014 at 5:41 PM, Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings,
With Robin’s DEB, I’ve successfully done steps 1 through 5.
GPML, Mark Tompsett
*From:* Chris Nighswonger <cnighswonger@foundations.edu> *Sent:* Wednesday, December 03, 2014 12:53 PM *To:* koha-devel@lists.koha-community.org *Subject:* [Koha-devel] Pending PDF::Reuse Release And Koha
I have rolled a pending PDF::Reuse release which incorporates several methods which I wrote to accommodate the label and patroncard tools in Koha back in 2009. I had hoped these would be included in PDF::Reuse before now; however, they were not. The module appears to have been abandoned by the original author, and I was able to be listed as a co-maintainer.
I have tested these changes on Koha's current head, and they appear to work fine. This is an official call for testing these changes prior to my releasing the new version of PDF::Reuse.
Since these changes directly affect Koha, they have the potential to affect current and future stable installs. Below is a link to a dev release of PDF::Reuse which contains the proposed changes. Attached is a patch formatted against the head current at the time of this email. Please do the following:
1. Upgrade PDF::Reuse to 0.35_01. 2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for the end user. 3. Verify the functionality of the related tools. 4. Apply the attached patch. 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. 7. Reply to the list with any issue which arise.
After we're happy with the changes, I will submit the attached patch to Koha via normal channels for QA, etc.
This conversation will serve as QA for the proposed PDF::Reuse release. There are many things which could be different about the code in PDF::Reuse. This release is not the time to deal with these, so please keep it to show-stopping problems. There will be plenty of time to "fix" other things later. (That said, feel free to send along any thoughts directly to me.)
Kind Regards, Chris
http://backpan.perl.org/authors/id/C/CN/CNIGHS/PDF-Reuse-0.35_01.tar.gz
------------------------------ _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for
Hi to all, only to check the situation: --- install http://www.kallisti.net.nz/~robin/libpdf-reuse-perl_0.36-01-1_all.deb --- do Chris checks 2 to 3: the end user.
3. Verify the functionality of the related tools. -- install Chris patch -- do Chris checks 5 to 7 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. 7. Reply to the list with any issue which arise.
Is it correct ? Bye Zeno Tajoli -- Dr. Zeno Tajoli Soluzioni per la Ricerca Istituzionale - Automazione Biblioteche z.tajoli@cineca.it fax +39 02 2135520 CINECA - Sede operativa di Segrate
2. Run Koha's non-DB dependent test suite. You should notice some non-fatal warnings about the redefinition of one or two subs in PDF::Reuse. This should not affect the functionality of the tools for
Greetings, That is my understanding. If you get around to flushing out how you tested step 6, I would be interested. :) GPML, Mark Tompsett -----Original Message----- From: Zeno Tajoli Sent: Wednesday, December 03, 2014 10:53 PM To: Chris Nighswonger ; koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Pending PDF::Reuse Release And Koha Hi to all, only to check the situation: --- install http://www.kallisti.net.nz/~robin/libpdf-reuse-perl_0.36-01-1_all.deb --- do Chris checks 2 to 3: the end user.
3. Verify the functionality of the related tools. -- install Chris patch -- do Chris checks 5 to 7 5. Re-run Koha's non-DB dependent test suite. You should note no warnings related to PDF::Reuse. 6. Re-verify the functionality of the related tools. 7. Reply to the list with any issue which arise.
Is it correct ? Bye Zeno Tajoli -- Dr. Zeno Tajoli Soluzioni per la Ricerca Istituzionale - Automazione Biblioteche z.tajoli@cineca.it fax +39 02 2135520 CINECA - Sede operativa di Segrate _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
On Wed, Dec 3, 2014 at 10:57 PM, Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings,
That is my understanding.
If you get around to flushing out how you tested step 6, I would be interested. :)
Basically re-do step 3 to ensure the tools still work as expected after installing the patch on Koha. Kind Regards, Chris
Greetings, I wrote:
If you get around to flushing out how you tested step 6, I would be interested. :)
Chris N. wrote:
Basically re-do step 3 to ensure the tools still work as expected after installing the patch on Koha.
... And step 3. ;) GPML, Mark Tompsett
I've set up a repo on github: https://github.com/cnighswonger/PDF-Reuse On Wed, Dec 3, 2014 at 11:03 PM, Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings, I wrote:
If you get around to flushing out how you tested step 6, I would be interested. :)
Chris N. wrote:
Basically re-do step 3 to ensure the tools still work as expected after installing the patch on Koha.
... And step 3. ;)
GPML, Mark Tompsett
I've pushed an new dev version of PDF::Reuse up which just adds missing license info to the meta file. If nothing crops up by Wednesday afternoon, I will roll up PDF::Reuse 0.36 and upload it to CPAN. I have opened Koha bug 13407 [1] for this issue. Any Koha installs done before the Koha patch is pushed should not be adversely affected as far as I can tell. Robin, if you have time to roll a deb package for 0.35_04 I'll add a link to that bug for it. It may help those who will be doing QA on the patch for Koha. Also, let me know if anything else needs to be fixed so that the new version can be sent upstream. Thanks to everyone for the help. Kind Regards, Chris [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 On Wed, Dec 3, 2014 at 11:34 PM, Christopher Nighswonger < chris.nighswonger@gmail.com> wrote:
I've set up a repo on github:
https://github.com/cnighswonger/PDF-Reuse
On Wed, Dec 3, 2014 at 11:03 PM, Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings, I wrote:
If you get around to flushing out how you tested step 6, I would be interested. :)
Chris N. wrote:
Basically re-do step 3 to ensure the tools still work as expected after installing the patch on Koha.
... And step 3. ;)
GPML, Mark Tompsett
Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Chris Nighswonger schreef op ma 08-12-2014 om 08:55 [-0500]:
Robin, if you have time to roll a deb package for 0.35_04 I'll add a link to that bug for it. It may help those who will be doing QA on the patch for Koha. Also, let me know if anything else needs to be fixed so that the new version can be sent upstream.
There are a couple of patches in the Debian package that should probably be pulled into here, if that hasn't already happened. http://anonscm.debian.org/cgit/pkg-perl/packages/libpdf-reuse-perl.git/tree/... You should add your dated copyright line to the files you've changed. Some of the files could do with their own copyright header. Otherwise I haven't noticed anything else that needs sorting. Deb file here: http://debian.koha-community.org/koha/other_files/libpdf-reuse-perl_0.35-05-... -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF
On Mon, Dec 8, 2014 at 5:47 PM, Robin Sheat <robin@catalyst.net.nz> wrote:
There are a couple of patches in the Debian package that should probably be pulled into here, if that hasn't already happened.
http://anonscm.debian.org/cgit/pkg-perl/packages/libpdf-reuse-perl.git/tree/...
Done.
You should add your dated copyright line to the files you've changed.
Done.
Some of the files could do with their own copyright header.
Done.
Otherwise I haven't noticed anything else that needs sorting.
Deb file here: http://debian.koha-community.org/koha/other_files/libpdf-reuse-perl_0.35-05-...
Thanks again, Robin!
participants (6)
-
Chris Nighswonger -
Chris Nighswonger -
Christopher Nighswonger
-
Mark Tompsett -
Robin Sheat -
Zeno Tajoli