Question (to Jared) about pushing/bugzilla
Dear 3.12 Release Manager ( ;-) ), I see that you started pushing on master. Great ! I started to check what you push to see if it must be pushed for 3.10, and find the bug 8707. I see on bugzilla that you obsoleted the patch you've pushed (so there's no patch attached). Is it a behaviour that you plan to do for each patch you push ? That's not what I did, so it's a change in the workflow that must be announced (I've nothing against it). So please, confirm ;-) -- Paul POULAIN - BibLibre http://www.biblibre.com Free & Open Source Softwares for libraries Koha, Drupal, Piwik, Jasper
Op 02-11-12 08:25, Paul Poulain schreef:
I see on bugzilla that you obsoleted the patch you've pushed (so there's no patch attached). Is it a behaviour that you plan to do for each patch you push ?
Hmm, it would have the problem that it would make it harder for others to pick patches off of bz. Robin.
Paul, I started to check what you push to see if it must be pushed for 3.10,
and find the bug 8707. I see on bugzilla that you obsoleted the patch you've pushed (so there's no patch attached). Is it a behaviour that you plan to do for each patch you push ?
I will need to do that for bugfixes until 3.10, otherwise there is a risk of 3.10 and 3.12 diverging if you pull a patch off of bugzilla that I did not. Any time you see a patch on Bugzilla on a bug you're cherry-picking, it means we need to confer about that patch. I will obsolete 3.12-only patches only on revolving bugs, that need to be reset to ASSIGNED after they've been pushed, but other than that I see no need to obsolete 3.12-only bugs. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
Le 01/11/2012 21:15, Jared Camins-Esakov a écrit :
Paul,
I started to check what you push to see if it must be pushed for 3.10, and find the bug 8707. I see on bugzilla that you obsoleted the patch you've pushed. I will need to do that for bugfixes until 3.10, otherwise there is a risk of 3.10 and 3.12 diverging if you pull a patch off of bugzilla that I did not. If that's the only reason, then it's not needed: I do a merge from git. Sometimes a cherry-pick (if you're applied the patch to master only), but not a git bz. So, unless I'm missing something, that's not needed.
RMaint : Also note that I don't change the status of the bug when I push it to 3.10, I just add a comment "patch pushed to 3.10"
Any time you see a patch on Bugzilla on a bug you're cherry-picking, it means we need to confer about that patch. I will obsolete 3.12-only patches only on revolving bugs, that need to be reset to ASSIGNED after they've been pushed, but other than that I see no need to obsolete 3.12-only bugs.
-- Paul POULAIN - Associé-gérant Tel : (33) 4 91 81 35 08 http://www.biblibre.com Logiciels Libres pour les bibliothèques et les centres de documentation
Paul,
I will need to do that for bugfixes until 3.10, otherwise there is a
risk of 3.10 and 3.12 diverging if you pull a patch off of bugzilla that I did not. If that's the only reason, then it's not needed: I do a merge from git. Sometimes a cherry-pick (if you're applied the patch to master only), but not a git bz. So, unless I'm missing something, that's not needed.
Okay. In that case I will not bother. Except, of course, for bugs that will be getting additional patches. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
participants (3)
-
Jared Camins-Esakov -
Paul Poulain -
Robin Sheat