Add rule for experimental features in coding guidelines
Hi all: I just noticed that we don't actually have a rule against using experimental features (e.g. smartmatch ~~, given/when) in the coding guidelines. We impose this rule during the testing/QA process, but it's not actually documented. What do we need to do to add a rule? Bring this up at a meeting? http://wiki.koha-community.org/wiki/Coding_Guidelines David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007
I agree. I think it should be added to the agenda for the next developers meeting so it can be put to a vote! Kyle http://www.kylehall.info ByWater Solutions ( http://bywatersolutions.com ) Meadville Public Library ( http://www.meadvillelibrary.org ) Crawford County Federated Library System ( http://www.ccfls.org ) Mill Run Technology Solutions ( http://millruntech.com ) On Mon, Sep 28, 2015 at 10:26 PM, David Cook <dcook@prosentient.com.au> wrote:
Hi all:
I just noticed that we don’t actually have a rule against using experimental features (e.g. smartmatch ~~, given/when) in the coding guidelines. We impose this rule during the testing/QA process, but it’s not actually documented.
What do we need to do to add a rule? Bring this up at a meeting?
http://wiki.koha-community.org/wiki/Coding_Guidelines
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St, Ultimo, NSW 2007
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Maybe it would be better to just specify that the code has to pass the koha-qa script. The experimental warnings is raised by perl -w and caught by this script. 2015-09-29 3:26 GMT+01:00 David Cook <dcook@prosentient.com.au>:
Hi all:
I just noticed that we don’t actually have a rule against using experimental features (e.g. smartmatch ~~, given/when) in the coding guidelines. We impose this rule during the testing/QA process, but it’s not actually documented.
What do we need to do to add a rule? Bring this up at a meeting?
http://wiki.koha-community.org/wiki/Coding_Guidelines
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St, Ultimo, NSW 2007
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
I'm perfectly happy with that : ) David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007
-----Original Message----- From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel- bounces@lists.koha-community.org] On Behalf Of Jonathan Druart Sent: Wednesday, 30 September 2015 6:38 PM To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Add rule for experimental features in coding guidelines
Maybe it would be better to just specify that the code has to pass the koha- qa script. The experimental warnings is raised by perl -w and caught by this script.
2015-09-29 3:26 GMT+01:00 David Cook <dcook@prosentient.com.au>:
Hi all:
I just noticed that we don’t actually have a rule against using experimental features (e.g. smartmatch ~~, given/when) in the coding guidelines. We impose this rule during the testing/QA process, but it’s not actually documented.
What do we need to do to add a rule? Bring this up at a meeting?
http://wiki.koha-community.org/wiki/Coding_Guidelines
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St, Ultimo, NSW 2007
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha- community.org/ bugs : http://bugs.koha-community.org/
participants (3)
-
David Cook -
Jonathan Druart -
Kyle Hall