Staff/OPAC ISBD views and subfield visibility
Dear Developers, If you: 1) edit the ISBD and OPACISBD system preferences so that they contain the following code: #453| - translated as: |<a href="/cgi-bin/koha/catalogue/ detail.pl?biblionumber={4530}">{453t}</a> {(453d)}| #454| - translation of: |<a href="/cgi-bin/koha/catalogue/ detail.pl?biblionumber={4540}">{454t}</a> {(454d)}| 2) set the visibility of (UNIMARC) fields 453$0 and 454$0 to 'hidden' in the OPAC ...then the generated links will work fine in the Staff client but will be broken in the OPAC (i.e. the URL will not include the biblionumber contained in subfield 0 of fields 453/454). I've tracked this down to ISBDdetail.pl and opac-ISBDdetail.pl calling the GetISBDView subroutine, which (for some reason) excludes subfields that are hidden in the OPAC: https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776 https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815 What is the reasoning behind this? In other words, why is _OPAC_ subfield visibility taken into account when displaying the OPAC ISBD view (whereas visibility in Staff is not considered)? If anything, it is more likely to have subfield 0 hidden in OPAC, while visible in Staff, so one would expect the opposite logic. Thanks in advance for your time. Kind regards, Andreas Roussos
Hi Andreas, I might be misunderstanding your question, but the OPAC visibility setting should take effect on all pages and views in the OPAC now. It didn't use to, which was considered a long standing bug and finally fixed. Now it's possible to hide fields from OPAC that can still appear in staff in a reliable way. The preconfigured visibility settings in the frameworks might not always be ideal - if that's what you mean, we could work on improving them. Hope that helps, Katrin On 07.06.2018 09:21, Andreas Roussos wrote:
Dear Developers,
If you:
1) edit the ISBD and OPACISBD system preferences so that they contain the following code:
#453| - translated as: |<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber={4530} <http://detail.pl?biblionumber=%7B4530%7D>">{453t}</a> {(453d)}| #454| - translation of: |<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber={4540} <http://detail.pl?biblionumber=%7B4540%7D>">{454t}</a> {(454d)}|
2) set the visibility of (UNIMARC) fields 453$0 and 454$0 to 'hidden' in the OPAC
...then the generated links will work fine in the Staff client but will be broken in the OPAC (i.e. the URL will not include the biblionumber contained in subfield 0 of fields 453/454).
I've tracked this down to ISBDdetail.pl and opac-ISBDdetail.pl calling the GetISBDView subroutine, which (for some reason) excludes subfields that are hidden in the OPAC:
https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776 https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815
What is the reasoning behind this? In other words, why is _OPAC_ subfield visibility taken into account when displaying the OPAC ISBD view (whereas visibility in Staff is not considered)?
If anything, it is more likely to have subfield 0 hidden in OPAC, while visible in Staff, so one would expect the opposite logic.
Thanks in advance for your time.
Kind regards, Andreas Roussos
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi Katrin, Thank you for your reply. The issue we are facing is this: unless a subfield (e.g. UNIMARC 453$0, Bibliographic Record Identifier) is marked as visible in the OPAC, the links (URLs) using that subfield will be broken in the ISBD view. And this happens (according to the code snippets in my original message) only when GetISBDView is called with 'template' = 'opac', not 'intranet' (i.e. only in OPAC ISBD view, not in Staff ISBD view). I hope this makes more sense. Regards, Andreas On 18 June 2018 at 23:22, Katrin Fischer <katrin.fischer.83@web.de> wrote:
Hi Andreas,
I might be misunderstanding your question, but the OPAC visibility setting should take effect on all pages and views in the OPAC now. It didn't use to, which was considered a long standing bug and finally fixed. Now it's possible to hide fields from OPAC that can still appear in staff in a reliable way. The preconfigured visibility settings in the frameworks might not always be ideal - if that's what you mean, we could work on improving them.
Hope that helps,
Katrin
On 07.06.2018 09:21, Andreas Roussos wrote:
Dear Developers,
If you:
1) edit the ISBD and OPACISBD system preferences so that they contain the following code:
#453| - translated as: |<a href="/cgi-bin/koha/catalogue/ detail.pl?biblionumber={4530} <http://detail.pl?biblionumber=%7B4530%7D>">{453t}</a> {(453d)}| #454| - translation of: |<a href="/cgi-bin/koha/catalogue/ detail.pl?biblionumber={4540} <http://detail.pl?biblionumber=%7B4540%7D>">{454t}</a> {(454d)}|
2) set the visibility of (UNIMARC) fields 453$0 and 454$0 to 'hidden' in the OPAC
...then the generated links will work fine in the Staff client but will be broken in the OPAC (i.e. the URL will not include the biblionumber contained in subfield 0 of fields 453/454).
I've tracked this down to ISBDdetail.pl and opac-ISBDdetail.pl calling the GetISBDView subroutine, which (for some reason) excludes subfields that are hidden in the OPAC:
https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776 https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815
What is the reasoning behind this? In other words, why is _OPAC_ subfield visibility taken into account when displaying the OPAC ISBD view (whereas visibility in Staff is not considered)?
If anything, it is more likely to have subfield 0 hidden in OPAC, while visible in Staff, so one would expect the opposite logic.
Thanks in advance for your time.
Kind regards, Andreas Roussos
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi Andreas, makes sense for me. Why not mark them as visible in the OPAC? Katrin On 20.06.2018 09:51, Andreas Roussos wrote:
Hi Katrin,
Thank you for your reply.
The issue we are facing is this: unless a subfield (e.g. UNIMARC 453$0, Bibliographic Record Identifier) is marked as visible in the OPAC, the links (URLs) using that subfield will be broken in the ISBD view. And this happens (according to the code snippets in my original message) only when GetISBDView is called with 'template' = 'opac', not 'intranet' (i.e. only in OPAC ISBD view, not in Staff ISBD view).
I hope this makes more sense.
Regards, Andreas
On 18 June 2018 at 23:22, Katrin Fischer <katrin.fischer.83@web.de <mailto:katrin.fischer.83@web.de>> wrote:
Hi Andreas,
I might be misunderstanding your question, but the OPAC visibility setting should take effect on all pages and views in the OPAC now. It didn't use to, which was considered a long standing bug and finally fixed. Now it's possible to hide fields from OPAC that can still appear in staff in a reliable way. The preconfigured visibility settings in the frameworks might not always be ideal - if that's what you mean, we could work on improving them.
Hope that helps,
Katrin
On 07.06.2018 09:21, Andreas Roussos wrote:
Dear Developers,
If you:
1) edit the ISBD and OPACISBD system preferences so that they contain the following code:
#453| - translated as: |<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber={4530} <http://detail.pl?biblionumber=%7B4530%7D>">{453t}</a> {(453d)}| #454| - translation of: |<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber={4540} <http://detail.pl?biblionumber=%7B4540%7D>">{454t}</a> {(454d)}|
2) set the visibility of (UNIMARC) fields 453$0 and 454$0 to 'hidden' in the OPAC
...then the generated links will work fine in the Staff client but will be broken in the OPAC (i.e. the URL will not include the biblionumber contained in subfield 0 of fields 453/454).
I've tracked this down to ISBDdetail.pl and opac-ISBDdetail.pl calling the GetISBDView subroutine, which (for some reason) excludes subfields that are hidden in the OPAC:
https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776 <https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776> https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815 <https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815>
What is the reasoning behind this? In other words, why is _OPAC_ subfield visibility taken into account when displaying the OPAC ISBD view (whereas visibility in Staff is not considered)?
If anything, it is more likely to have subfield 0 hidden in OPAC, while visible in Staff, so one would expect the opposite logic.
Thanks in advance for your time.
Kind regards, Andreas Roussos
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel <http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> website :http://www.koha-community.org/ git :http://git.koha-community.org/ bugs :http://bugs.koha-community.org/ <http://bugs.koha-community.org/>
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel <http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ <http://bugs.koha-community.org/>
Hi Katrin, As far as our library is concerned we would not want the users to see in marc view an internal numerical code, which could be puzzling and confusing, especially if they are looking at personal name entries, who are usually followed by a role code in unimarc, e.g. 070 for author. Furthermore, why is the code looking for these values "if hidden" only in the opac interface? Why is such requirement only for opac isbd – why not for intranet isbd also, if at all necessary? Sorry for insisting, but we would like to know the usefulness and reasoning behind this. Regards, Andreas On 21 June 2018 at 09:11, Katrin Fischer <katrin.fischer.83@web.de> wrote:
Hi Andreas,
makes sense for me. Why not mark them as visible in the OPAC?
Katrin
On 20.06.2018 09:51, Andreas Roussos wrote:
Hi Katrin,
Thank you for your reply.
The issue we are facing is this: unless a subfield (e.g. UNIMARC 453$0, Bibliographic Record Identifier) is marked as visible in the OPAC, the links (URLs) using that subfield will be broken in the ISBD view. And this happens (according to the code snippets in my original message) only when GetISBDView is called with 'template' = 'opac', not 'intranet' (i.e. only in OPAC ISBD view, not in Staff ISBD view).
I hope this makes more sense.
Regards, Andreas
On 18 June 2018 at 23:22, Katrin Fischer <katrin.fischer.83@web.de> wrote:
Hi Andreas,
I might be misunderstanding your question, but the OPAC visibility setting should take effect on all pages and views in the OPAC now. It didn't use to, which was considered a long standing bug and finally fixed. Now it's possible to hide fields from OPAC that can still appear in staff in a reliable way. The preconfigured visibility settings in the frameworks might not always be ideal - if that's what you mean, we could work on improving them.
Hope that helps,
Katrin
On 07.06.2018 09:21, Andreas Roussos wrote:
Dear Developers,
If you:
1) edit the ISBD and OPACISBD system preferences so that they contain the following code:
#453| - translated as: |<a href="/cgi-bin/koha/catalogue/ detail.pl?biblionumber={4530} <http://detail.pl?biblionumber=%7B4530%7D>">{453t}</a> {(453d)}| #454| - translation of: |<a href="/cgi-bin/koha/catalogue/ detail.pl?biblionumber={4540} <http://detail.pl?biblionumber=%7B4540%7D>">{454t}</a> {(454d)}|
2) set the visibility of (UNIMARC) fields 453$0 and 454$0 to 'hidden' in the OPAC
...then the generated links will work fine in the Staff client but will be broken in the OPAC (i.e. the URL will not include the biblionumber contained in subfield 0 of fields 453/454).
I've tracked this down to ISBDdetail.pl and opac-ISBDdetail.pl calling the GetISBDView subroutine, which (for some reason) excludes subfields that are hidden in the OPAC:
https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L773-L776 https://github.com/Koha-Community/Koha/blob/master/C4/Biblio.pm#L812-L815
What is the reasoning behind this? In other words, why is _OPAC_ subfield visibility taken into account when displaying the OPAC ISBD view (whereas visibility in Staff is not considered)?
If anything, it is more likely to have subfield 0 hidden in OPAC, while visible in Staff, so one would expect the opposite logic.
Thanks in advance for your time.
Kind regards, Andreas Roussos
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (3)
-
Andreas Roussos -
Katrin Fischer -
Katrin Fischer