updates to patron messaging
Hi Koha contributors - I've prepared a few patches to start reworking the patron messaging stuff that we have that's not quite working as we hoped in 3.0. The patches still have some parts that still need to be cleaned up or improved in them, and I don't expect them to be applied as is, but I want to get some feedback on the implementation. http://arwen.metavore.com/~acm/PatronMessaging/ I added a tab to the opac and to the patron management part of the staff interface. These allow users to edit preferences about how to receive the different types of messages sent to patrons. There is a new cronjob advance_notices.pl that prepares messages to be sent to patrons to let them know of items that are soon due or have just become due. I expect to eventually mimic this implementation in the overdues scripts as I outlined previously. <http://doiop.com/PatronMessaging> There is also a new cronjob, process_message_queue.pl, that is designed to actually send out messages of all kinds through SMS, email, or RSS and can be extended. I hope to be able to use this for other messaging besides just these. In order to send SMS messages, there is a new C4::SMS module that makes use of the SMS::Send module on CPAN. I'm hopeful that this will help us consolidate all of the different ways to send SMS messages. I'm hoping to get this polished up a bunch next week so that it can be applied, but I wanted to send this out today to make sure that it's not a surprise when it comes. Please let me know what suggestions or questions you have. Thanks! -Andy _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
Andrew Moore a écrit :
Hi Koha contributors -
Hi Andrew, Those patches have been approved in HEAD if I don't mind, so I try to understand how they work (& make them work for frenchies) It seems that you use both new tables (message_queue, message_transport_type, in commit d8654344fa806d4a8ce7d675ae396b4016877ec2) and old ones (letters). i've activated EnhancedMessagingPreferences syspref, get the "my messaging" in opac, but get a "mange your messaging settings" empty list in opac-messaging. 2 question : - what to do to see something ? - shouldn't the page be labelled "Manage your ..." and not "Mange your ..." ? any other functionnal feedback on how it works welcomed. (Note : It should not have been added to 3.0 imo) -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : 04 91 31 45 19 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
Hi Paul - On Mon, Jun 30, 2008 at 8:05 AM, Paul POULAIN <paul.poulain@free.fr> wrote:
Those patches have been approved in HEAD if I don't mind, so I try to understand how they work (& make them work for frenchies) It seems that you use both new tables (message_queue, message_transport_type, in commit d8654344fa806d4a8ce7d675ae396b4016877ec2) and old ones (letters).
Yes, I am re-using some of the infrastructure that we already have to manage messages (or notices or letters). I added 5 tables, though, to extend that infrastructure. I'm glad you're trying them out. I don't know much about the translation, multi-lingual stuff, or how expectations differ for library patrons in other countries, so I appreciate your help.
i've activated EnhancedMessagingPreferences syspref, get the "my messaging" in opac, but get a "mange your messaging settings" empty list in opac-messaging.
2 question : - what to do to see something ?
I suspect that adding some data to those tables may help. See the files: installer/data/mysql/en/mandatory/message_transport_types.sql installer/data/mysql/en/optional/sample_notices_message_attributes.sql installer/data/mysql/en/optional/sample_notices_message_transports.sql installer/data/mysql/en/optional/sample_notices.sql I would love some help making 'fr' versions of these files.
- shouldn't the page be labelled "Manage your ..." and not "Mange your ..." ?
Yes, that looks like a typo. I just submitted a patch. Thanks!
any other functionnal feedback on how it works welcomed.
The cronjob misc/cronjobs/advance_notices.pl prepares these messages and loads them into the message_queue table. The misc/cronjobs/process_message_queue.pl cronjob sends those messages out. These cronjobs should each be run nightly, though the process_message_queue.pl script can be run more often with no adverse effects. It's my hope that the message_queue table can be used by more features than just this one as a way to unify the messages that we send to patrons and other users. Queueing them in this way will allow us to keep track of more details of what is sent and to eventually deliver these as a RSS feed to patrons who request that. I'm hoping to see fewer direct calls to Mail::Sendmail::sendmail scattered throughout the code.
(Note : It should not have been added to 3.0 imo)
Yes, I recognize that we don't have unanimous agreement on this. I sent out several messages about my work in advance to try to build consensus, but I could probably have done better there. I would love to further develop our methods for measuring importance, urgency, and demand for these features and fixes so that we can work in concert to make a better product. Please keep me up to date on your progress for using this feature. I want to make it better with your help. Thanks! -Andy _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
"Andrew Moore" <andrew.moore@liblime.com> wrote:
On Mon, Jun 30, 2008 at 8:05 AM, Paul POULAIN <paul.poulain@free.fr> wrote:
(Note : It should not have been added to 3.0 imo)
Yes, I recognize that we don't have unanimous agreement on this. I sent out several messages about my work in advance to try to build consensus, but I could probably have done better there. I would love to further develop our methods for measuring importance, urgency, and demand for these features and fixes so that we can work in concert to make a better product.
Not unanimous is putting it mildly. Who was in favour of adding SMS to 3.0 so late during a release cycle? BibLibre and TTLLP members have been against, someone from Cilea reported it causing problems, but I've not noticed other koha group members commenting: Calyx? L2C2? Katipo? The original message stated pretty clearly that they wouldn't be applied as-is, then "essentially these same patches" were submitted and apparently applied without question. That stung. Please be clearer what is a general development and what is being suggested for application to the freezing release version. It was posted a few days after the other 3.2 RFCs and looked clearly to mix enhancements with bugfixes, so hopefully it's clear why some people would have put it in the wrong mail queue. The SMS enhancement seemed like the import-borrowers-plus enhancement http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2287 - unless there's a loud call for it to appear in 3.0.0, I don't intend to submit it yet, and that doesn't even add any new dependencies. It's simply too late. Regards, -- MJ Ray (slef) Webmaster for hire, statistician and online shop builder for a small worker cooperative http://www.ttllp.co.uk/ http://mjr.towers.org.uk/ (Notice http://mjr.towers.org.uk/email.html) tel:+44-844-4437-237 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
Hi MJ - On Tue, Jul 1, 2008 at 6:42 AM, MJ Ray <mjr@phonecoop.coop> wrote:
The original message stated pretty clearly that they wouldn't be applied as-is, then "essentially these same patches" were submitted and apparently applied without question. That stung.
I didn't get much feedback on the proposed patches, but I thought that I accounted for the suggestions that I received. I also made some more improvements that I noticed and submitted them to patches@koha.org. It turned out that they were pretty similar. Thanks, -Andy _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
participants (3)
-
Andrew Moore -
MJ Ray -
Paul POULAIN