Hi devs, I have just caught that: Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00' And there is a test I wrote for it on bug 17578 (commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove is_expired) But then we also have, in C4::Circulation::CanBookBeIssued: 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq '0000-00-00') { 753 $issuingimpossible{EXPIRED} = 1; 754 } else { With a test: is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as expired if dateexpiry is 0000-00-00' ); So, my questions, do you have a very old Koha installations to search if there is borrowers.is_expired == "0000-00-00" in it? Do you remember if it meant expired or not at some point? I am trying to adapt our code to sql strict modes, and this value is no longer valid, we will need to update existing values. Cheers, Jonathan (yes, the same code should be used)
Hm, I don't remember a special use case for 0000-00-00. My impression was that it is impossible to have a patron without a valid dateexpiry date. On 06.02.2018 17:10, Jonathan Druart wrote:
Hi devs,
I have just caught that:
Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00' And there is a test I wrote for it on bug 17578 (commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove is_expired)
But then we also have, in C4::Circulation::CanBookBeIssued: 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq '0000-00-00') { 753 $issuingimpossible{EXPIRED} = 1; 754 } else { With a test: is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as expired if dateexpiry is 0000-00-00' );
So, my questions, do you have a very old Koha installations to search if there is borrowers.is_expired == "0000-00-00" in it? Do you remember if it meant expired or not at some point?
I am trying to adapt our code to sql strict modes, and this value is no longer valid, we will need to update existing values.
Cheers, Jonathan
(yes, the same code should be used)
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
"Enrollment period" is mandatory when creating/updating a patron category, dateexpiry will be calculated when a patron is created. So, at least with new versions, this field should never be set to 0000-00-00 (at least using the interface). We will need to take a decision at some point, either update these values with 9999-12-31 or recalculate them. It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations. Cheers, Jonathan On Tue, 6 Feb 2018 at 18:37 Katrin Fischer <katrin.fischer.83@web.de> wrote:
Hm, I don't remember a special use case for 0000-00-00.
My impression was that it is impossible to have a patron without a valid dateexpiry date. On 06.02.2018 17 <06%2002%2020%2018%2017>:10, Jonathan Druart wrote:
Hi devs,
I have just caught that:
Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00' And there is a test I wrote for it on bug 17578 (commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove is_expired)
But then we also have, in C4::Circulation::CanBookBeIssued: 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq '0000-00-00') { 753 $issuingimpossible{EXPIRED} = 1; 754 } else { With a test: is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as expired if dateexpiry is 0000-00-00' );
So, my questions, do you have a very old Koha installations to search if there is borrowers.is_expired == "0000-00-00" in it? Do you remember if it meant expired or not at some point?
I am trying to adapt our code to sql strict modes, and this value is no longer valid, we will need to update existing values.
Cheers, Jonathan
(yes, the same code should be used)
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi Jonathan, We have a number of old installations. They are all running 17.05 today. I checked about eight DBs and found only one record with dateexpiry = "0000-00-00". The record was created in 2012. Bob On 14/02/18 06:06, Jonathan Druart wrote:
"Enrollment period" is mandatory when creating/updating a patron category, dateexpiry will be calculated when a patron is created. So, at least with new versions, this field should never be set to 0000-00-00 (at least using the interface). We will need to take a decision at some point, either update these values with 9999-12-31 or recalculate them.
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
Cheers, Jonathan
On Tue, 6 Feb 2018 at 18:37 Katrin Fischer <katrin.fischer.83@web.de <mailto:katrin.fischer.83@web.de>> wrote:
Hm, I don't remember a special use case for 0000-00-00.
My impression was that it is impossible to have a patron without a valid dateexpiry date.
On 06.02.2018 17 <tel:06%2002%2020%2018%2017>:10, Jonathan Druart wrote:
Hi devs,
I have just caught that:
Koha::Patron->is_expired returns 0 if $self->dateexpiry eq '0000-00-00' And there is a test I wrote for it on bug 17578 (commit 5a0a2ce584dec74808f471b0f92b2114c3d6029e , GetMemberDetails - Remove is_expired)
But then we also have, in C4::Circulation::CanBookBeIssued: 752 if ( !defined $patron->dateexpiry || $patron->dateexpiry eq '0000-00-00') { 753 $issuingimpossible{EXPIRED} = 1; 754 } else { With a test: is( $issuingimpossible->{EXPIRED}, 1, 'The patron should be considered as expired if dateexpiry is 0000-00-00' );
So, my questions, do you have a very old Koha installations to search if there is borrowers.is_expired == "0000-00-00" in it? Do you remember if it meant expired or not at some point?
I am trying to adapt our code to sql strict modes, and this value is no longer valid, we will need to update existing values.
Cheers, Jonathan
(yes, the same code should be used)
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website :http://www.koha-community.org/ git :http://git.koha-community.org/ bugs :http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hiya! On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium. Best regards, Magnus Libriotech
Hello, For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00" Regards S. Meynieux -- Responsable support BibLibre + 33 (0)4 91 81 35 08 http://www.biblibre.com Le 14/02/2018 à 12:12, Katrin Fischer a écrit :
I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00. *Gesendet:* Mittwoch, 14. Februar 2018 um 08:18 Uhr *Von:* "Magnus Enger" <magnus@enger.priv.no> *An:* koha-devel@lists.koha-community.org *Betreff:* Re: [Koha-devel] 0000-00-00 is expired? Hiya!
On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium.
Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
In all my 65 instances, there's not '0000-00-00'. This is probably a data migration issue. El mié., 14 feb. 2018 a las 11:05, Sophie Meynieux (< sophie.meynieux@biblibre.com>) escribió:
Hello,
For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00"
Regards
S. Meynieux
-- Responsable support BibLibre+ 33 (0)4 91 81 35 08 <+33%204%2091%2081%2035%2008>http://www.biblibre.com
Le 14/02/2018 à 12:12, Katrin Fischer a écrit :
I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00.
*Gesendet:* Mittwoch, 14. Februar 2018 um 08:18 Uhr *Von:* "Magnus Enger" <magnus@enger.priv.no> <magnus@enger.priv.no> *An:* koha-devel@lists.koha-community.org *Betreff:* Re: [Koha-devel] 0000-00-00 is expired? Hiya!
On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium.
Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
Great news then :) Sophie and Bob, could you determine what means this value? Would it make sense to update it with 9999-12-31 and consider it as "will never expired"? On Wed, 14 Feb 2018 at 12:13 Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
In all my 65 instances, there's not '0000-00-00'. This is probably a data migration issue.
El mié., 14 feb. 2018 a las 11:05, Sophie Meynieux (< sophie.meynieux@biblibre.com>) escribió:
Hello,
For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00"
Regards
S. Meynieux
-- Responsable support BibLibre+ 33 (0)4 91 81 35 08 <+33%204%2091%2081%2035%2008>http://www.biblibre.com
Le 14/02/2018 à 12:12, Katrin Fischer a écrit :
I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00.
*Gesendet:* Mittwoch, 14. Februar 2018 um 08:18 Uhr *Von:* "Magnus Enger" <magnus@enger.priv.no> <magnus@enger.priv.no> *An:* koha-devel@lists.koha-community.org *Betreff:* Re: [Koha-devel] 0000-00-00 is expired? Hiya!
On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium.
Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Sounds to me like NULL was meant ? Using 9999-12-31 resulted in expensive date calculations previously. ________________________________ Van: koha-devel-bounces@lists.koha-community.org <koha-devel-bounces@lists.koha-community.org> namens Jonathan Druart <jonathan.druart@bugs.koha-community.org> Verzonden: woensdag 14 februari 2018 16:41 Aan: koha-devel@lists.koha-community.org Onderwerp: Re: [Koha-devel] 0000-00-00 is expired? Great news then :) Sophie and Bob, could you determine what means this value? Would it make sense to update it with 9999-12-31 and consider it as "will never expired"? On Wed, 14 Feb 2018 at 12:13 Tomas Cohen Arazi <tomascohen@gmail.com<mailto:tomascohen@gmail.com>> wrote: In all my 65 instances, there's not '0000-00-00'. This is probably a data migration issue. El mié., 14 feb. 2018 a las 11:05, Sophie Meynieux (<sophie.meynieux@biblibre.com<mailto:sophie.meynieux@biblibre.com>>) escribió: Hello, For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00" Regards S. Meynieux -- Responsable support BibLibre + 33 (0)4 91 81 35 08<tel:+33%204%2091%2081%2035%2008> http://www.biblibre.com Le 14/02/2018 à 12:12, Katrin Fischer a écrit : I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00. Gesendet: Mittwoch, 14. Februar 2018 um 08:18 Uhr Von: "Magnus Enger" <magnus@enger.priv.no><mailto:magnus@enger.priv.no> An: koha-devel@lists.koha-community.org<mailto:koha-devel@lists.koha-community.org> Betreff: Re: [Koha-devel] 0000-00-00 is expired? Hiya! On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org><mailto:jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium. Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org<mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org<mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org<mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (https://theke.io<http://theke.io/>) ✆ +54 9351 3513384<tel:+54%209%20351%20351-3384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org<mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
yes could be NULL instead. (date calculation perf issue is fixed) On Wed, 14 Feb 2018 at 12:50 Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
Sounds to me like NULL was meant ?
Using 9999-12-31 resulted in expensive date calculations previously.
------------------------------ *Van:* koha-devel-bounces@lists.koha-community.org < koha-devel-bounces@lists.koha-community.org> namens Jonathan Druart < jonathan.druart@bugs.koha-community.org> *Verzonden:* woensdag 14 februari 2018 16:41 *Aan:* koha-devel@lists.koha-community.org *Onderwerp:* Re: [Koha-devel] 0000-00-00 is expired?
Great news then :)
Sophie and Bob, could you determine what means this value? Would it make sense to update it with 9999-12-31 and consider it as "will never expired"?
On Wed, 14 Feb 2018 at 12:13 Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
In all my 65 instances, there's not '0000-00-00'. This is probably a data migration issue.
El mié., 14 feb. 2018 a las 11:05, Sophie Meynieux (< sophie.meynieux@biblibre.com>) escribió:
Hello,
For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00"
Regards
S. Meynieux
-- Responsable support BibLibre+ 33 (0)4 91 81 35 08 <+33%204%2091%2081%2035%2008>http://www.biblibre.com
Le 14/02/2018 à 12:12, Katrin Fischer a écrit :
I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00.
*Gesendet:* Mittwoch, 14. Februar 2018 um 08:18 Uhr *Von:* "Magnus Enger" <magnus@enger.priv.no> <magnus@enger.priv.no> *An:* koha-devel@lists.koha-community.org *Betreff:* Re: [Koha-devel] 0000-00-00 is expired? Hiya!
On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium.
Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
It should be null. El mié., 14 feb. 2018 a las 12:58, Jonathan Druart (< jonathan.druart@bugs.koha-community.org>) escribió:
yes could be NULL instead. (date calculation perf issue is fixed)
On Wed, 14 Feb 2018 at 12:50 Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
Sounds to me like NULL was meant ?
Using 9999-12-31 resulted in expensive date calculations previously.
------------------------------ *Van:* koha-devel-bounces@lists.koha-community.org < koha-devel-bounces@lists.koha-community.org> namens Jonathan Druart < jonathan.druart@bugs.koha-community.org> *Verzonden:* woensdag 14 februari 2018 16:41 *Aan:* koha-devel@lists.koha-community.org *Onderwerp:* Re: [Koha-devel] 0000-00-00 is expired?
Great news then :)
Sophie and Bob, could you determine what means this value? Would it make sense to update it with 9999-12-31 and consider it as "will never expired"?
On Wed, 14 Feb 2018 at 12:13 Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
In all my 65 instances, there's not '0000-00-00'. This is probably a data migration issue.
El mié., 14 feb. 2018 a las 11:05, Sophie Meynieux (< sophie.meynieux@biblibre.com>) escribió:
Hello,
For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00"
Regards
S. Meynieux
-- Responsable support BibLibre+ 33 (0)4 91 81 35 08 <+33%204%2091%2081%2035%2008>http://www.biblibre.com
Le 14/02/2018 à 12:12, Katrin Fischer a écrit :
I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00.
*Gesendet:* Mittwoch, 14. Februar 2018 um 08:18 Uhr *Von:* "Magnus Enger" <magnus@enger.priv.no> <magnus@enger.priv.no> *An:* koha-devel@lists.koha-community.org *Betreff:* Re: [Koha-devel] 0000-00-00 is expired? Hiya!
On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium.
Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
Actually we already have Bug 14717: Prevent 0000-00-00 dates in patron data) on 3.21.00.023 which does that! On Wed, 14 Feb 2018 at 13:03 Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
It should be null.
El mié., 14 feb. 2018 a las 12:58, Jonathan Druart (< jonathan.druart@bugs.koha-community.org>) escribió:
yes could be NULL instead. (date calculation perf issue is fixed)
On Wed, 14 Feb 2018 at 12:50 Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
Sounds to me like NULL was meant ?
Using 9999-12-31 resulted in expensive date calculations previously.
------------------------------ *Van:* koha-devel-bounces@lists.koha-community.org < koha-devel-bounces@lists.koha-community.org> namens Jonathan Druart < jonathan.druart@bugs.koha-community.org> *Verzonden:* woensdag 14 februari 2018 16:41 *Aan:* koha-devel@lists.koha-community.org *Onderwerp:* Re: [Koha-devel] 0000-00-00 is expired?
Great news then :)
Sophie and Bob, could you determine what means this value? Would it make sense to update it with 9999-12-31 and consider it as "will never expired"?
On Wed, 14 Feb 2018 at 12:13 Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
In all my 65 instances, there's not '0000-00-00'. This is probably a data migration issue.
El mié., 14 feb. 2018 a las 11:05, Sophie Meynieux (< sophie.meynieux@biblibre.com>) escribió:
Hello,
For all our customers that are hosted on our servers, only one has one patron with dateexpiry = "0000-00-00"
Regards
S. Meynieux
-- Responsable support BibLibre+ 33 (0)4 91 81 35 08 <+33%204%2091%2081%2035%2008>http://www.biblibre.com
Le 14/02/2018 à 12:12, Katrin Fischer a écrit :
I've also checked our oldest 5 - didn't find any patrons with dateexpiry 0000-00-00.
*Gesendet:* Mittwoch, 14. Februar 2018 um 08:18 Uhr *Von:* "Magnus Enger" <magnus@enger.priv.no> <magnus@enger.priv.no> *An:* koha-devel@lists.koha-community.org *Betreff:* Re: [Koha-devel] 0000-00-00 is expired? Hiya!
On 13 February 2018 at 20:06, Jonathan Druart <jonathan.druart@bugs.koha-community.org> <jonathan.druart@bugs.koha-community.org> wrote:
It would be useful to know the return of SELECT COUNT(*) FROM borrowers where dateexpiry="0000-00-00" on old installations.
I just checked my 5 oldest instances (upgraded regularly since 2009/2010) and none of them had any users meeting this criterium.
Best regards, Magnus Libriotech _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F
participants (8)
-
Bob Birchall -
Jonathan Druart -
Katrin Fischer -
Katrin Fischer
-
Magnus Enger -
Marcel de Rooy -
Sophie Meynieux -
Tomas Cohen Arazi