Re: [Koha-devel] Patch format
On 1 August 2011 10:17, Edgar Fuß <ef@math.uni-bonn.de> wrote:
If you use git format-patch and then git send-email to send it to the koha-patches mailing list. Oh well, I'll try this tomorrow. It's past midnight in my timezone now.
that's not as nessecary the mailing list is the main place Is that information somehow pushed back to bugzilla? Or how do I know someone already posted a patch to the list for a bug I would start to work on?
This is the way the other 147 developers do it I don't quite think I would regard myself a Koha developer. I'm sort of hopping from one Open Source project to another. So it's sometimes difficult for me to get accustomed to the project's bug reporting policy. However, Koha seems to be the first project I met preferring git patches git format-patch'ed git send-email'ed to a patches list. I'll try to get accustomed to that.
Here are some good resources http://wiki.koha-community.org/wiki/Version_Control_Using_Git http://wiki.koha-community.org/wiki/Set_an_email_alias_for_Koha_patches http://wiki.koha-community.org/wiki/Sign_off_on_patches http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow Chris
On 2011-08-1, at 10:19 AM, Chris Cormack wrote:
On 1 August 2011 10:17, Edgar Fuß <ef@math.uni-bonn.de> wrote:
If you use git format-patch and then git send-email to send it to the koha-patches mailing list. Oh well, I'll try this tomorrow. It's past midnight in my timezone now.
that's not as nessecary the mailing list is the main place Is that information somehow pushed back to bugzilla? Or how do I know someone already posted a patch to the list for a bug I would start to work on?
every patch should have a bug ticket created in bugzilla, *before* the patch is sent to the patches mailing-list so... i search bugzilla to see if someone has already posted a patch to my problem
However, Koha seems to be the first project I met preferring git patches git format-patch'ed git send-email'ed to a patches list. I'll try to get accustomed to that.
i think an little improvement to our current patch workflow, would be to just attach the patch to a bug, in bugzilla an automated bugzilla script could then send that new patch to the patches list this proposed method removes the double-handling of a patch (sending to patches-list and attaching to bugzilla) and would help encourage people to use bugzilla to track their patches, rather than sending the patch to the list, and the patch getting lost a good idea, or not? Mason
On 1 August 2011 02:49, Mason James <mtj@kohaaloha.com> wrote:
i think an little improvement to our current patch workflow, would be to just attach the patch to a bug, in bugzilla an automated bugzilla script could then send that new patch to the patches list
+1 yay! Best regards, Magnus Enger libriotech.no
On 1 August 2011 19:03, Magnus Enger <magnus@enger.priv.no> wrote:
On 1 August 2011 02:49, Mason James <mtj@kohaaloha.com> wrote:
i think an little improvement to our current patch workflow, would be to just attach the patch to a bug, in bugzilla an automated bugzilla script could then send that new patch to the patches list
+1 yay!
Patch for said script gratefully accepted, until then can we keep sending to the mailing list please. Chris
On 2011-08-1, at 7:06 PM, Chris Cormack wrote:
On 1 August 2011 19:03, Magnus Enger <magnus@enger.priv.no> wrote:
On 1 August 2011 02:49, Mason James <mtj@kohaaloha.com> wrote:
i think an little improvement to our current patch workflow, would be to just attach the patch to a bug, in bugzilla an automated bugzilla script could then send that new patch to the patches list
+1 yay!
Patch for said script gratefully accepted,
cool, i'll put my hand up to sort this script
However, Koha seems to be the first project I met preferring git patches git format-patch'ed git send-email'ed to a patches list. I'll try to get accustomed to that. FWIW, I did git-end-email git-format-patch'ed versions to koha-patches, where those messages of mine are humbly awaiting moderator's approval (I'm not subscribed to that list).
On 2011-08-7, at 4:20 AM, Edgar Fuß wrote:
However, Koha seems to be the first project I met preferring git patches git format-patch'ed git send-email'ed to a patches list. I'll try to get accustomed to that. FWIW, I did git-end-email git-format-patch'ed versions to koha-patches, where those messages of mine are humbly awaiting moderator's approval (I'm not subscribed to that list).
yeah, i would definitely subscribe to to that list, before mailing that list
yeah, i would definitely subscribe to to that list, before mailing that list Do I read this correctly as ``your moderation request will never be granted'', so I can (and am expected to) re-post after subscribing without the risk of my post appearing twice?
If so, someone may consider editing the email template being sent, which reads
Either the message will get posted to the list, or you will receive notification of the moderator's decision. to something better reflecting moderator's policy.
* Edgar Fuß (ef@math.uni-bonn.de) wrote:
yeah, i would definitely subscribe to to that list, before mailing that list Do I read this correctly as ``your moderation request will never be granted'', so I can (and am expected to) re-post after subscribing without the risk of my post appearing twice?
Nope, you don't. Mason is not a moderator of the list and there is no such policy.
If so, someone may consider editing the email template being sent, which reads
Either the message will get posted to the list, or you will receive notification of the moderator's decision. to something better reflecting moderator's policy.
It reflects reality, I'm sure one of the list moderators will let it through when they have time. You can email Biblibre if you want to nudge them along. Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
So I spent the last half hour finding out how to re-generate a patch with git, subscribed to koha-patches, re-sent my patches and will probably immediately unsubscribe again. As I actually do read ``Welcome to the foobar mailing list'' introductory mails: Someone may want to edit the mail sent upon koha-patches subscription:
This is the general discussion list for librarians and others interested in the Koha FOSS (free & open-source software) LMS/ILS (library management system/integrated library system) and related activities. This seems copy-pasted from the description of the koha list.
Please feel free to use this list for announcements, questions and discussions on relevant topics This probably doesn't apply either.
Emails from non-subscribers (and other emails held for review) will usually be sent to this list in a batch once a day. This definitely does not apply. At least not for my understanding of ``usually''.
* Edgar Fuß (ef@math.uni-bonn.de) wrote:
So I spent the last half hour finding out how to re-generate a patch with git, subscribed to koha-patches, re-sent my patches and will probably immediately unsubscribe again.
Why? As I just said, the moderators will let your messages through Im unsure why you have such a hostile attitude. Maybe it is just your email manner. Anyway best of luck. Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
On 2011-08-7, at 9:42 PM, Edgar Fuß wrote:
yeah, i would definitely subscribe to to that list, before mailing that list Do I read this correctly as ``your moderation request will never be granted'', so I can (and am expected to) re-post after subscribing without the risk of my post appearing twice?
if i were you, i would subscribe to the list - then re-post your email(s) whats the worst that can happen?
participants (5)
-
Chris Cormack -
Chris Cormack -
Edgar Fuß -
Magnus Enger -
Mason James