Tests failing on master
Hi everyone, I just wanted to mention that lots of tests are failing on master right now :-/ We've already fixed some of them, but patch authors that might have caused the breakages, please feel responsible for those and provide fixes. If you cannot find a way to fix them, just ask for help :-D Thanks! -- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F
Greetings, Boo to failing tests.
... patch authors that might have caused the breakages, please feel responsible for those and provide fixes. If you cannot find a way to fix them, just ask for help :-D What if I’m too busy to figure out where the patch belongs and not responsible? From 4ef80d8f802df34eb22f42297a5fe29c4c2e30d7 Mon Sep 17 00:00:00 2001 From: Mark Tompsett <mtompset@hotmail.com> Date: Wed, 30 Mar 2016 12:10:36 -0400 Subject: [PATCH 6/6] blah
--- t/db_dependent/OAI/Server.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/OAI/Server.t b/t/db_dependent/OAI/Server.t index 4e2d626..05c2d87 100644 --- a/t/db_dependent/OAI/Server.t +++ b/t/db_dependent/OAI/Server.t @@ -97,9 +97,9 @@ my $expected = { schema => 'http://www.openarchives.org/OAI/2.0/oai_dc.xsd', }, { - metadataNamespace => 'http://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim', + metadataNamespace => 'http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim', metadataPrefix => 'marcxml', - schema => 'http://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim.xsd', + schema => 'http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd', }, ], }, -- 2.1.4
Heh. That's filled already (patch included). El 30/3/2016 18:12, "Mark Tompsett" <mtompset@hotmail.com> escribió:
Greetings,
Boo to failing tests. [image: Sad smile]
... patch authors that might have caused the breakages, please feel responsible for those and provide fixes. If you cannot find a way to fix them, just ask for help :-D
What if I’m too busy to figure out where the patch belongs and not responsible? [image: Smile]
From 4ef80d8f802df34eb22f42297a5fe29c4c2e30d7 Mon Sep 17 00:00:00 2001 From: Mark Tompsett <mtompset@hotmail.com> Date: Wed, 30 Mar 2016 12:10:36 -0400 Subject: [PATCH 6/6] blah
--- t/db_dependent/OAI/Server.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/db_dependent/OAI/Server.t b/t/db_dependent/OAI/Server.t index 4e2d626..05c2d87 100644 --- a/t/db_dependent/OAI/Server.t +++ b/t/db_dependent/OAI/Server.t @@ -97,9 +97,9 @@ my $expected = { schema => ' http://www.openarchives.org/OAI/2.0/oai_dc.xsd', }, { - metadataNamespace => 'http://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim', + metadataNamespace => 'http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim', metadataPrefix => 'marcxml', - schema => 'http://www.loc.gov/MARC21/slim http://www.loc.gov/ standards/marcxml/schema/MARC21slim.xsd', + schema => ' http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd', }, ], }, -- 2.1.4
t_db_dependent_OAI_Server_t.ListMetadataFormats => Regarding Mark comment, it's fixed (bug#?) t_db_dependent_TestBuilder_t.TestBuilder should be able to create an object for every sources => Pass for me using kohastructure.sql t_db_dependent_db_structure_t.Number of runned tests does not match plan. => This is because we have added constraint and or column and not updated the number of tests. If the change -use Test::More tests => 409; +use Test::More tests => 415; is made, all tests pass. Should we 1) remove the plan (and add done_testing) or 2) be aware of that and be care? I'd vote for 1. xt_single_quotes_t.Files do not contain single quotes _(' => Will be fixed by bug 16178 t_db_dependent_ColumnsSettings_t.columns for admin>currency>currencies-table => Will be fixed by bug 16177 t_db_dependent_Reports_Guided_t.filter takes report id => I got the failure, but only once, the first one! Could someone add 72 use Data::Dumper;warn Dumper get_saved_reports( $report_ids[0] ); Before executing the tests? t_db_dependent_UsageStats_t.$report->{systempreferences}->{OpenLibrarySearch} = 1 => Will be fixed by bug 16176 xt_author_icondirectories_t.STAFF prog and OPAC xslt icon directories have same contents => Why does this test want Staff prog and opac xslt icon to have the same content?? xt_author_icondirectories_t.opac_icon_directory: koha-tmpl/opac-tmpl/xslt/itemtypeimg exists xt_author_icondirectories_t.Number of runned tests does not match plan. => Seems that it was not a good idea to have a koha-tmpl/opac-tmpl/xslt dir t_db_dependent_Circulation_Issuingrule_t.GetIssuingCharge returns issuingrule1's informations => ok for me 2016-03-30 16:36 GMT+01:00 Tomas Cohen Arazi <tomascohen@gmail.com>:
Hi everyone, I just wanted to mention that lots of tests are failing on master right now :-/
We've already fixed some of them, but patch authors that might have caused the breakages, please feel responsible for those and provide fixes. If you cannot find a way to fix them, just ask for help :-D
Thanks!
-- Tomás Cohen Arazi Theke Solutions (http://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Please have a look too at bug 16155 (TestBuilder changes). Van: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] Namens Tomas Cohen Arazi Verzonden: woensdag 30 maart 2016 17:36 Aan: koha-devel <koha-devel@lists.koha-community.org> Onderwerp: [Koha-devel] Tests failing on master Hi everyone, I just wanted to mention that lots of tests are failing on master right now :-/ We've already fixed some of them, but patch authors that might have caused the breakages, please feel responsible for those and provide fixes. If you cannot find a way to fix them, just ask for help :-D Thanks! -- Tomás Cohen Arazi Theke Solutions (http://theke.io<http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
participants (4)
-
Jonathan Druart -
Marcel de Rooy -
Mark Tompsett -
Tomas Cohen Arazi