Hi I would like to get the name of installation directory for putting in etc/..... a YAML file for configuring facets. I have been looking at the patch introducing SolR, and I found in "Koha / Koha / SearchEngine / Solr / Config.pm" this line : default => C4::Context->config("installdir") . qq{/etc/searchengine/solr/indexes.yaml}, That's exacty what I want... Except there is no "installdir" in my koha-conf.xml. In fact, I think it was introduced in this attachment http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6415 made for Bug 7167 As Bug 7167 has been reverted, installdir does not exist anymore. But it has "Passed QA" again after it was revert. So, could you tell me if this bug will be pushed into master? And if not, what can I do to get the value of the installation directory ? Regards, M. Saby -- Mathieu Saby Service d'Informatique Documentaire Service Commun de la Documentation Université Rennes 2 Téléphone : 02 99 14 12 65 Courriel : mathieu.saby@univ-rennes2.fr
Sorry, I was wrong, this pach only asked to create an "installdir" line in koha-conf. But that does not solve my problem : why is there a reference to "installdir" in "Koha / Koha / SearchEngine / Solr / Config.pm" if installdir is not defined in standard koha-conf.xml? Is it a bug to fix? Mathieu Mathieu Saby a écrit :
Hi I would like to get the name of installation directory for putting in etc/..... a YAML file for configuring facets. I have been looking at the patch introducing SolR, and I found in "Koha / Koha / SearchEngine / Solr / Config.pm" this line :
default => C4::Context->config("installdir") . qq{/etc/searchengine/solr/indexes.yaml}, That's exacty what I want... Except there is no "installdir" in my koha-conf.xml. In fact, I think it was introduced in this attachment http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6415 made for Bug 7167 As Bug 7167 has been reverted, installdir does not exist anymore. But it has "Passed QA" again after it was revert. So, could you tell me if this bug will be pushed into master? And if not, what can I do to get the value of the installation directory ? Regards, M. Saby
-- Mathieu Saby Service d'Informatique Documentaire Service Commun de la Documentation Université Rennes 2 Téléphone : 02 99 14 12 65 Courriel : mathieu.saby@univ-rennes2.fr
Hi, On Mon, Sep 23, 2013 at 5:08 AM, Mathieu Saby <mathieu.saby@univ-rennes2.fr>wrote:
Sorry, I was wrong, this pach only asked to create an "installdir" line in koha-conf. But that does not solve my problem : why is there a reference to "installdir" in "Koha / Koha / SearchEngine / Solr / Config.pm" if installdir is not defined in standard koha-conf.xml? Is it a bug to fix?
Yes,references to installdir are a bug, IMO, as they won't work. As far as your own patch is concerned, if the configuration file must live outside the database, I suggest following the example of this line in etc/koha-conf.xml: <queryparser_config>__KOHA_CONF_DIR__/searchengine/queryparser.yaml</queryparser_config> Specifying the full path to the new config file in koha-conf.xml is safest. It is actually an error to assume that Koha's configuration directory is a child of an "installation" directory -- for example, the Debian packages don't lay files out like that. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Well, so, if I understand, the best would be to write a patch to add "configdir" to koha-conf.xml. Its value should be __KOHA_CONF_DIR__ I suppose? So it could be used by my patch and probably by others. I probably won't have time enough (working on facets is already a big job, and I have other things to do in my library, and I will leave community in 2 or 3 months...) Does somebody wants to do that? M. Saby Galen Charlton a écrit :
Hi,
On Mon, Sep 23, 2013 at 5:08 AM, Mathieu Saby <mathieu.saby@univ-rennes2.fr <mailto:mathieu.saby@univ-rennes2.fr>> wrote:
Sorry, I was wrong, this pach only asked to create an "installdir" line in koha-conf. But that does not solve my problem : why is there a reference to "installdir" in "Koha / Koha / SearchEngine / Solr / Config.pm" if installdir is not defined in standard koha-conf.xml? Is it a bug to fix?
Yes,references to installdir are a bug, IMO, as they won't work. As far as your own patch is concerned, if the configuration file must live outside the database, I suggest following the example of this line in etc/koha-conf.xml:
<queryparser_config>__KOHA_CONF_DIR__/searchengine/queryparser.yaml</queryparser_config>
Specifying the full path to the new config file in koha-conf.xml is safest. It is actually an error to assume that Koha's configuration directory is a child of an "installation" directory -- for example, the Debian packages don't lay files out like that.
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com <mailto:gmc@esilibrary.com> direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
-- Mathieu Saby Service d'Informatique Documentaire Service Commun de la Documentation Université Rennes 2 Téléphone : 02 99 14 12 65 Courriel : mathieu.saby@univ-rennes2.fr
Hi, On Tue, Sep 24, 2013 at 12:54 AM, Mathieu Saby <mathieu.saby@univ-rennes2.fr
wrote:
** Well, so, if I understand, the best would be to write a patch to add "configdir" to koha-conf.xml. Its value should be __KOHA_CONF_DIR__ I suppose? So it could be used by my patch and probably by others.
Actually, I think a path to point to the specific configuration file you're adding is better. The problem with adding a configdir element to koha-conf.xml is that it doesn't distinguish between configuration files that are shared by all Koha sites on a server and which are not. For example, on a Git install you can assume that all Zebra configuration files live under $configdir/zebradb/, but the Debian package puts some in a shared /etc/koha/zebradb/ directory and some site-specific ones (e.g., zebra-biblios.cfg) under /etc/koha/sites/$SITE. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
On Tue, Sep 24, 2013 at 3:51 PM, Galen Charlton <gmc@esilibrary.com> wrote:
Hi,
On Tue, Sep 24, 2013 at 12:54 AM, Mathieu Saby < mathieu.saby@univ-rennes2.fr> wrote:
** Well, so, if I understand, the best would be to write a patch to add "configdir" to koha-conf.xml. Its value should be __KOHA_CONF_DIR__ I suppose? So it could be used by my patch and probably by others.
Actually, I think a path to point to the specific configuration file you're adding is better. The problem with adding a configdir element to koha-conf.xml is that it doesn't distinguish between configuration files that are shared by all Koha sites on a server and which are not.
For example, on a Git install you can assume that all Zebra configuration files live under $configdir/zebradb/, but the Debian package puts some in a shared /etc/koha/zebradb/ directory and some site-specific ones (e.g., zebra-biblios.cfg) under /etc/koha/sites/$SITE.
I'm not following the thread so I'm not sure the scenario is similar, but you could take a look at how 'docdir' is handled. Regards To+
participants (3)
-
Galen Charlton -
Mathieu Saby -
Tomas Cohen Arazi