Question about correct hold availability checking in the OPAC
Bug 19298, "allow_onshelf_holds is not calculated correctly in opac-shelves" added a check of circulation rules to control whether the "Place hold" button should appear on the OPAC list contents page. I'm trying to restart my work on Bug 13121, "Move search results "action" links ("Place hold," "Add tag," etc) into include file" and so I'm interested in having unified template logic. Does anyone know if there was a reason the change made in Bug 19298 wasn't made to the OPAC search results page? Thanks, -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org
Hi Owen, I am not sure we are ready for that, it could impact performance if several records have a lot of items. That should be confirmed, or unconfirmed (benchmark) to evaluate this impact. Cheers, Jonathan Le lun. 6 janv. 2020 à 20:47, Owen Leonard <oleonard@myacpl.org> a écrit :
Bug 19298, "allow_onshelf_holds is not calculated correctly in opac-shelves" added a check of circulation rules to control whether the "Place hold" button should appear on the OPAC list contents page.
I'm trying to restart my work on Bug 13121, "Move search results "action" links ("Place hold," "Add tag," etc) into include file" and so I'm interested in having unified template logic.
Does anyone know if there was a reason the change made in Bug 19298 wasn't made to the OPAC search results page?
Thanks,
-- Owen
-- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Does anyone know if there was a reason the change made in Bug 19298 wasn't made to the OPAC search results page?
I am not sure we are ready for that, it could impact performance if several records have a lot of items.
I certainly understand this concern. I think it's important to also weigh the fact that with this feature only in place on some OPAC pages the user potentially has a confusing or conflicting idea of what they can put on hold. -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org
participants (2)
-
Jonathan Druart -
Owen Leonard