bugzilla workflow, question when "pushed, pls test" rejected
Hello, On http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3495, chris has pushed a patch, it's now "patch pushed" "please test". I tested and have found a problem (see comment 3) Should I modify the patch status ? which value to set to have the RM seing there's something more to do ? What i know for sure is that it can't stay "patch pushed", as there's a problem ;-) -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On Tue, Feb 22, 2011 at 6:04 AM, Paul Poulain <paul.poulain@biblibre.com>wrote:
Hello,
On http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3495, chris has pushed a patch, it's now "patch pushed" "please test". I tested and have found a problem (see comment 3) Should I modify the patch status ? which value to set to have the RM seing there's something more to do ?
What i know for sure is that it can't stay "patch pushed", as there's a problem ;-)
Chris can correct me if I'm wrong.... Once the patch has been pushed to a QA branch it is "Pushed for QA." If it fails QA it should be "Failed QA." If it passes it should be "Needs sign off" or "Signed off." Once pushed to master it is "Patch Pushed." If at any time it fails a test the status should return to "Failed QA." At least that's how I read it. Kind Regards, Chris
Le 22/02/2011 12:46, Chris Nighswonger a écrit :
Chris can correct me if I'm wrong....
Once the patch has been pushed to a QA branch it is "Pushed for QA."
If it fails QA it should be "Failed QA."
If it passes it should be "Needs sign off" or "Signed off."
Once pushed to master it is "Patch Pushed."
If at any time it fails a test the status should return to "Failed QA." That's how I read it too, but when "patch pushed", there's something in master and something that is wrong. So it should not just be "failed QA" because in this status a patch can be hidden in a middle of many other "failed QA" that have no consequences in master.
the more I think of it the more I suspect it would be a good idea to have a new status. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On Tue, Feb 22, 2011 at 6:59 AM, Paul Poulain <paul.poulain@biblibre.com>wrote:
Le 22/02/2011 12:46, Chris Nighswonger a écrit :
Chris can correct me if I'm wrong....
Once the patch has been pushed to a QA branch it is "Pushed for QA."
If it fails QA it should be "Failed QA."
If it passes it should be "Needs sign off" or "Signed off."
Once pushed to master it is "Patch Pushed."
If at any time it fails a test the status should return to "Failed QA." That's how I read it too, but when "patch pushed", there's something in master and something that is wrong. So it should not just be "failed QA" because in this status a patch can be hidden in a middle of many other "failed QA" that have no consequences in master.
the more I think of it the more I suspect it would be a good idea to have a new status.
I understand what you are thinking now. I think if we just followed the use of the status and resolution fields (see http://bugs.koha-community.org/bugzilla3/page.cgi?id=fields.html#status) then in the case you suggest we would just re-open the bug. I wonder if we are not creating solutions for a problem which is really due to a lack of utilizing solutions which already exist? Kind Regards, Chris
I understand what you are thinking now.
I think if we just followed the use of the status and resolution fields (see http://bugs.koha-community.org/bugzilla3/page.cgi?id=fields.html#status) then in the case you suggest we would just re-open the bug.
I wonder if we are not creating solutions for a problem which is really due to a lack of utilizing solutions which already exist? I don't think so: the status (not patch status) is "assigned, so the bug is not considered as "resolved". chris is just waiting for feedback to confirm it can be closed (I'm doing that on all bugs where biblibre.com is reporter or assigned or cc: atm, already closed something like 20 !). Sometimes the bug can't be closed because the applied solution has a
Le 22/02/2011 13:42, Chris Nighswonger a écrit : problem (other examples : 3550, 3816, 3924, 4044). Staying "assigned" and "patch pushed" is incomplete: OK, a patch has been pushed, but i've detected a problem on it ! let's chris waking up and we will see (he may have more important things to do those days if he has family or friends on christchurch :\ ) -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
participants (2)
-
Chris Nighswonger -
Paul Poulain