Request for sign-off: component part records feature (Bug 11175)
Hi, there has been this long-standing feature pending from 2013 for Koha for listing component part records in the host record biblio details page. I have rescued the original patches by submitting follow-ups but now I haven't got any sign-offs for 2 months. I think the issue is that this needs developers to do the sign-off since the zebra index needs to be re-indexed to test this. So if you are a developer of a library that uses component part records I would like to ask you take a look at this bug 11175 [1] and sign-off if you just can! Thanks already beforehand! :) [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 -- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto
Hi Joonas, I've taken another look at the report (my last look was in 2014), but I don't think that this is the right approach. It also doesn't take into account Elasticsearch. I might be wrong, but I don't imagine that this would pass QA or be pushed to master. I'm actually tempted to mark it as "In Discussion" to be honest. David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Joonas Kylmälä Sent: Monday, 7 September 2020 7:55 PM To: koha-devel <koha-devel@lists.koha-community.org> Subject: [Koha-devel] Request for sign-off: component part records feature (Bug 11175) Hi, there has been this long-standing feature pending from 2013 for Koha for listing component part records in the host record biblio details page. I have rescued the original patches by submitting follow-ups but now I haven't got any sign-offs for 2 months. I think the issue is that this needs developers to do the sign-off since the zebra index needs to be re-indexed to test this. So if you are a developer of a library that uses component part records I would like to ask you take a look at this bug 11175 [1] and sign-off if you just can! Thanks already beforehand! :) [1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 -- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi, thanks for taking a look! There is already some discussion in the bug report about Elasticsearch and about the backend implementation but that is from 2018 and earlier so I'm not sure it is up to date and is that's why you have concerns about the approach? Please let us know in the bug report comments, and feel free to mark "In discussion" if needed. Also please see comment 59 for why I decided to rescue this and whether it is okay in your opinion. Joonas On 08/09/2020 04:27, dcook@prosentient.com.au wrote:
Hi Joonas,
I've taken another look at the report (my last look was in 2014), but I don't think that this is the right approach. It also doesn't take into account Elasticsearch.
I might be wrong, but I don't imagine that this would pass QA or be pushed to master. I'm actually tempted to mark it as "In Discussion" to be honest.
David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia
Office: 02 9212 0899 Online: 02 8005 0595
-- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto
Hi Joonas, I've just taken a look at comment 59 but I'm not sure why you decided to rescue it based on that comment. I'm happy to leave some feedback on the bug report. I'll do that quickly now. Cheers, David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Sent: Tuesday, 8 September 2020 5:10 PM To: dcook@prosentient.com.au Cc: 'koha-devel' <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Request for sign-off: component part records feature (Bug 11175) Hi, thanks for taking a look! There is already some discussion in the bug report about Elasticsearch and about the backend implementation but that is from 2018 and earlier so I'm not sure it is up to date and is that's why you have concerns about the approach? Please let us know in the bug report comments, and feel free to mark "In discussion" if needed. Also please see comment 59 for why I decided to rescue this and whether it is okay in your opinion. Joonas On 08/09/2020 04:27, dcook@prosentient.com.au wrote:
Hi Joonas,
I've taken another look at the report (my last look was in 2014), but I don't think that this is the right approach. It also doesn't take into account Elasticsearch.
I might be wrong, but I don't imagine that this would pass QA or be pushed to master. I'm actually tempted to mark it as "In Discussion" to be honest.
David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia
Office: 02 9212 0899 Online: 02 8005 0595
-- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto
Hi, On 08/09/2020 10:15, dcook@prosentient.com.au wrote:
I've just taken a look at comment 59 but I'm not sure why you decided to rescue it based on that comment.
I did it so that the GUI code does not need to be rewritten because it takes time.
I'm happy to leave some feedback on the bug report. I'll do that quickly now.
Thanks! -- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto
Hi Joonas, I've left a comment. After re-reading the code, I think I can see your perspective. I don't love the patches, but I'm not going to stand in their way either. I can always just leave the system preference turned off. David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Sent: Tuesday, 8 September 2020 5:20 PM To: dcook@prosentient.com.au Cc: 'koha-devel' <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Request for sign-off: component part records feature (Bug 11175) Hi, On 08/09/2020 10:15, dcook@prosentient.com.au wrote:
I've just taken a look at comment 59 but I'm not sure why you decided to rescue it based on that comment.
I did it so that the GUI code does not need to be rewritten because it takes time.
I'm happy to leave some feedback on the bug report. I'll do that quickly now.
Thanks! -- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto
Replied on the bug.. looks pretty good to me; It was another one that had just dropped off my radar, thanks for raising it. *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager Community Release Manager (19.11, 20.05) *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize@ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info@ptfs-europe.com On Tue, 8 Sep 2020 at 08:30, <dcook@prosentient.com.au> wrote:
Hi Joonas,
I've left a comment. After re-reading the code, I think I can see your perspective.
I don't love the patches, but I'm not going to stand in their way either. I can always just leave the system preference turned off.
David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia
Office: 02 9212 0899 Online: 02 8005 0595
-----Original Message----- From: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Sent: Tuesday, 8 September 2020 5:20 PM To: dcook@prosentient.com.au Cc: 'koha-devel' <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Request for sign-off: component part records feature (Bug 11175)
Hi,
On 08/09/2020 10:15, dcook@prosentient.com.au wrote:
I've just taken a look at comment 59 but I'm not sure why you decided to rescue it based on that comment.
I did it so that the GUI code does not need to be rewritten because it takes time.
I'm happy to leave some feedback on the bug report. I'll do that quickly now.
Thanks!
-- Joonas Kylmälä Tietojärjestelmäasiantuntija
Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (3)
-
dcook＠prosentient.com.au -
Joonas Kylmälä -
Renvoize, Martin