How to convert a HTML::Template::Pro template to Template::Toolkit
Hi All There may be a need for people to convert a template to template::toolkit so they can send a patch that will apply cleanly. To do so checkout a branch based on commit d4cd05126da3accef83144d8322fcd455d7eba9b eg git checkout -b convert_templates d4cd05126da3accef83144d8322fcd455d7eba9b Now you have a branch with both sets of templates, you can then cherry-pick your template change over. And run ./installer/html-template-to-template-toolkit.pl --koharoot /path/to/the/root This will convert all the templates, if you want to just convert 1 use -f eg ./installer/html-template-to-template-toolkit.pl --koharoot /path/to/the/root -f koha-tmpl/opac-tmpl/prog/en/modules/ilsdi.tmpl So for me ./installer/html-template-to-template-toolkit.pl -c --koharoot /home/chrisc/git/koha/ -f koha-tmpl/opac-tmpl/prog/en/modules/ilsdi.tmpl Then that file will be in the koha-tt dir and you will now have a converted file. Hope this helps Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
And run ./installer/html-template-to-template-toolkit.pl --koharoot /path/to/the/root
This will convert all the templates
I was just working on converting the branch with all my jQueryUI work and found that at the end of the process I still had to copy my updated js, css, and image files into the directory with converted TT files. It turns out I should have been using "-c" to do this automatically: ./installer/html-template-to-template-toolkit.pl -c --koharoot /path/to/the/root -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
Hi All Hi All too, There may be a need for people to convert a template to template::toolkit so they can send a patch that will apply cleanly.
Le 10/04/2011 22:42, Chris Cormack a écrit : thinking of it, there is another problem: we have patches pending that contains H::T::P parts (see patches to sign-off on bugzilla...) . How will we deal with them for 3.4/3.6 The same question arises for 3.2 fixes : should we submit 2 patches : one for H::T::P, one for TT ? just one for HTP or TT, at your option, RM(aint) take care of the switch to T::T ? -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On Sat, Apr 16, 2011 at 9:45 AM, Paul Poulain <paul.poulain@biblibre.com>wrote:
Hi All Hi All too, There may be a need for people to convert a template to template::toolkit so they can send a patch that will apply cleanly.
Le 10/04/2011 22:42, Chris Cormack a écrit : thinking of it, there is another problem: we have patches pending that contains H::T::P parts (see patches to sign-off on bugzilla...) . How will we deal with them for 3.4/3.6 The same question arises for 3.2 fixes : should we submit 2 patches : one for H::T::P, one for TT ? just one for HTP or TT, at your option, RM(aint) take care of the switch to T::T ?
Speaking as RMaint, I would prefer that template which apply to maintenance branches be submitted which cleanly apply to that branch. So that would mean supplying patches against templates which use H::T::P in that format, and patches against templates using T::T in that format. The rate at which cleanly applying patches will show up in maintenance releases will be much faster than those which do not cleanly apply. Kind Regards, Chris
* Chris Nighswonger (cnighswonger@foundations.edu) wrote:
On Sat, Apr 16, 2011 at 9:45 AM, Paul Poulain <[1]paul.poulain@biblibre.com> wrote:
Le 10/04/2011 22:42, Chris Cormack a écrit : > Hi All Hi All too, > There may be a need for people to convert a template to > template::toolkit so they can send a patch that will apply cleanly. thinking of it, there is another problem: we have patches pending that contains H::T::P parts (see patches to sign-off on bugzilla...) . How will we deal with them for 3.4/3.6
As RM, id appreciate people rebase their own, but if they can't they will need to be either fixed by the person signing off or myself. Either way they will get in. Of course this only applies to those submitted for sign off before the string freeze, any new ones of course should be submitted in a form that applies cleanly. Chris
The same question arises for 3.2 fixes : should we submit 2 patches : one for H::T::P, one for TT ? just one for HTP or TT, at your option, RM(aint) take care of the switch to T::T ?
Speaking as RMaint, I would prefer that template which apply to maintenance branches be submitted which cleanly apply to that branch. So that would mean supplying patches against templates which use H::T::P in that format, and patches against templates using T::T in that format. The rate at which cleanly applying patches will show up in maintenance releases will be much faster than those which do not cleanly apply.
Kind Regards, Chris
References
Visible links 1. mailto:paul.poulain@biblibre.com
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
participants (4)
-
Chris Cormack -
Chris Nighswonger -
Owen Leonard -
Paul Poulain