interim patches for the 1.3.x installer
Hello everyone, I have just posted a patch to the 1.3.x installer.pl (to Bug 138 in bugs.koha.org), plus another patch to updatedatabase/marcschema.sql (to Bug 139 in bugs.koha.org). Before the 1.2 installer can be forward-ported or the 1.3 installer properly corrected, these two patches should at least allow the existing installer to function. The patch I posted to Bug 138 should resolve bugs 126, 129 (first part), 132, and 138 for the 1.3 intaller; some of these are WONTFIX, some of these are FIXED but only for 1.2, but I really need a working installer in order to test the other bugs I reported (e.g., Bug 135). Could someone double-check my two patches and commit them? (When I return to the office tomorrow I'll also apply the patches there.) Thanks!! -- Ambrose Li <a.c.li@ieee.org> http://ada.dhs.org/~acli/cmcc/ http://www.cccgt.org/ DRM is theft - We are the stakeholders
Ambrose Li a écrit:
Hello everyone,
I have just posted a patch to the 1.3.x installer.pl (to Bug 138 in bugs.koha.org), plus another patch to updatedatabase/marcschema.sql (to Bug 139 in bugs.koha.org). Before the 1.2 installer can be forward-ported or the 1.3 installer properly corrected, these two patches should at least allow the existing installer to function.
The patch I posted to Bug 138 should resolve bugs 126, 129 (first part), 132, and 138 for the 1.3 intaller; some of these are WONTFIX, some of these are FIXED but only for 1.2, but I really need a working installer in order to test the other bugs I reported (e.g., Bug 135).
Could someone double-check my two patches and commit them? (When I return to the office tomorrow I'll also apply the patches there.) Thanks!!
Could you see if your patch is still needed with installer merged from 1.2 ? see steve post, a few minuts ago) ? -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIBGB libre http://fr.koha.org)
Hi, On Mon, Dec 09, 2002 at 06:37:19PM +0100, paul POULAIN wrote:
Could you see if your patch is still needed with installer merged from 1.2 ? see steve post, a few minuts ago) ?
I don't see the merge happening. The installer.pl from the main branch seems to be still the old (buggy) installer.pl. Strange... -- Ambrose Li <a.c.li@ieee.org> http://ada.dhs.org/~acli/cmcc/ http://www.cccgt.org/ DRM is theft - We are the stakeholders
Ambrose Li a écrit:
Hi, On Mon, Dec 09, 2002 at 06:37:19PM +0100, paul POULAIN wrote:
Could you see if your patch is still needed with installer merged from 1.2 ? see steve post, a few minuts ago) ?
I don't see the merge happening. The installer.pl from the main branch seems to be still the old (buggy) installer.pl.
Strange...
yes, I asked steve to merge 1,2 installer into head, but he didn't made it at the moment. steve ? -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://fr.koha.org)
On Mon, Dec 09, 2002 at 06:37:19PM +0100, paul POULAIN wrote:
Could you see if your patch is still needed with installer merged from 1.2 ? see steve post, a few minuts ago) ?
Bug 126 is not applicable; we aren't asked about filling the MARC tables :-) Bug 129(1) is not applicable. Bug 132 seems to be still there, but the cause seems to be different and it could be an installation problem on my part (probably forgetting to run certain scripts after running installer.pl). I probably won't look at it till Wednesday. Bug 138 is still there. I doubt my patch would be usable in its current form. I guess I'll need to make a new patch. -- Ambrose Li <a.c.li@ieee.org> http://ada.dhs.org/~acli/cmcc/ http://www.cccgt.org/ DRM is theft - We are the stakeholders
Ambrose Li a écrit:
On Mon, Dec 09, 2002 at 06:37:19PM +0100, paul POULAIN wrote:
Could you see if your patch is still needed with installer merged from 1.2 ? see steve post, a few minuts ago) ?
Bug 126 is not applicable; we aren't asked about filling the MARC tables :-)
Bug 129(1) is not applicable.
Bug 132 seems to be still there, but the cause seems to be different and it could be an installation problem on my part (probably forgetting to run certain scripts after running installer.pl). I probably won't look at it till Wednesday.
Bug 138 is still there.
I doubt my patch would be usable in its current form. I guess I'll need to make a new patch.
I plan to release 1,3,3 on Friday. do you think you can do something in installer.pl today or tomorrow ? If you don't i'll do it. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://fr.koha.org)
On Tue, Dec 17, 2002 at 09:59:23AM +0100, paul POULAIN wrote:
I plan to release 1,3,3 on Friday. do you think you can do something in installer.pl today or tomorrow ? If you don't i'll do it.
Today (Tuesday) is unlikely. I guess I can do something on Wednesday. -- Ambrose Li <a.c.li@ieee.org> http://ada.dhs.org/~acli/cmcc/ http://www.cccgt.org/ DRM is theft - We are the stakeholders
Hi, I have worked on the installer for a few hours. I think this mostly works (see notes below). I have done several tests installs (clean installs) with this; it seems to be mostly ok. The Install.pm is derived from the 1.2.3RC23 version, but it is not the same. I've done some modifications; the 1.2.3RC23 Install.pm can't be used in place of this one. (If you want to check what's changed, you can diff this Install.pm against the one from 1.2.3RC23.) Now the problems: 1. Trying to install the sample data gives ERROR 1136 at line 2011: Column count doesn't match value count at row 1 I don't have any idea which SQL statement caused this error, or what impact this error has. 2. About the failures trying to go to ItemTypes or categories parameter setup, I found the following in my web server log: DBD::mysql::st execute failed: Unknown column 'flags' in 'field list' at /usr/local/koha/intranet/modules/C4/Auth.pm line 352. DBD::mysql::st fetchrow failed: fetch() without execute() at /usr/local/koha/intranet/modules/C4/Auth.pm line 353. So, it is a different bug (new bug) than Bug 132, probably due to a change in the database structure without a corresponding update to the updater scripts. The kohareporter script has disappeared from CVS. I have added a check in installer.pl to not ask the question unless the script is there. Except for the test installs and quick looks at the intranet interface after the installation, I haven't done a lot of testing with this. I believe this should cover bugs 126, 138, 146, 152, and 153. Got to sleep now :-) In article <20021217040738.Z6570@ada.dhs.org> you write:
On Tue, Dec 17, 2002 at 09:59:23AM +0100, paul POULAIN wrote:
I plan to release 1,3,3 on Friday. do you think you can do something in installer.pl today or tomorrow ? If you don't i'll do it.
Today (Tuesday) is unlikely. I guess I can do something on Wednesday.
participants (3)
-
Ambrose Li -
Ambrose Li -
paul POULAIN