It's here : http://sourceforge.net/project/shownotes.php?release_id=283928 Diff 2.2RC1 => 2.2RC2 ********************* * bugfix for import in reservoir : title and isbn where not extracted. * bugfix in OPAC : it was possible to reserve books that where "notforloan" * bugfix in circulation : no warning when a reserve was made on a book that you try to issue to someone else. * bugfix & improvement for catalogue management behaviour when MARC=OFF * bugfix in bookshelves (in CVS, probably not in official tar.gz) * bugfix in online help (in CVS, probably not in official tar.gz) updater should work between 2.2.0RC1 and 2.2.0RC2 (pls report any upgrade here to confirm) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
Paul POULAIN wrote:
It's here : http://sourceforge.net/project/shownotes.php?release_id=283928
Diff 2.2RC1 => 2.2RC2 ********************* * bugfix for import in reservoir : title and isbn where not extracted. * bugfix in OPAC : it was possible to reserve books that where "notforloan" * bugfix in circulation : no warning when a reserve was made on a book that you try to issue to someone else. * bugfix & improvement for catalogue management behaviour when MARC=OFF * bugfix in bookshelves (in CVS, probably not in official tar.gz) * bugfix in online help (in CVS, probably not in official tar.gz)
updater should work between 2.2.0RC1 and 2.2.0RC2 (pls report any upgrade here to confirm)
Hello: I have updated a 2.0.0 version with some issues: In the installfiles routine (sub neatcopy), it has produced an error. Can not copy directories. It has been solved adding a line that create the target directory after the rename of the old one system("mv ".$tgt." ".$tgt.strftime("%Y%m%d%H%M",localtime())); system("mkdir ".$tgt); ##New line There is other error in the updatedatabase script that i have been not able to printout. It says an error in the syntax of the generated sql. it seems to be on the auth_header table (the last comma) Regards Pablo Villanueva
During the instalation the installer fails to find the user that runs apache, it asks you for the user name. It should also ask for the group since later it asumes that the group and username are the same (in a chown -r). I think I've reported this previously, our test instation is SuSE 9.1 with apache 2.0.49 Andres
A few weeks ago we sent this patch for the members-flag.pl, made by Ernesto Silva (Universidad ORT - Uruguay). This patch wasn't applied to the 2.2.0 RC2, nor submited to the CVS. Please add it, could be very annoying for the users, specially for librarians. Andres
Andrés Tarallo a écrit :
A few weeks ago we sent this patch for the members-flag.pl, made by Ernesto Silva (Universidad ORT - Uruguay).
This patch wasn't applied to the 2.2.0 RC2, nor submited to the CVS. Please add it, could be very annoying for the users, specially for librarians.
thanks for submitting it again. I marked red the 1st message, but forgot it anyway. It's fixed in CVS -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
A while ago I've submited a patch for Opac-detail and Opac-isbdetaail. Ilve looked that Paul made changes in ISBDdetail that make my patch unnecesary. However this patch is still needed. Our librarians find that this small things are annoying (missing labels), and we want to have them in our side (not against koha). Andres
Andrés Tarallo a écrit :
A while ago I've submited a patch for Opac-detail and Opac-isbdetaail. Ilve looked that Paul made changes in ISBDdetail that make my patch unnecesary. However this patch is still needed. Our librarians find that this small things are annoying (missing labels), and we want to have them in our side (not against koha).
Andres
------------------------------------------------------------------------
--- opac-detail.pl.original 2004-11-22 10:44:45.961235720 -0300 +++ opac-detail.pl 2004-11-22 10:45:42.784597256 -0300 @@ -21,6 +21,8 @@
my $biblionumber=$query->param('bib'); $template->param(biblionumber => $biblionumber); +# 2004-11-22 A. Tarallo The Subject was missing. +$template->param(subject => "");
I don't understand what it does : it just hide (in opac-main.tmpl) the : <!-- TMPL_IF name="subject" --><b>Subject:</b><!-- /TMPL_IF --> So I think it's better to change this line into <!-- TMPL_IF name="subjects" --><b>Subject(s):</b><!-- /TMPL_IF --> to have "Subject(s): " before the subjects when there is at least one. Your opinion ? -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
When you display the detail of a biblio the word subject (in bold) doesnt appears, it just appears the subjects. However with my patch this word appears. Maybe someone with a deeper knowldge of html templates can give a more elegant solution, this one just works ;). Andres Paul POULAIN wrote:
[..]
------------------------------------------------------------------------
--- opac-detail.pl.original 2004-11-22 10:44:45.961235720 -0300 +++ opac-detail.pl 2004-11-22 10:45:42.784597256 -0300 @@ -21,6 +21,8 @@
my $biblionumber=$query->param('bib'); $template->param(biblionumber => $biblionumber); +# 2004-11-22 A. Tarallo The Subject was missing. +$template->param(subject => "");
I don't understand what it does : it just hide (in opac-main.tmpl) the : <!-- TMPL_IF name="subject" --><b>Subject:</b><!-- /TMPL_IF -->
So I think it's better to change this line into <!-- TMPL_IF name="subjects" --><b>Subject(s):</b><!-- /TMPL_IF --> to have "Subject(s): " before the subjects when there is at least one.
Your opinion ?
Andrés Tarallo a écrit :
When you display the detail of a biblio the word subject (in bold) doesnt appears, it just appears the subjects. However with my patch this word appears.
Maybe someone with a deeper knowldge of html templates can give a more elegant solution, this one just works ;).
That's what I thought : In this case, my patch is better : show "subject(s):" before subject(s) if there is at least one. If there is none, show nothing. so i commit mine (and thank you for the report even if the solution was not the best ;-) )
I don't understand what it does : it just hide (in opac-main.tmpl) the : <!-- TMPL_IF name="subject" --><b>Subject:</b><!-- /TMPL_IF -->
So I think it's better to change this line into <!-- TMPL_IF name="subjects" --><b>Subject(s):</b><!-- /TMPL_IF --> to have "Subject(s): " before the subjects when there is at least one.
Your opinion ?
-- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
Let me know when you have it commited into the CVS. I'm aware that many of my patches are not elegant or clean. While I work in the conversion of my database I'm improving my perl abilities and learning html template among other things. Andres Paul POULAIN wrote:
Andrés Tarallo a écrit :
When you display the detail of a biblio the word subject (in bold) doesnt appears, it just appears the subjects. However with my patch this word appears.
Maybe someone with a deeper knowldge of html templates can give a more elegant solution, this one just works ;).
That's what I thought : In this case, my patch is better : show "subject(s):" before subject(s) if there is at least one. If there is none, show nothing. so i commit mine (and thank you for the report even if the solution was not the best ;-) )
I don't understand what it does : it just hide (in opac-main.tmpl) the : <!-- TMPL_IF name="subject" --><b>Subject:</b><!-- /TMPL_IF -->
So I think it's better to change this line into <!-- TMPL_IF name="subjects" --><b>Subject(s):</b><!-- /TMPL_IF --> to have "Subject(s): " before the subjects when there is at least one.
As you might know Ernesto Silva and I have a been running Koha under mod_perl for a while. You get impressive porformance gains. Most of koha works without changes, however sometimes the conection to the database is lost. We have modified slightly the context.pm module to get rid of this problem. Our instalation is working, but there are some messages in the error_log of apache about a missing conection to the database, however our librarians don't complain anymore about beeing kicked away by koha. Andres
Andrés Tarallo a écrit :
As you might know Ernesto Silva and I have a been running Koha under mod_perl for a while. You get impressive porformance gains. Most of koha works without changes, however sometimes the conection to the database is lost.
We have modified slightly the context.pm module to get rid of this problem. Our instalation is working, but there are some messages in the error_log of apache about a missing conection to the database, however our librarians don't complain anymore about beeing kicked away by koha.
I'll apply & test this patch soon. What would be really great would be to explain also how to set up apache mod_perl for Koha (I must say I have absolutly no idea on how to do that...) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
I'll tray to write something; take into account that we are working with SuSE, that the distro makes things very easy to make them work, even when you dont have a deep knowledge of the service. Andres Paul POULAIN wrote:
Andrés Tarallo a écrit :
As you might know Ernesto Silva and I have a been running Koha under mod_perl for a while. You get impressive porformance gains. Most of koha works without changes, however sometimes the conection to the database is lost.
We have modified slightly the context.pm module to get rid of this problem. Our instalation is working, but there are some messages in the error_log of apache about a missing conection to the database, however our librarians don't complain anymore about beeing kicked away by koha.
I'll apply & test this patch soon. What would be really great would be to explain also how to set up apache mod_perl for Koha (I must say I have absolutly no idea on how to do that...)
We discovered yesterday that we've forgot to apply this patch. This bug was fixed and submited by ernesto silva a while ago, we're resubtting it again since it wasn't commited. Please test it under both modperl and traditional CGI. We think that the bug solved here might also appear under traditional cgi. Andres
El Martes, 23 de Noviembre de 2004 13:00, Andrés Tarallo escribió:
We discovered yesterday that we've forgot to apply this patch. This bug was fixed and submited by ernesto silva a while ago, we're resubtting it again since it wasn't commited.
Please test it under both modperl and traditional CGI. We think that the bug solved here might also appear under traditional cgi.
Andres
For this problem, i have used in my modified scripts the next lines: ---------------------------------------------------------------------------- if ($^O eq "MSWin32") { $ENV{'SCRIPT_FILENAME'}=~ m#(.*/)[^/]+$#; chdir($1); } ---------------------------------------------------------------------------- The problem, with windows, is that mod_perl uses the path of "Document and Settings" not the path from actual script, as Unix. These lines in C4::Context or before the opendir relative solve the problem using directly: opendir(DIR, "../value_builder") or another open's of any file in the same directory of scripts. This system use i for all project with perl + (unix or windows) apache systems, and include it in the init script. -- ################################################ #- Urbez Santana i Roma - #- Email: urbez@linuxupc.upc.es #- Private Web: http://linuxupc.upc.es/~urbez/ ################################################
Andrés Tarallo a écrit :
We discovered yesterday that we've forgot to apply this patch. This bug was fixed and submited by ernesto silva a while ago, we're resubtting it again since it wasn't commited.
I don't forget your patches. Just wanted to release RC3 before dealing with them. I'll do it this week or next (1st without activating mod_perl to check that it break nothing, then with mod_perl, to see perf improvements) Thanks again -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
Andrés Tarallo a écrit :
We discovered yesterday that we've forgot to apply this patch. This bug was fixed and submited by ernesto silva a while ago, we're resubtting it again since it wasn't commited.
------------------------------------------------------------------------
--- marc_subfields_structure.pl.original 2004-11-22 09:18:00.000000000 -0300 +++ marc_subfields_structure.pl 2004-11-23 08:47:31.519836872 -0300 @@ -132,7 +132,14 @@ } # build value_builder list my @value_builder=(''); - opendir(DIR, "../value_builder") || die "can't opendir ../value_builder: $!"; + +#-------------------------------------------------------------------------------------- +# Ernesto Silva, 04/11/2004 ---- Path fix for mod_perl. +# +#-------------------------------------------------------------------------------------- + my $cgidir = C4::Context->intranetdir . "/cgi-bin"; + opendir(DIR, "$cgidir/value_builder") || die "can't opendir $cgidir/value_builder: $!"; +#-------------------------------------------------------------------------------------- while (my $line = readdir(DIR)) { if ($line =~ /\.pl$/) { push (@value_builder,$line);
Hi andres, I applied this patch and have problem : C4::Context->intranetdir means nothing for my C4::Context, so I think you have forgotten something in your submission. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
Andrés Tarallo a écrit :
We discovered yesterday that we've forgot to apply this patch. This bug was fixed and submited by ernesto silva a while ago, we're resubtting it again since it wasn't commited.
Please test it under both modperl and traditional CGI. We think that the bug solved here might also appear under traditional cgi.
+ my $cgidir = C4::Context->intranetdir . "/cgi-bin";
ok, i understand the problem : the /cgi-bin is unknown in my CVS installation. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
participants (4)
-
Andrés Tarallo -
Cuenta General -
Paul POULAIN -
Urbez Santana Roma