Branch: new/awaiting_qa/biblibre_admin
I've tested this branch. It works. It improves admin module WUI. It add a jquery table sorter to various admin pages, framework editor, branches, item types, cities, authorized values, etc. There is just a small merge issue on link to sysprefs editor. This branch can be pulled here: The following changes since commit 8fe46f3dc1a3250b04a0da2f6dd9335710b4e702: Merge remote branch 'kc/new/bug_5143' into kcmaster (2010-12-20 13:24:40 +1300) are available in the git repository at: git://git.tamil.fr/git/koha qa_biblibre_admin Frédéric Demians (1): Merge branch 'master' into qa_biblibre_admin Henri-Damien LAURENT (3): Followup admin/categorie.pl MT4009: followup removing systempreferences branch transfer limits Matthias Meusburger (2): MT 2446 : Cancel authority edition for a field goes back to this field MT 2310 : New subfield for fields < 10 is now in a tab Paul POULAIN (1): mybranch not exported (merge pb) Paul Poulain (1): Removing usage of preferences.pl Stéphane Delaune (11): (MT #1577) complete langages checkbox for unique id (MT #1654) Adding jquery.tablesorter and jquery.tablesorter.pager support for authorised_values.pl (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for branches.pl (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for itemtypes.pl (MT #1654) followup : corrects tablesorting for authorised_values and itemtypes (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for categorie.pl (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for cities.pl (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for marctagstructure.pl (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for auth_tag_structure.pl (MT #1654) followup : corrects tablesorting for authorised_values.pl (MT #1654) followup : Adding jquery.tablesorter and jquery.tablesorter.pager support for branch_transfer_limits.pl C4/Branch.pm | 1 + admin/auth_tag_structure.pl | 11 +- admin/branch_transfer_limits.pl | 10 +- admin/categorie.pl | 2 +- admin/marctagstructure.pl | 6 +- .../prog/en/includes/prefs-admin-search.inc | 2 +- .../lib/jquery/plugins/jquery.tablesorter.pager.js | 184 ++++++++++++++++++++ .../prog/en/modules/admin/admin-home.tmpl | 2 +- .../en/modules/admin/auth_subfields_structure.tmpl | 3 +- .../prog/en/modules/admin/auth_tag_structure.tmpl | 38 +++- .../prog/en/modules/admin/authorised_values.tmpl | 50 ++++-- .../en/modules/admin/branch_transfer_limits.tmpl | 27 +++ .../prog/en/modules/admin/branches.tmpl | 22 ++- .../prog/en/modules/admin/categorie.tmpl | 33 +++- .../prog/en/modules/admin/cities.tmpl | 33 ++++- .../prog/en/modules/admin/itemtypes.tmpl | 37 ++++- .../en/modules/admin/marc_subfields_structure.tmpl | 2 - .../prog/en/modules/admin/marctagstructure.tmpl | 39 +++- .../prog/en/modules/admin/systempreferences.tmpl | 4 +- koha-tmpl/intranet-tmpl/prog/img/first.png | Bin 0 -> 720 bytes koha-tmpl/intranet-tmpl/prog/img/last.png | Bin 0 -> 737 bytes koha-tmpl/intranet-tmpl/prog/img/next.png | Bin 0 -> 736 bytes koha-tmpl/intranet-tmpl/prog/img/prev.png | Bin 0 -> 745 bytes 23 files changed, 442 insertions(+), 64 deletions(-) create mode 100644 koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery.tablesorter.pager.js create mode 100644 koha-tmpl/intranet-tmpl/prog/img/first.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/last.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/next.png create mode 100644 koha-tmpl/intranet-tmpl/prog/img/prev.png
I'm curious about this:
Paul Poulain (1): Removing usage of preferences.pl
The relevant change: - <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li> What is the purpose of doing so? -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
On 21 December 2010 09:47, Owen Leonard <oleonard@myacpl.org> wrote:
I'm curious about this:
Paul Poulain (1): Removing usage of preferences.pl
The relevant change:
- <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li>
What is the purpose of doing so?
Nice catch owen, going back to the old systempreferences.pl breaks the translation of system preferences. And the nice interface. There would have to be a pretty compelling reason for ditching that, and it would need to include away to still have translated tempaltes. Chris
On 21 December 2010 14:07, Chris Cormack <chris@bigballofwax.co.nz> wrote:
On 21 December 2010 09:47, Owen Leonard <oleonard@myacpl.org> wrote:
I'm curious about this:
Paul Poulain (1): Removing usage of preferences.pl
The relevant change:
- <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li>
What is the purpose of doing so?
Nice catch owen, going back to the old systempreferences.pl breaks the translation of system preferences. And the nice interface. There would have to be a pretty compelling reason for ditching that, and it would need to include away to still have translated tempaltes.
And by tempaltes (sic) I actually meant system preferences :) Chris
Le 21/12/2010 02:08, Chris Cormack a écrit :
On 21 December 2010 14:07, Chris Cormack <chris@bigballofwax.co.nz> wrote:
On 21 December 2010 09:47, Owen Leonard <oleonard@myacpl.org> wrote:
I'm curious about this:
Paul Poulain (1): Removing usage of preferences.pl
The relevant change:
- <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li>
What is the purpose of doing so?
Nice catch owen, going back to the old systempreferences.pl breaks the translation of system preferences. And the nice interface. There would have to be a pretty compelling reason for ditching that, and it would need to include away to still have translated tempaltes.
And by tempaltes (sic) I actually meant system preferences :) Hi
By the time we had to deploy things we had many problems with that new systempreferences, we told on list months ago. This is why we chose to stick to the old system. It would have disturbing for libraries in production to change system preference very short after going live. We know it has been fixed since, but the fact is that This edit should not have been sent in though. And thanks to Frederic to have caught that. -- Henri-Damien LAURENT
* LAURENT Henri-Damien (henridamien.laurent@gmail.com) wrote:
Hi
By the time we had to deploy things we had many problems with that new systempreferences, we told on list months ago. This is why we chose to stick to the old system. It would have disturbing for libraries in production to change system preference very short after going live.
We know it has been fixed since, but the fact is that This edit should not have been sent in though. And thanks to Frederic to have caught that.
I have pulled the branch from Frederic's repository and rebased them onto master, fixed the remaining link to systempreferences.pl, created a bug (so I dont break my own rules) and have pushed them up as new/enh/bug_5530 Please do some quick testing and let me know if its safe to merge. Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
2010/12/21 Chris Cormack <chrisc@catalyst.net.nz>:
* LAURENT Henri-Damien (henridamien.laurent@gmail.com) wrote:
Hi
By the time we had to deploy things we had many problems with that new systempreferences, we told on list months ago. This is why we chose to stick to the old system. It would have disturbing for libraries in production to change system preference very short after going live.
We know it has been fixed since, but the fact is that This edit should not have been sent in though. And thanks to Frederic to have caught that.
I have pulled the branch from Frederic's repository and rebased them onto master, fixed the remaining link to systempreferences.pl, created a bug (so I dont break my own rules) and have pushed them up as new/enh/bug_5530
Please do some quick testing and let me know if its safe to merge.
Right, this branch is now merged to master, please test and marked bug 5530 resolved if its all good Chris
The relevant change:
- <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li>
What is the purpose of doing so?
That's what I was talking about 'syspref editor merge issue'. When merging this branch to HEAD you have to revert to using the new syspref editor. That's done on my branch. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html
* Frédéric DEMIANS (f.demians@tamil.fr) wrote:
The relevant change:
- <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li>
What is the purpose of doing so?
That's what I was talking about 'syspref editor merge issue'. When merging this branch to HEAD you have to revert to using the new syspref editor. That's done on my branch.
Ah ha, now it becomes more clear. Ill do some testing now, and merge it in if it seems ok. Chris
-- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
The relevant change:
- <li><a href="/cgi-bin/koha/admin/preferences.pl">System preferences</a></li> + <li><a href="/cgi-bin/koha/admin/systempreferences.pl">System preferences</a></li>
What is the purpose of doing so?
That's what I was talking about 'syspref editor merge issue'. When merging this branch to HEAD you have to revert to using the new syspref editor. That's done on my branch. -- Frédéric DEMIANS http://www.tamil.fr/u/fdemians.html
participants (6)
-
Chris Cormack -
Chris Cormack -
Frédéric DEMIANS -
Frédéric Demians -
LAURENT Henri-Damien -
Owen Leonard