Hi Jonathan, I am not sure about the current behavior - I know we have a lot of checks on checkout, but what would prevent a checkin? Items lost or withdrawn are the only things that I can think of right now. If withdrawn the item should not be checked out anymore. If lost, the expected behaviour might depend on system settings? Katrin On 11.12.19 11:04, Jonathan Druart wrote:

Hi devs,

Two similar reports about the KOCT plugin: * Bug 21494 - No checkin notice created for offline circulation checkins * Bug 15751 - Koha offline circulation Firefox addon does not update last seen date for check-ins

When a checkin is done, MarkIssueReturned will be called (not AddReturn) which has some side-effects, like what is described in those 2 bug reports.

But, using AddReturn will change behaviors, which may be unexpected. For instance, do we want the checkin to be forced, without doing the usual checks (current behavior), or we want it to be blocked?

There is a lot of things that is not done when an item is checked in via KOCT, no idea what we expect or not.

Any ideas?

Cheers, Jonathan

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21494 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/