Test suite in t/db_dependent/lib/KohaTest
Hi, My question about the files in the mentioned folder is: Is anyone using these test units at all? Could we delete them? Note that Jenkins appears not to run t/db_dependent/database_dependent.pl but only the *.t files. The script database_dependent.pl only refers to lib/KohaTest.pm and all unit tests in lib/KohaTest. commit 80568463eac45ede97268c02ee7d59028cb3ff9b introduced t/database_dependent.pl (2008) commit eff21765f9784e09905042dd7080cbef099306d9 moved it to t/db_dependent/ Note also that it needs two additional cpan modules: Test::Class and Test::Class::Load Currently, we are often updating files in this directory. We are finding them with grep etc. and we update them. But if no one is using them, we could better remove them and have less maintenance issues. Before opening a report with a "large delete" patch, just asking around here. Please respond if you know that they are in use! Thanks, Marcel
Hi Marcel, This question was in my todo list, thanks to ask :) I have the same impression, these UT files are never used, but it is possible I missed something. Regards, Jonathan 2013/7/3 Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>:
Hi,
My question about the files in the mentioned folder is: Is anyone using these test units at all? Could we delete them?
Note that Jenkins appears not to run t/db_dependent/database_dependent.pl but only the *.t files.
The script database_dependent.pl only refers to lib/KohaTest.pm and all unit tests in lib/KohaTest.
commit 80568463eac45ede97268c02ee7d59028cb3ff9b introduced t/database_dependent.pl (2008) commit eff21765f9784e09905042dd7080cbef099306d9 moved it to t/db_dependent/
Note also that it needs two additional cpan modules: Test::Class and Test::Class::Load
Currently, we are often updating files in this directory. We are finding them with grep etc. and we update them. But if no one is using them, we could better remove them and have less maintenance issues.
Before opening a report with a "large delete" patch, just asking around here. Please respond if you know that they are in use!
Thanks,
Marcel
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi, On Wed, Jul 3, 2013 at 9:53 AM, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>wrote:
Currently, we are often updating files in this directory. We are finding them with grep etc. and we update them. But if no one is using them, we could better remove them and have less maintenance issues.
Before opening a report with a "large delete" patch, just asking around here. Please respond if you know that they are in use!
To my knowledge, this set of test scripts is not being actively used. Consequently, I have no objection to a patch that removes them, but it would be a niceness to look over the individual tests and see which ones can be easily ported to the current DB-dependent test framework. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Thanks for your responses, Chris, Galen and Jonathan. I opened up two reports: 10539 now removes unused files from the codebase. I will use 10540 to report unit tests to inject back into the currently used test suite. Anyone is invited to join in that effort. (This will take some time, I guess.) Marcel Van: Galen Charlton [mailto:gmc@esilibrary.com] Verzonden: donderdag 4 juli 2013 3:05 Aan: Marcel de Rooy CC: koha-devel@lists.koha-community.org Devel Onderwerp: Re: [Koha-devel] Test suite in t/db_dependent/lib/KohaTest Hi, On Wed, Jul 3, 2013 at 9:53 AM, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl<mailto:M.de.Rooy@rijksmuseum.nl>> wrote: Currently, we are often updating files in this directory. We are finding them with grep etc. and we update them. But if no one is using them, we could better remove them and have less maintenance issues. Before opening a report with a "large delete" patch, just asking around here. Please respond if you know that they are in use! To my knowledge, this set of test scripts is not being actively used. Consequently, I have no objection to a patch that removes them, but it would be a niceness to look over the individual tests and see which ones can be easily ported to the current DB-dependent test framework. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com<mailto:gmc@esilibrary.com> direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
participants (4)
-
Chris Cormack -
Galen Charlton -
Jonathan Druart -
Marcel de Rooy