I am new to git and its brain twisting operation. Nonetheless the Koha version control system is starting to work with me. The gazillions of warning messages that its spews out about trailing white space produce so much useless noise that I cannot see the real warnings or error message without considerable effort. This warning message provides no useful information. I propose we disable it. ------------------------ I you disagree then please provide an example of a source code file, language processor or other instance where trailing white space actaully can cause trouble. I'm at a loss to find such. cheers rickw -- _________________________________ Rick Welykochy || Praxis Services Finster's Law: A closed mouth gathers no feet.
On Fri, Dec 5, 2008 at 10:25 AM, Rick Welykochy <rick@praxis.com.au> wrote:
I am new to git and its brain twisting operation. Nonetheless the Koha version control system is starting to work with me.
The gazillions of warning messages that its spews out about trailing white space produce so much useless noise that I cannot see the real warnings or error message without considerable effort.
This warning message provides no useful information.
I propose we disable it. ------------------------
I you disagree then please provide an example of a source code file, language processor or other instance where trailing white space actaully can cause trouble. I'm at a loss to find such.
Why don't you just disable it for you? It's probably an option you can set with git-config. Thats the beauty with git being a distributed versioning system, don't like whitespace warnings, turn them off for you. And everyone else can just keep doing whatever they want. Chris
Andrew Moore wrote:
On Thu, Dec 4, 2008 at 3:25 PM, Rick Welykochy <rick@praxis.com.au> wrote:
I propose we disable it.
I think:
"git-config core.whitespace=nowarn"
will do that for you.
if not, something really similar will.
hope it helps.
Thanks ... will look into disabling it for me. Why not just disable it in git? Period. Otherwise each person that joins development will go through the same useless and time wasting process of dealing with these messages. Once again: people efficiency. cheers rick -- _________________________________ Rick Welykochy || Praxis Services Finster's Law: A closed mouth gathers no feet.
On Fri, Dec 5, 2008 at 10:51 AM, Rick Welykochy <rick@praxis.com.au> wrote:
Andrew Moore wrote:
On Thu, Dec 4, 2008 at 3:25 PM, Rick Welykochy <rick@praxis.com.au> wrote:
I propose we disable it.
I think:
"git-config core.whitespace=nowarn"
will do that for you.
if not, something really similar will.
hope it helps.
Thanks ... will look into disabling it for me.
Why not just disable it in git? Period.
Otherwise each person that joins development will go through the same useless and time wasting process of dealing with these messages.
Once again: people efficiency.
Because I like the whitespace warnings, and try to fix them. Just like perl, with git there is more than one way to do things. Whitespace can cause mess and unnesecary merges. Just because you don't like the warnings doesn't mean that others also don't. Chris
On 2008/12/5, at 10:55 AM, Chris Cormack wrote:
On Fri, Dec 5, 2008 at 10:51 AM, Rick Welykochy <rick@praxis.com.au> wrote:
Andrew Moore wrote:
On Thu, Dec 4, 2008 at 3:25 PM, Rick Welykochy <rick@praxis.com.au> wrote:
I propose we disable it.
I think:
"git-config core.whitespace=nowarn"
will do that for you.
if not, something really similar will.
hope it helps.
Thanks ... will look into disabling it for me.
Why not just disable it in git? Period.
do waht you want d00d , its *your* repo
white-space causes trouble for git's diffing (and all RCS too?) thats why its on by default, i guess... i turn it off personally, and manage my own white-space tidying others can do what they want... hth On 2008/12/5, at 10:25 AM, Rick Welykochy wrote:
I am new to git and its brain twisting operation. Nonetheless the Koha version control system is starting to work with me.
The gazillions of warning messages that its spews out about trailing white space produce so much useless noise that I cannot see the real warnings or error message without considerable effort.
This warning message provides no useful information.
I propose we disable it. ------------------------
I you disagree then please provide an example of a source code file, language processor or other instance where trailing white space actaully can cause trouble. I'm at a loss to find such.
cheers rickw
-- _________________________________ Rick Welykochy || Praxis Services
Finster's Law: A closed mouth gathers no feet. _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
Rick Welykochy wrote:
I am new to git and its brain twisting operation. Nonetheless the Koha version control system is starting to work with me.
The gazillions of warning messages that its spews out about trailing white space produce so much useless noise that I cannot see the real warnings or error message without considerable effort.
This warning message provides no useful information.
Incorrect: it is pointing out lots of landmines waiting to blow your personal life to shreds.
I propose we disable it. ------------------------
NO NO NO NO NO!
I you disagree then please provide an example of a source code file, language processor or other instance where trailing white space actaully can cause trouble. I'm at a loss to find such.
The problem is that whitespace causes totally unnecessary merge conflicts. The result is you (or worse, an upstream maintainer) wastes valuable time picking through merge conflicts that should not have happened. Bugs are inevitably introduced when a merge conflict is resolved incorrectly. Your time could otherwise be spent doing fun and useful things - hence my assertion that the whitespace damage *will* harm your personal life. It is unfortunate that the current code base has whitespace damage. The correct solution is to coordinate a whitespace undamage day, run a script to remove the whitespace damage from the master repo, and have everybody resync with the master repo. This will be painful, but it is painful only once. Leaving whitespace damage in the source will be a never ending source of pain (death by 1,000 paper cuts). I've been there and made the wrong decision to not fix the whitespace damage. For the remainder of the project I sorely regretted not "tearing the band-aid(r) off" once.
cheers rickw
Best regards, gvb
Jerry Van Baren wrote:
Rick Welykochy wrote:
I you disagree then please provide an example of a source code file, language processor or other instance where trailing white space actaully can cause trouble. I'm at a loss to find such.
The problem is that whitespace causes totally unnecessary merge conflicts. The result is you (or worse, an upstream maintainer) wastes valuable time picking through merge conflicts that should not have happened. Bugs are inevitably introduced when a merge conflict is resolved incorrectly.
Thanks for the wisdom of experience. I've never experienced white space hell using CVS. Perhaps it is more of a problem in git. The only way I got around this on my first commit + patch cycle was to fix the problem. I've decided to leave the warning on and fix as I go. It only takes a few seconds to search for and replace trailing whitespace or whitespace lines. How did they get there in the first place? <mouth wide shut/>
This will be painful, but it is painful only once. Leaving whitespace damage in the source will be a never ending source of pain (death by 1,000 paper cuts).
Peculiar to git, perhaps? cheers rickw -- _________________________________ Rick Welykochy || Praxis Services Finster's Law: A closed mouth gathers no feet.
Rick Welykochy wrote:
Jerry Van Baren wrote:
Rick Welykochy wrote:
I you disagree then please provide an example of a source code file, language processor or other instance where trailing white space actaully can cause trouble. I'm at a loss to find such. The problem is that whitespace causes totally unnecessary merge conflicts. The result is you (or worse, an upstream maintainer) wastes valuable time picking through merge conflicts that should not have happened. Bugs are inevitably introduced when a merge conflict is resolved incorrectly.
Thanks for the wisdom of experience. I've never experienced white space hell using CVS. Perhaps it is more of a problem in git.
Maybe. I suspect is is more how CVS is used and its limitations than git per se. Possibly CVS ignored the whitespace issue. CVS doesn't do branching and merging well. <http://www.youtube.com/watch?v=4XpnKHJAok8> Git excels at branching and merging. The whitespace issue is critical when merging is critical: in a distributed repository, merging is what makes it work - merging is beyond critical, it is the enabler technology.
The only way I got around this on my first commit + patch cycle was to fix the problem.
I've decided to leave the warning on and fix as I go. It only takes a few seconds to search for and replace trailing whitespace or whitespace lines. How did they get there in the first place? <mouth wide shut/>
In WindowsWorld, I've found UltraEdit adds whitespace damage. Visual SlickEdit shotguns a truly appalling amount of whitespace crap every time you blink. Your whitespace is likely added by the editor that you use. The other possibility is that it is in the master repository (which I was thinking when I sent the last message... easy enough to check, but I have not had time to check). The good news is you typically can configure editors to strip trailing whitespace when you save the file. The bad news is UltraEdit and SlickEdit come with that turned off (WHY??? It seems pretty stupid to add lots of arbitrary trailing whitespace to a file regardless of repository issues). The worse news is that in SlickEdit it is hard to find where the control is (sorry, I'm not at work so I cannot look where it is).
This will be painful, but it is painful only once. Leaving whitespace damage in the source will be a never ending source of pain (death by 1,000 paper cuts).
Peculiar to git, perhaps?
Peculiar to merging... which is the core requirement of distributed repositories. FWIIW, my painful experience was with Mercurial, not git, but it is the same issue: merging. BTW, beyond the merge problem (which is significant), IMHO whitespace damage is a "broken window" issue. If you make sure the little stuff is clean, it sets a level of expectation and everything will be clean(er). <http://en.wikipedia.org/wiki/Fixing_Broken_Windows>
cheers rickw
HTH, gvb
participants (6)
-
Andrew Moore -
Chris Cormack -
Jerry Van Baren -
Jerry Van Baren -
Mason James -
Rick Welykochy