Maybe the script should not process this check if codespell is not installed. Patch welcomed ;-) It's in test for the moment, we will see if the number of false positive is high or not. Why do you worry about them? On 25 Jun 2015 09:06, "Marcel de Rooy" <M.de.Rooy@rijksmuseum.nl> wrote:

There is no package for codespell on Wheezy. But I would like to keep using the qa script :)

I am not sure if we should check spelling in QA and/or spend time on false negatives too..

-----Oorspronkelijk bericht----- Van: koha-devel-bounces@lists.koha-community.org [mailto: koha-devel-bounces@lists.koha-community.org] Namens Jonathan Druart Verzonden: donderdag 18 juni 2015 16:34 Aan: koha-devel@lists.koha-community.org Onderwerp: [Koha-devel] QA script - New check for spelling

Hi devs,

QAing bug 14383, I have just added a new check in the QA script to check the spelling in the code comments. Let me know if you find any issues. You will have to install codespell (apt-get install codespell).

Cheers, Jonathan _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/

See man codespell: --dictionary=FILE Custom dictionary file that contains spelling corrections. If this flag is not specified then default dictionary "/usr/share/codespell/dictionary.txt" is used. So it's possible to provide a customi(s|z)ed file for our need. Note that grep -P "colou?r" /usr/share/codespell/dictionary.txt does not return anything. But grep -P "i(s|z)ed" /usr/share/codespell/dictionary.txt does. Some stuffs like: speciallized->specialised, specialized, 2015-06-25 13:06 GMT+01:00 Mark Tompsett <mtompset@hotmail.com>:

Greetings,

Jonathan Druart<jonathan.druart@biblibre.com> wrote:

...

It's in test for the moment, we will see if the number of false positive is high or not. Why do you worry about them?

I’m sure Mr. Colorful Colour will help explain why color and other words like it might be an issue, neighbour. :)

Your friendly neighborhood Canadian, Mark Tompsett _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/

Greetings, Marcel de Rooy wrote:

We should spend our QA time on the code not the spelling of comments.

I don’t know about you, but how often do you comment your code? Next, perldoc’ing is already validated. Spelling is only a minor step past that. Not that I support the spelling check, but I do think a patch would be good. :) GPML, Mark Tompsett

Done. Now the script warn instead of die and mark the test "spelling" as skipped.

Great. Thanks.