Quoting table column names (was Re: [Koha-patches] [PATCH] bug_5786: moved AllowOnShelfHolds to circ matrix (issuingrules))
On Wed, Dec 21, 2011 at 9:22 AM, Marc Balmer <marc@msys.ch> wrote:
Please stop putting column names in backquotes, it is a MySQLism and hinders my efforts to run Koha on PostgreSQL,
I thought this was an issue that should be raised on the devel list. Is this something for which a best practice has already been established? -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
Am 22.12.11 00:32, schrieb Owen Leonard:
On Wed, Dec 21, 2011 at 9:22 AM, Marc Balmer <marc@msys.ch> wrote:
Please stop putting column names in backquotes, it is a MySQLism and hinders my efforts to run Koha on PostgreSQL,
I thought this was an issue that should be raised on the devel list.
Good idea.
Is this something for which a best practice has already been established?
I think common sense should be enough ;) There is just no point in using MySQL-only idioms when with little or no effort the code can run onPostgreSQL as well. So it is not understandable why someone would write insert into `atable` (a) values (42) which chokes on PostgreSQL (and maybe isn't even proper SQL), when insert into atable (a) values (42) runs on both MySQL and PostgreSQL. There is already some minimal PostgreSQL support in Koha and I am actively working on a branch that should bring full PostgreSQL support eventually. It would help these efforts (and I am sure I am not the only one wanting to run on PostgreSQL) if MySQLisms would be kept at a minimum. - mb
participants (2)
-
Marc Balmer -
Owen Leonard