Limits cannot contain parentheses
Hi all, I noticed that the CCL2RPN parser throws fatal errors when limits have parentheses in them. I have a fix for it (described at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22344), but it makes for an escaped $limit_cgi and an ugly $limit_desc. It doesn't break anything, but it's not aesthetically pleasing. Would people prefer an ugly fix that is easy to implement, or a more beautiful but difficult to implement fix? David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595
Thanks for working on that David. We use zebra on xenial so actually 2.1.4 and it does not even support signle quotes in limits. I could not say how to fix ugly or beautiful ;) Le 15/02/2019 à 03:12, David Cook a écrit :
Hi all,
I noticed that the CCL2RPN parser throws fatal errors when limits have parentheses in them. I have a fix for it (described at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22344), but it makes for an escaped $limit_cgi and an ugly $limit_desc. It doesn't break anything, but it's not aesthetically pleasing.
Would people prefer an ugly fix that is easy to implement, or a more beautiful but difficult to implement fix?
David Cook
Systems Librarian
Prosentient Systems
72/330 Wattle St
Ultimo, NSW 2007
Australia
Office: 02 9212 0899
Direct: 02 8005 0595
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre, France - software and system maintainer
participants (2)
-
David Cook -
Fridolin SOMERS