About bug 5634 - Ordering branches should be case independent
Hi, I've been studying the code to hopefully find (and eventually fix) all occurrences of code to display an ordered list of branches, to close Bug 5634 [1] There is a zoo of different versions, so I have some questions: 1) It's desirable to change the code to use GetBranchesLoop() whenever possible, or only fix the sort order in place? 2) Some solutions use CGI::scrolling_list() to draw the drop down list. This simplifies the template, but is more code in the script. Which version do you think is better? Regards, Bernardo [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634 -- Bernardo Gonzalez Kriegel bgkriegel@gmail.com
Hi, On Tue, Jan 8, 2013 at 2:29 PM, Bernardo Gonzalez Kriegel < bgkriegel@gmail.com> wrote:
2) Some solutions use CGI::scrolling_list() to draw the drop down list. This simplifies the template, but is more code in the script. Which version do you think is better?
CGI::scrolling_list() has been deprecated for a long time (see bug 766 [1]), so it shouldn't be part of any solution for bug 5634. [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> wrote:
Hi, I've been studying the code to hopefully find (and eventually fix) all occurrences of code to display an ordered list of branches, to close Bug 5634 [1]
There is a zoo of different versions, so I have some questions:
1) It's desirable to change the code to use GetBranchesLoop() whenever possible, or only fix the sort order in place?
2) Some solutions use CGI::scrolling_list() to draw the drop down list. This simplifies the template, but is more code in the script. Which version do you think is better?
CGI::scrolling_list should be removed wherever it is found, it renders the contents untranslatable. Chris
Regards, Bernardo
[1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634
I did a search for scrolling_list on current master and found 79 hits in 34 files: acqui\fetch_sort_dropbox.pl admin\aqplan.pl admin\authorised_values.pl admin\auth_subfields_structure.pl admin\auth_tag_structure.pl admin\koha2marclinks.pl admin\marctagstructure.pl admin\marc_subfields_structure.pl authorities\authorities.pl C4\Input.pm C4\Items.pm C4\Reports.pm catalogue\labeledMARCdetail.pl cataloguing\addbiblio.pl cataloguing\additem.pl cataloguing\value_builder\marc21_linking_section.pl cataloguing\value_builder\unimarc_field_225a.pl cataloguing\value_builder\unimarc_field_4XX.pl circ\circulation.pl members\memberentry.pl reports\acquisitions_stats.pl reports\borrowers_out.pl reports\borrowers_stats.pl reports\catalogue_stats.pl reports\cat_issues_top.pl reports\guided_reports.pl reports\issues_avg_stats.pl reports\issues_by_borrower_category.plugin reports\issues_stats.pl reports\itemtypes.plugin reports\reserves_stats.pl reports\serials_stats.pl reserve\request.pl tools\batchMod.pl Marc Am 09.01.2013 00:30, schrieb Chris Cormack:
Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> wrote:
Hi, I've been studying the code to hopefully find (and eventually fix) all occurrences of code to display an ordered list of branches, to close Bug 5634 [1]
There is a zoo of different versions, so I have some questions:
1) It's desirable to change the code to use GetBranchesLoop() whenever possible, or only fix the sort order in place?
2) Some solutions use CGI::scrolling_list() to draw the drop down list. This simplifies the template, but is more code in the script. Which version do you think is better?
CGI::scrolling_list should be removed wherever it is found, it renders the contents untranslatable.
Chris
Regards, Bernardo
[1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5634
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (4)
-
Bernardo Gonzalez Kriegel -
Chris Cormack -
Galen Charlton -
Marc Véron