Fwd: Re: Bug Numbers in Update Database
Can we start putting our bug references in our updates?
+1 This rule should be written down somewhere in the Wiki. But where? Marc
Greetings, nengard:
Can we start putting our bug references in our updates?
We should have already. So +1 for bringing it up. mveron:
This rule should be written down somewhere in the Wiki. But where?
It took some hunting, but I think it is already written down: http://wiki.koha-community.org/wiki/Guidelines_for_Patch_Acceptance/Rejectio... "9. The patch must refer to a bug number" And if you follow the bug number link: http://wiki.koha-community.org/wiki/Coding_Guidelines#Bug_numbers "... include Bug + the bug number at the beginning of your commit message ..." Though, these both could be clarified to expressly say in the first line of the commit message. I must have read this at some point in time, because I have been doing this. I just didn't remember why. GPML, Mark Tompsett
Mark, Can we start putting our bug references in our updates?
[to the mailing list at large] I have no objection.
mveron:
This rule should be written down somewhere in the Wiki.
But where?
It took some hunting, but I think it is already written down: http://wiki.koha-community.**org/wiki/Guidelines_for_Patch_** Acceptance/Rejection<http://wiki.koha-community.org/wiki/Guidelines_for_Patch_Acceptance/Rejection> "9. The patch must refer to a bug number"
And if you follow the bug number link: http://wiki.koha-community.**org/wiki/Coding_Guidelines#**Bug_numbers<http://wiki.koha-community.org/wiki/Coding_Guidelines#Bug_numbers> "... include Bug + the bug number at the beginning of your commit message ..."
I think Coding Guidelines is the right place to put it, but Nicole is asking about the messages in updatedatabase not commit messages.
Though, these both could be clarified to expressly say in the first line of the commit message. I must have read this at some point in time, because I have been doing this. I just didn't remember why.
I suspect you're doing it because I failed your first patch for not having the bug number in the first line of the commit message. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
Jared Camins-Esakov schreef op ma 24-09-2012 om 19:08 [-0400]:
I suspect you're doing it because I failed your first patch for not having the bug number in the first line of the commit message.
Also, if you have something like "Bug 1234" as the first line, then git bz is able to be magical. http://wiki.koha-community.org/wiki/Git_bz_configuration If you aren't using this, you should. -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5957 6D23 8B16 EFAB FEF8 7175 14D3 6485 A99C EB6D
participants (4)
-
Jared Camins-Esakov -
Marc Véron -
Mark Tompsett -
Robin Sheat