File organisation within release tarball
Dear all, Have some questions on naming of the release tarball, and organisation of files within it. I am not sure if this has been discussed before; at least, have not come across a discussion in the archives. 1. A really math question. Why does a file named koha-3.04.02.tar.gz extract to "koha-3.4.02"?? Did I get my math wrong? On a related note, when I run koha_perl_deps.pl, I am told that Graphics::Magick is only 1.3.12, while the required version is 1.3.5. This is with 3.4.2. 2. Am I the only one to feel that files are really scattered within the source directory (the one we get when we extract the tarball)?? 2.1 For a start, why not move al those INSTALL* files into a INSTALL directory within the source directory? 2.2 In the installed directory (the default location - /usr/share/koha), rebuild_zebra.pl is not really a migration tool. At least, it currently is not. Time to move rebuild_zebra.pl to bin/cronjobs?
From what I have read about it, bin/maintenance/remove_items_from_biblioitems.pl is a migration tool. Or have I understood it wrongly? (INSTALL wrongly mentions its location as misc/maintenance/. The correct location ought to be bin/maintenance/ .
-- Mahesh T. Pai ||
On 21 Jul 2011 19:39, "Mahesh T Pai" <paivakil@gmail.com> wrote:
Dear all,
Have some questions on naming of the release tarball, and organisation of files within it.
I am not sure if this has been discussed before; at least, have not come across a discussion in the archives.
1. A really math question.
Why does a file named koha-3.04.02.tar.gz extract to "koha-3.4.02"??
Did I get my math wrong?
What do you think it should extract to? It is not a number ie they aren't decimal points. 3.04.02 is 3.4.2, 3.11.04 would be 3.11.4, 3.04.11 3.4.11 etc.
On a related note, when I run koha_perl_deps.pl, I am told that Graphics::Magick is only 1.3.12, while the required version is 1.3.5. This is with 3.4.2.
Again they aren't base 10 decimal numbers 1.3.5 is less than 1.3.12 Just like perl 5.10 is greater than 5.8.4
2. Am I the only one to feel that files are really scattered within the source directory (the one we get when we extract the tarball)??
2.1 For a start, why not move al those INSTALL* files into a INSTALL directory within the source directory?
Send a patch :)
2.2 In the installed directory (the default location - /usr/share/koha),
rebuild_zebra.pl is not really a migration tool. At least, it currently is not. Time to move rebuild_zebra.pl to bin/cronjobs?
From what I have read about it, bin/maintenance/remove_items_from_biblioitems.pl is a migration tool. Or have I understood it wrongly? (INSTALL wrongly mentions its location as misc/maintenance/. The correct location ought to be bin/maintenance/ .
And again, patches welcome as long as they update all the documentation too Chris
-- Mahesh T. Pai ||
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Chris Cormack schreef op do 21-07-2011 om 19:47 [+1200]:
On a related note, when I run koha_perl_deps.pl, I am told that Graphics::Magick is only 1.3.12, while the required version is 1.3.5. This is with 3.4.2.
Again they aren't base 10 decimal numbers 1.3.5 is less than 1.3.12
However, in this case, as 1.3.12 > 1.3.5 and the latter is the minimum required, this is indeed an error I think. Robin.
Chris Cormack <chris@bigballofwax.co.nz>
On 21 Jul 2011 19:39, "Mahesh T Pai" <paivakil@gmail.com> wrote:
2.1 For a start, why not move al those INSTALL* files into a INSTALL directory within the source directory?
Send a patch :)
Please don't hide the instructions. We already have enough problems from people following random web pages instead of the INSTALL* files. I feel they should remain in the top directory. Lots of other stuff might make sense to move around, but INSTALL*, README, COPYING*, NEWS and Changelog should remain on the top, as in the GNU Coding Standards for releases: http://www.gnu.org/prep/standards/html_node/Releases.html#Releases Tidying up cronjobs like rebuild_zebra for 3.6 seems like a good idea, especially if the new zebraqueue daemon isn't ready. Hope that helps, -- MJ Ray, Software Engineering Specialist, www.software.coop member. (# number in subject emails = copy to all workers unless asked.) Turo Technology LLP, reg'd in England+Wales, number OC303457 Reg. Office: 36 Orchard Cl., Kewstoke, Somerset, GB-BS22 9XY
MJ Ray <mjr@phonecoop.coop> writes:
Please don't hide the instructions. We already have enough problems from people following random web pages instead of the INSTALL* files. I feel they should remain in the top directory.
Lots of other stuff might make sense to move around, but INSTALL*, README, COPYING*, NEWS and Changelog should remain on the top, as in the GNU Coding Standards for releases: http://www.gnu.org/prep/standards/html_node/Releases.html#Releases
Agreed; but things get confusing with several INSTALL* in top directory, and almost overlapping files in install_misc/ directory. At least, for debian. Another approach could be to have a single INSTALL file in the top, with pointers to distro / distroversion specific INSTALL* files in, say, install_misc. Right now, there would be a bit confusion for somebody entirely new to Koha.
Tidying up cronjobs like rebuild_zebra for 3.6 seems like a good idea, especially if the new zebraqueue daemon isn't ready.
As already suggested, will try to create a patch for this. Let me see if I can do it -- Mahesh T. Pai || Distribute Free Software -- Help stamp out Software Hoarding!
participants (4)
-
Chris Cormack -
Mahesh T Pai -
MJ Ray -
Robin Sheat