Imports leading to case sensitivity issues on branchcode&categorycode: finish fixing the UI or revert existing UI fix and fix imports problem root?
Hi :) (if I understand the things correctly) Imports can lead to invalid data (regarding the case) on branchcode&categorycode on some things. This patch went through and fixed part of the UI that was affected: Bug 32517 - Patron search dies on case mismatch of patron category This pending patch fixes another part of the UI: Bug 32706 - User search problem caused by branchcode errors But it was noted that instead of fixing the UI to handle invalid data, that the various import functions should be fixed to enforce that branchcode&categorycode should be uppercase. So: revert Bug 32517 or go on with Bug 32706 fix or something else? Cheers, -- tuxayo
On 23-04-13 00:31, tuxayo wrote:
So: revert Bug 32517 or go on with Bug 32706 fix or something else?
Is there already a mostly consistent policy/track record regarding not doing anything (besides a check in about.pl) regarding badly imported data vs having downstream functions having some defensive programing logic just in case there is bad data? -- tuxayo
Fixing case in the import seems simpler than doing it everywhere else, I suppose 🙂 Marcel ________________________________ Van: Koha-devel <koha-devel-bounces@lists.koha-community.org> namens tuxayo <victor@tuxayo.net> Verzonden: donderdag 13 april 2023 00:39 Aan: koha-devel <koha-devel@lists.koha-community.org> Onderwerp: Re: [Koha-devel] Imports leading to case sensitivity issues on branchcode&categorycode: finish fixing the UI or revert existing UI fix and fix imports problem root? On 23-04-13 00:31, tuxayo wrote:
So: revert Bug 32517 or go on with Bug 32706 fix or something else?
Is there already a mostly consistent policy/track record regarding not doing anything (besides a check in about.pl) regarding badly imported data vs having downstream functions having some defensive programing logic just in case there is bad data? -- tuxayo _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha-community.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fkoha-devel&data=05%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C047beba6e7d344a2277908db3ba6d030%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638169359867044233%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hH9%2B52xAn3hXk4TNt2BvbejGOG%2FKGf5R79JtrGsxFcs%3D&reserved=0<https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> website : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-community.org%2F&data=05%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C047beba6e7d344a2277908db3ba6d030%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638169359867044233%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SIn%2FzDnTGQ23FrLuYtzQ2Z5JjjuWgCOnG7P85SsUvAM%3D&reserved=0<https://www.koha-community.org/> git : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-community.org%2F&data=05%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C047beba6e7d344a2277908db3ba6d030%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638169359867044233%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=getcEadeTnbXz%2BSifLxJvrx%2B1ckwtfMG38ADxfgKJ44%3D&reserved=0<https://git.koha-community.org/> bugs : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2F&data=05%7C01%7Cm.de.rooy%40rijksmuseum.nl%7C047beba6e7d344a2277908db3ba6d030%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638169359867044233%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=qg3rU0bSLBIrdoLQCRmRGFYOtI6SAevFPiMKTZFKMNY%3D&reserved=0<https://bugs.koha-community.org/>
participants (2)
-
Marcel de Rooy -
tuxayo