Fixes to opac-search.pl and opac-advsearch.tmpl
I've been working on the OPAC advanced search page. I solved the problem of expanded search options not showing up. Now that they do, there's a section called Limit Type To that is puzzling me. Here's a sample entry. <td><input type="checkbox" id="mc-bks" name="limit" value="mc:t" /><label for="mc-bks" title="Books, Pamphlets, Technical reports, Manuscripts, Legal papers, Theses and dissertations"><img border="0" src="/intranet-tmpl/prog/en/images/AF.gif" alt="Books" />Books</label></td> First problem is that the images being called apparently don't exist anywhere, so the screen reads BooksBooks (alt text plus the text). Apart from that, I'm trying to figure out exactly what this is supposed to be searching. If I check the box and then search, I get an error of No results match your search for "mc:t" I'm still trying to learn the zebra stuff, but I couldn't find any reference to any of the mc: whatevers found in the various search elements here. Any idea what this is supposed to be doing? Is this a holdover from an old version that shouldn't be here any more, or something that got added but never worked? Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwagner@ptfs.com
That looks like the Item Type limit table. Mine doesn't look anything like that though. mc:t is supposed to be mc-itype:bks or some such. The images too, mine are pulled from /opac-tmpl/... as they are supposed to be on the OPAC. They show up fine from there. I'm wondering if you are running an older revision of Koha. Good luck. On Mon, 2009-04-27 at 16:32 -0400, Wagner, Jane wrote:
I've been working on the OPAC advanced search page. I solved the problem of expanded search options not showing up. Now that they do, there's a section called Limit Type To that is puzzling me. Here's a sample entry.
<td><input type="checkbox" id="mc-bks" name="limit" value="mc:t" /><label for="mc-bks" title="Books, Pamphlets, Technical reports, Manuscripts, Legal papers, Theses and dissertations"><img border="0" src="/intranet-tmpl/prog/en/images/AF.gif" alt="Books" />Books</label></td>
First problem is that the images being called apparently don't exist anywhere, so the screen reads BooksBooks (alt text plus the text). Apart from that, I'm trying to figure out exactly what this is supposed to be searching. If I check the box and then search, I get an error of
No results match your search for "mc:t"
I'm still trying to learn the zebra stuff, but I couldn't find any reference to any of the mc: whatevers found in the various search elements here.
Any idea what this is supposed to be doing? Is this a holdover from an old version that shouldn't be here any more, or something that got added but never worked?
Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwagner@ptfs.com
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel -- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA
for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha
It shouldn't be an old version issue -- I just updated this morning to 3.01.00.029 before I started working on the page. Of course, now there's a .030 out (just loaded it, too). Didn't make a difference, though, and neither did changing the search to mc-itype:bks. Much puzzled.... Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwagner@ptfs.com -----Original Message----- From: Michael Hafen [mailto:mdhafen@tech.washk12.org] Sent: Monday, April 27, 2009 4:46 PM To: Wagner, Jane Cc: koha-devel@lists.koha.org Subject: Re: [Koha-devel] Fixes to opac-search.pl and opac-advsearch.tmpl That looks like the Item Type limit table. Mine doesn't look anything like that though. mc:t is supposed to be mc-itype:bks or some such. The images too, mine are pulled from /opac-tmpl/... as they are supposed to be on the OPAC. They show up fine from there. I'm wondering if you are running an older revision of Koha. Good luck. On Mon, 2009-04-27 at 16:32 -0400, Wagner, Jane wrote:
I've been working on the OPAC advanced search page. I solved the problem of expanded search options not showing up. Now that they do, there's a section called Limit Type To that is puzzling me. Here's a sample entry.
<td><input type="checkbox" id="mc-bks" name="limit" value="mc:t" /><label for="mc-bks" title="Books, Pamphlets, Technical reports, Manuscripts, Legal papers, Theses and dissertations"><img border="0" src="/intranet-tmpl/prog/en/images/AF.gif" alt="Books" />Books</label></td>
First problem is that the images being called apparently don't exist anywhere, so the screen reads BooksBooks (alt text plus the text). Apart from that, I'm trying to figure out exactly what this is supposed to be searching. If I check the box and then search, I get an error of
No results match your search for "mc:t"
I'm still trying to learn the zebra stuff, but I couldn't find any reference to any of the mc: whatevers found in the various search elements here.
Any idea what this is supposed to be doing? Is this a holdover from an old version that shouldn't be here any more, or something that got added but never worked?
Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwagner@ptfs.com
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel -- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA
for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha
Well, I'm stumped. My nearest guess is that opac/htdocs/opac-tmpl/prog/en/modules/opac-advsearch.tmpl didn't get updated for some reason. Maybe filesystem permissions or ownership. That doesn't explain the mc-itype:bks not working though. Maybe you need to re-index zebra after the update? I noticed some changes to both the MARC21 and UNIMARC zebra configs with the update ( one of them was mine :) ). ( Please forgive the self-back-patting ). Any other ideas from the list? On Mon, 2009-04-27 at 16:55 -0400, Wagner, Jane wrote:
It shouldn't be an old version issue -- I just updated this morning to 3.01.00.029 before I started working on the page. Of course, now there's a .030 out (just loaded it, too). Didn't make a difference, though, and neither did changing the search to mc-itype:bks.
Much puzzled....
Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwagner@ptfs.com
-- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha
When there are changes to the zebra index rules, for example, your production copy doesn't get updated by updatedatabase, since you could have stashed it literally anywhere on the filesystem. Compare the uninstalled (updated) versions against your installed (production) versions and incorporate the updates manually. -- Joe Atzberger LibLime - Open Source Library Solutions On Mon, Apr 27, 2009 at 5:04 PM, Michael Hafen <mdhafen@tech.washk12.org>wrote:
Well, I'm stumped. My nearest guess is that opac/htdocs/opac-tmpl/prog/en/modules/opac-advsearch.tmpl didn't get updated for some reason. Maybe filesystem permissions or ownership.
That doesn't explain the mc-itype:bks not working though. Maybe you need to re-index zebra after the update? I noticed some changes to both the MARC21 and UNIMARC zebra configs with the update ( one of them was mine :) ). ( Please forgive the self-back-patting ).
Any other ideas from the list?
On Mon, 2009-04-27 at 16:55 -0400, Wagner, Jane wrote:
It shouldn't be an old version issue -- I just updated this morning to 3.01.00.029 before I started working on the page. Of course, now there's a .030 out (just loaded it, too). Didn't make a difference, though, and neither did changing the search to mc-itype:bks.
Hmm, the process I use updates the template files and the zebra files ( except for re-indexing zebra of course ). After pulling in git ( I actually do fetch and rebase, but that's not important ), I copy the source tree elsewhere ( because I'm paranoid ;) ). In the other copy I run 'perl Makefile.PL --prev-install-log /path/to/koha/misc/koha-install-log'. Then 'make' and 'make install'. Effectively installing over the previous install. That's worked pretty good for me. YMMV. On Mon, 2009-04-27 at 17:25 -0400, Joe Atzberger wrote:
When there are changes to the zebra index rules, for example, your production copy doesn't get updated by updatedatabase, since you could have stashed it literally anywhere on the filesystem. Compare the uninstalled (updated) versions against your installed (production) versions and incorporate the updates manually.
-- Joe Atzberger LibLime - Open Source Library Solutions -- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA
for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha
I just wiped the box & did a new kohaclone install to doublecheck the code, and what came down from koha.org is the same thing: <td><input type="checkbox" id="mc-bks" name="limit" value="mc:t" /><label for="mc-bks" title="Books, Pamphlets, Technical reports, Manuscripts, Legal papers, Theses and dissertations"><img border="0" src="/intranet-tmpl/prog/en/images/AF.gif" alt="Books" />Books</label></td> I’m wondering if this section is even needed. It hasn’t been visible because the check for expanded options hasn’t been working. It seems to be doing a generic item type limitation to Book, Visual Materials, Books on Tape, Computer Files, Local History Materials, and Maps. There are the individual item type or collection code limiters higher on the page which are more accurately tuned to the particular site’s install. Would anyone object if I removed this section altogether? Jane Wagner Library Systems Analyst PTFS Inc. Content Management and Library Solutions 6400 Goldsboro Road, Suite 200 Bethesda, MD 20817 (301) 654-8088 x 151 jwagner@ptfs.com <mailto:jwagner@ptfs.com> From: koha-devel-bounces@lists.koha.org [mailto:koha-devel-bounces@lists.koha.org] On Behalf Of Joe Atzberger Sent: Monday, April 27, 2009 5:25 PM To: Michael Hafen Cc: koha-devel@lists.koha.org Subject: Re: [Koha-devel] Fixes to opac-search.pl and opac-advsearch.tmpl When there are changes to the zebra index rules, for example, your production copy doesn't get updated by updatedatabase, since you could have stashed it literally anywhere on the filesystem. Compare the uninstalled (updated) versions against your installed (production) versions and incorporate the updates manually. -- Joe Atzberger LibLime - Open Source Library Solutions On Mon, Apr 27, 2009 at 5:04 PM, Michael Hafen <mdhafen@tech.washk12.org> wrote: Well, I'm stumped. My nearest guess is that opac/htdocs/opac-tmpl/prog/en/modules/opac-advsearch.tmpl didn't get updated for some reason. Maybe filesystem permissions or ownership. That doesn't explain the mc-itype:bks not working though. Maybe you need to re-index zebra after the update? I noticed some changes to both the MARC21 and UNIMARC zebra configs with the update ( one of them was mine :) ). ( Please forgive the self-back-patting ). Any other ideas from the list? On Mon, 2009-04-27 at 16:55 -0400, Wagner, Jane wrote:
It shouldn't be an old version issue -- I just updated this morning to 3.01.00.029 before I started working on the page. Of course, now there's a .030 out (just loaded it, too). Didn't make a difference, though, and neither did changing the search to mc-itype:bks.
Now I see what you're talking about. I'm stupid to have overlooked that section of the file before. Yeah, I have no idea what that's doing there. I'd vote for getting rid of it. Sorry for my confusion. On Mon, 2009-04-27 at 17:37 -0400, Wagner, Jane wrote:
I just wiped the box & did a new kohaclone install to doublecheck the code, and what came down from koha.org is the same thing:
<td><input type="checkbox" id="mc-bks" name="limit" value="mc:t" /><label for="mc-bks" title="Books, Pamphlets, Technical reports, Manuscripts, Legal papers, Theses and dissertations"><img border="0" src="/intranet-tmpl/prog/en/images/AF.gif" alt="Books" />Books</label></td>
I’m wondering if this section is even needed. It hasn’t been visible because the check for expanded options hasn’t been working. It seems to be doing a generic item type limitation to Book, Visual Materials, Books on Tape, Computer Files, Local History Materials, and Maps. There are the individual item type or collection code limiters higher on the page which are more accurately tuned to the particular site’s install. Would anyone object if I removed this section altogether?
Jane Wagner
Library Systems Analyst
PTFS Inc.
Content Management and Library Solutions
6400 Goldsboro Road, Suite 200
Bethesda, MD 20817
(301) 654-8088 x 151
jwagner@ptfs.com
From:koha-devel-bounces@lists.koha.org [mailto:koha-devel-bounces@lists.koha.org] On Behalf Of Joe Atzberger Sent: Monday, April 27, 2009 5:25 PM To: Michael Hafen Cc: koha-devel@lists.koha.org Subject: Re: [Koha-devel] Fixes to opac-search.pl and opac-advsearch.tmpl
When there are changes to the zebra index rules, for example, your production copy doesn't get updated by updatedatabase, since you could have stashed it literally anywhere on the filesystem. Compare the uninstalled (updated) versions against your installed (production) versions and incorporate the updates manually.
-- Joe Atzberger LibLime - Open Source Library Solutions
On Mon, Apr 27, 2009 at 5:04 PM, Michael Hafen <mdhafen@tech.washk12.org> wrote:
Well, I'm stumped. My nearest guess is that opac/htdocs/opac-tmpl/prog/en/modules/opac-advsearch.tmpl didn't get updated for some reason. Maybe filesystem permissions or ownership.
That doesn't explain the mc-itype:bks not working though. Maybe you need to re-index zebra after the update? I noticed some changes to both the MARC21 and UNIMARC zebra configs with the update ( one of them was mine :) ). ( Please forgive the self-back-patting ).
Any other ideas from the list?
On Mon, 2009-04-27 at 16:55 -0400, Wagner, Jane wrote:
It shouldn't be an old version issue -- I just updated this morning to 3.01.00.029 before I started working on the page. Of course, now there's a .030 out (just loaded it, too). Didn't make a difference, though, and neither did changing the search to mc-itype:bks.
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel -- Michael Hafen Systems Analyst and Programmer Washington County School District Utah, USA
for Koha checkout http://development.washk12.org/gitweb/ or git://development.washk12.org/koha
<td><input type="checkbox" id="mc-bks" name="limit" value="mc:t" /><label for="mc-bks" title="Books, Pamphlets, Technical reports, Manuscripts, Legal papers, Theses and dissertations"><img border="0" src="/intranet-tmpl/prog/en/images/AF.gif" alt="Books" />Books</label></td>
I’m wondering if this section is even needed. It hasn’t been visible because the check for expanded options hasn’t been working.
I'm pretty sure that is obsolete stuff--from dev_week maybe?--and should be removed. -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
participants (4)
-
Joe Atzberger -
Michael Hafen -
Owen Leonard -
Wagner, Jane