I'd like to propose moving the templates directories out of htdocs and into INTRANETDIR/templates/ and OPACDDIR/templates/ I have a couple of reasons for requesting this change: 1. Template files should never be served up by the web server. I don't anticipate any sensitive data being stored in the templates, but they don't _need_ to be served up by the web server, so they should _not_ be in the document root. Configuring Apache to not serve .tmpl files is an unnecessary hack. 2. During upgrades, it is necessary to preserve custom template directories. If the templates are together and alone in one directory this will be much easier. The htdocs directory is getting pretty empty with all the templating work, but it might contain some on-line documentation at some point. Steve Tonnesen.
Hi Steve, I like this idea, and it isnt two hard to change either. htdocs is going to end up being pretty empty in the end, but that doesnt matter. Finlay
I'd like to propose moving the templates directories out of htdocs and into
INTRANETDIR/templates/ and OPACDDIR/templates/
I have a couple of reasons for requesting this change:
1. Template files should never be served up by the web server. I don't anticipate any sensitive data being stored in the templates, but they don't _need_ to be served up by the web server, so they should _not_ be in the document root. Configuring Apache to not serve .tmpl files is an unnecessary hack.
2. During upgrades, it is necessary to preserve custom template directories. If the templates are together and alone in one directory this will be much easier. The htdocs directory is getting pretty empty with all the templating work, but it might contain some on-line documentation at some point.
Steve Tonnesen.
------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Koha-devel mailing list Koha-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/koha-devel
Tonnesen Steve schrieb:
I'd like to propose moving the templates directories out of htdocs and into
INTRANETDIR/templates/ and OPACDDIR/templates/
I have a couple of reasons for requesting this change:
1. Template files should never be served up by the web server. I don't anticipate any sensitive data being stored in the templates, but they don't _need_ to be served up by the web server, so they should _not_ be in the document root. Configuring Apache to not serve .tmpl files is an unnecessary hack.
You are right from this point of view, but on the other hand having the templates in the document root significantly enhances the readability and the ease of theme development. Comparing this strong advantages with the little weakness of an harmless apache hack, I would prefer to keep the templates where they are now.
2. During upgrades, it is necessary to preserve custom template directories. If the templates are together and alone in one directory this will be much easier. The htdocs directory is getting pretty empty with all the templating work, but it might contain some on-line documentation at some point.
I can't see any advantage here. Even if the templates were outside the webtree, the images and so on would still have to be in the webtree. So you would be making two problems from one, because you'd have to check two directories for custom themes where there was only one before. I think your proposal preceeding the 'original' themes with koha- would be a good solution: during upgrade and installation leave all items in the server root alone, which don't start with koha- and we have it. So people could use their servers even for non-koha things without mess. Dorian
On Wed, 30 Oct 2002, Dorian Meid wrote:
I can't see any advantage here. Even if the templates were outside the webtree, the images and so on would still have to be in the webtree. So you would be making two problems from one, because you'd have to check two directories for custom themes where there was only one before. I think your proposal preceeding the 'original' themes with koha- would be a good solution: during upgrade and installation leave all items in the server root alone, which don't start with koha- and we have it. So people could use their servers even for non-koha things without mess.
I forgot about the images. :) It's all coming back to me now. We'll stick with the koha- prefix for determing which directories are koha supplied. I'd think default doc koha-* would be koha supplied directories and will be trounced on upgrades. All else will be left alone. Steve.
participants (3)
-
Dorian Meid -
finlay@katipo.co.nz -
Tonnesen Steve