Hi Thomas, Welcome aboard the Koha devs. I'm afraid we don't accept github pull requests at this time. It's come up a few times, but to keep our workflows clear for the largest group of people we've stuck to Bugzilla and mailbox patches so far (They're easy to apply to all our other infrastructure for testing etc). Onto the patch itself. I've come across this exact case a month or so now.. in fact, I have a vague recollection of pointing it out to someone on IRC recently.. perhaps that was you. Your code looks mostly reasonable to me, but I'm also not close enough to how the linking all fits together to know what side effect it might have.. :(. If you're happy to give git-bz a try as Nicolas suggested, that would give us a head start in terms of onboarding fellow testers and devs.. if not let me know and I can extract your patch from github for you and submit it to BZ. *Martin Renvoize, MPhys (Hons)* <https://www.ptfs-europe.com> Head of Development and Community Engagement *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize@ptfs-europe.com www.ptfs-europe.com *Sign up for our newsletters here <http://eepurl.com/dPjjkn> or by scanning the QR code* Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info@ptfs-europe.com On Tue, 30 Mar 2021 at 08:34, Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:

Hiya Thomas,

Le mar. 30 mars 2021 à 09:28, Thomas Klausner <domm@plix.at> a écrit :

...

Hi!

Can anybody here maybe review / comment on my bug report & patch 28022 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28022

Here's the patch:

https://github.com/domm/Koha/commit/d19abcc23d5793becdd5edca26c4bd2d47fcd33f

Here is the doc explaining how to submit a patch for Koha :

https://wiki.koha-community.org/wiki/Git_bz_configuration

You have to install a utility (git bz) that uploads your patches to Bugzilla. Then other people will be able to test, comment or sign your patch, also using git bz.

Regards,

-- Nicolas _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/

Hi! On Wed, Mar 31, 2021 at 02:04:22PM +0100, Renvoize, Martin wrote:

Welcome aboard the Koha devs. I'm afraid we don't accept github pull

I have now attached the patch to the bugzilla ticket using git-bz.

I've come across this exact case a month or so now.. in fact, I have a vague recollection of pointing it out to someone on IRC recently.. perhaps that was you.

I was asking about the issue a few days ago on IRC; but maybe a colleague also asked about it earlier :-)

Your code looks mostly reasonable to me, but I'm also not close enough to how the linking all fits together to know what side effect it might have.. :(.

I hope that now somebody with more domain knowledge can (easily) review the patch. I'm quite sure that it will only affect the editor, but who knows :-) Thanks for the help & feedback, Greetings, Thomas -- #!/usr/bin/perl http://domm.plix.at for(ref bless{},just'another'perl'hacker){s-:+-$"-g&&print$_.$/}