In C4::Biblio.pm, the subroutine MARCmarc2kohaOneField is passed the current statement handle ($sth) but never uses it. Can anyone tell me if this is a left-over artifact of an earlier functionality? Or an area of future development? The reason I ask is that I've implemented non-filing indicators locally (it is far from elegant, but it works, barely), but in order to do so I needed the database handle ($dbh) in that subroutine. The only subroutine that calls it (MARCmarc2koha) has $dbh, so it wasn't any problem to change the first parameter being passed from $sth to $dbh, but I wondered if that was something that was going to break future planned functionality. I tried to read through the revision notes and comments, but I didn't see anything that pertained. Also, that subroutine isn't exported and the comments indicate it should only be used by MARCmarc2koha (within Biblio.pm), so it seemed pretty self-contained and a managable modification. Thanks, Spencer -- Spencer M. Anspach, Library Systems Analyst/Programmer Library Information Technology, Indiana University Library E456 phone: (812) 856-5318 Bloomington, IN 47405 fax: (812) 856-4979 sanspach@indiana.edu pager: (812) 335-7403
Spencer Anspach a écrit :
In C4::Biblio.pm, the subroutine MARCmarc2kohaOneField is passed the current statement handle ($sth) but never uses it. Can anyone tell me if this is a left-over artifact of an earlier functionality? Or an area of future development? i'm the author of Biblio.pm, and don't remember exactly, but it should a left-over artifact. A long time ago, we had not the great C4::Context pckage, and passing $sth as parameter everywhere was important to get a db handler. Now it' highly less interesting.
-- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
Great! Thanks for the information. It is really nice to have the non-filing indicators, so I'm really happy what I've done (hopefully!) won't break too much. Spencer On 9/13/05, Paul POULAIN <paul.poulain@free.fr> wrote:
Spencer Anspach a écrit :
In C4::Biblio.pm <http://Biblio.pm>, the subroutine MARCmarc2kohaOneField is passed the current statement handle ($sth) but never uses it. Can anyone tell me if this is a left-over artifact of an earlier functionality? Or an area of future development? i'm the author of Biblio.pm <http://Biblio.pm>, and don't remember exactly, but it should a left-over artifact. A long time ago, we had not the great C4::Context pckage, and passing $sth as parameter everywhere was important to get a db handler. Now it' highly less interesting.
-- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
-- Spencer M. Anspach, Library Systems Analyst/Programmer Library Information Technology, Indiana University Library E456 phone: (812) 856-5318 Bloomington, IN 47405 fax: (812) 856-4979 sanspach@indiana.edu pager: (812) 335-7403
Spencer Anspach a écrit :
Great! Thanks for the information.
It is really nice to have the non-filing indicators, so I'm really happy what I've done (hopefully!) won't break too much.
don't forget to share your code (here is a good place), i'll look at it deeply to see if it can be included in official koha -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
participants (2)
-
Paul POULAIN -
Spencer Anspach