regarding authentication
Hello, I am new to perl as well as to koha and I want to modify Koha's code for authentication such that if a user with user name let say admin is logged in and meanwhile someone else wants to login with the same user name that is admin but with different ip address then the koha should restrict this activity. If user logged in has the following details - username-admin ip-192.168.1.129 and if another user try to login with the following - username-admin ip-192.168.1.130 Then that user should not be able to logged in. I have been reading the Auth.pm file, it has code regarding authentication and I am unable to find that where the user is allowed to login after successful authentication as I want to put my code at that place.
Hi Devs, I've been implementing a first prototype of what may looks like "Amazon buy suggestions" like "other users who have bought this also bought...." It provides a list of similar references based on what other borrowers has previously issued. If anyone would like to test this it is available here : https://github.com/Liliputech/KohaReadSuggestion Hope you'll like this work in progress. Special thanks to Kile Hall whose previous and current work on Koha Plugin System has really helped me a lot while designing this. More information on installing plugins here : http://bywatersolutions.com/2013/01/23/koha-plugin-system-coming-soon/ Thanks to the whole Koha community for the great software and clean code and to Kohala for the organization of the Koha Symposium in France, Lyon. Best regards, Arthur Suzuki Librarians IT Team, University Jean Moulin Lyon 3
Hi Arthur, Reading the code it will only work for UNIMARC, you should mention it in the README and tell people which changes are needed to make it work for MARC21 (and add a couple of lines to explain what the plugin does). Did you test it on a real DB, with lot of entries in old_issues? It might be quite slow. Why did you choose to create a plugin instead of something integrated to Koha (and submit the patch on bugzilla)? Cheers, Jonathan 2016-07-01 16:01 GMT+01:00 SUZUKI Arthur <arthur.suzuki@univ-lyon3.fr>:
Hi Devs, I've been implementing a first prototype of what may looks like "Amazon buy suggestions" like "other users who have bought this also bought...." It provides a list of similar references based on what other borrowers has previously issued.
If anyone would like to test this it is available here : https://github.com/Liliputech/KohaReadSuggestion
Hope you'll like this work in progress. Special thanks to Kile Hall whose previous and current work on Koha Plugin System has really helped me a lot while designing this. More information on installing plugins here : http://bywatersolutions.com/2013/01/23/koha-plugin-system-coming-soon/
Thanks to the whole Koha community for the great software and clean code and to Kohala for the organization of the Koha Symposium in France, Lyon. Best regards,
Arthur Suzuki Librarians IT Team, University Jean Moulin Lyon 3 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
To all your questions, yes sure! About UNIMARC or MARC21, this is quite easy to implement, it just needs some parameters to the report-step1 sub and template. I tested it on our pre-production server, the query takes 1s at the maximum to scan the whole DB (i did only sub selects and inner join to get a reduced dataset). "Release early, release often", i thought it would be much easier to implement first in a plugin plus it is nice to use this new feature. And really easy to install without messing with custom patches and git branches. Many ways to optimize: SQL: -create a table to store those lists, like an index? -filter or aggregate results on several fields (type of documents, subject, country, author, whatever)? Template: -How to integrate into OPAC? Also every text is hardcoded for now, I don't know yet if translation is available through the plugin system, this is to be investigated. Otherwise yes, could be merged to core code but I would need help on this because I don't know much about the core Koha architecture. Have a nice weekend, Cheers Arthur Le 1 juillet 2016 17:44:54 UTC+02:00, Jonathan Druart <jonathan.druart@bugs.koha-community.org> a écrit :
Hi Arthur,
Reading the code it will only work for UNIMARC, you should mention it in the README and tell people which changes are needed to make it work for MARC21 (and add a couple of lines to explain what the plugin does).
Did you test it on a real DB, with lot of entries in old_issues? It might be quite slow.
Why did you choose to create a plugin instead of something integrated to Koha (and submit the patch on bugzilla)?
Cheers, Jonathan
2016-07-01 16:01 GMT+01:00 SUZUKI Arthur <arthur.suzuki@univ-lyon3.fr>:
Hi Devs, I've been implementing a first prototype of what may looks like "Amazon buy suggestions" like "other users who have bought this also bought...." It provides a list of similar references based on what other borrowers has previously issued.
If anyone would like to test this it is available here : https://github.com/Liliputech/KohaReadSuggestion
Hope you'll like this work in progress. Special thanks to Kile Hall whose previous and current work on Koha Plugin System has really helped me a lot while designing this. More information on installing plugins here :
http://bywatersolutions.com/2013/01/23/koha-plugin-system-coming-soon/
Thanks to the whole Koha community for the great software and clean
code and
to Kohala for the organization of the Koha Symposium in France, Lyon. Best regards,
Arthur Suzuki Librarians IT Team, University Jean Moulin Lyon 3 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi Payal, You will have to write quite lot of code to achieve this goal. Currently we do not have the "user A is currently logged in" information. And actually I am not sure how you could know that if the user does not click on "logout". The authentication checks are done in C4::Auth::checkauth Regards, Jonathan 2016-07-01 8:43 GMT+01:00 Payal Mangyani <payal.mangyani3@gmail.com>:
Hello, I am new to perl as well as to koha and I want to modify Koha's code for authentication such that if a user with user name let say admin is logged in and meanwhile someone else wants to login with the same user name that is admin but with different ip address then the koha should restrict this activity. If user logged in has the following details - username-admin ip-192.168.1.129 and if another user try to login with the following - username-admin ip-192.168.1.130 Then that user should not be able to logged in.
I have been reading the Auth.pm file, it has code regarding authentication and I am unable to find that where the user is allowed to login after successful authentication as I want to put my code at that place.
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (3)
-
Jonathan Druart -
Payal Mangyani -
SUZUKI Arthur