Hi everyone, Just a quick request regarding commits to Koha. Please make sure that whatever you're committing at least compiles. It's fine if it doesn't work exactly like it should -- but it should at least compile ;-). This goes for all commits -- even those to HEAD (2.3). Thanks, -- Joshua Ferraro VENDOR SERVICES FOR OPEN-SOURCE SOFTWARE President, Technology migration, training, maintenance, support LibLime Koha ILS, Mambo Intranet, DiscrimiNet Filter jmf@liblime.com | Full Demos at http://liblime.com | 1(888)KohaILS
Joshua Ferraro <jmf@liblime.com> wrote:
Just a quick request regarding commits to Koha. Please make sure that whatever you're committing at least compiles. It's fine if it doesn't work exactly like it should -- but it should at least compile ;-). This goes for all commits -- even those to HEAD (2.3).
Is perl -c filename a good enough check, or full perltidy, or do you want unit tests for all new code? Thanks, -- MJ Ray (slef), K. Lynn, England, email see http://mjr.towers.org.uk/
I think perl -c is a good _minimum_ requirement. My personal preference is to do my development work, then add it to my two installations of Koha where an up-to-date CVS repo is symlinked to the Koha directories (one for HEAD and one for rel_2_2) ... that way, when I've finished a job I can try it out to make sure it's not broken and then directly commit it from a known working repo ... -- Joshua Ferraro VENDOR SERVICES FOR OPEN-SOURCE SOFTWARE President, Technology migration, training, maintenance, support LibLime Koha ILS, Mambo Intranet, DiscrimiNet Filter jmf@liblime.com | Full Demos at http://liblime.com | 1(888)KohaILS
Joshua Ferraro <jmf@liblime.com> wrote:
I think perl -c is a good _minimum_ requirement. My personal preference is to do my development work, then add it to my two installations [...]
Minimum? What else is there at the moment? Not all parts of koha are easy to hack interactively like the web frontend and often the bug I'm trying to fix doesn't even show itself on my development systems. It's not practical to run a full test install of koha before every commit of an installer patch. I think we need a test practice and a QA leader. -- MJ Ray (slef), K. Lynn, England, email see http://mjr.towers.org.uk/
On Tue, Jul 12, 2005 at 03:50:05PM +0100, MJ Ray wrote:
I think we need a test practice and a QA leader. I agree completely. Any volunteers?
-- Joshua Ferraro VENDOR SERVICES FOR OPEN-SOURCE SOFTWARE President, Technology migration, training, maintenance, support LibLime Koha ILS, Mambo Intranet, DiscrimiNet Filter jmf@liblime.com | Full Demos at http://liblime.com | 1(888)KohaILS
participants (2)
-
Joshua Ferraro -
MJ Ray