We have fully documented the process of adding a syspref to Koha[1]. It remains unclear which workflow syspref deprecation should follow. I've been told on IRC that, traditionally, deprecated sysprefs are set to a 'good default' value, and then hidden. If you take a look at bug 8724 [2] you'll notice that i followed that path. But as NoZebra is to be fully removed from Koha tree I ask: what do u think the workflow for syspref removal be? It should be added to the sysprefs wiki too. I can do it if needed. Regards To+ [1] http://wiki.koha-community.org/wiki/System_Preferences [2] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724
Hi, On 09/05/2012 10:50 AM, Tomas Cohen Arazi wrote:
If you take a look at bug 8724 [2] you'll notice that i followed that path. But as NoZebra is to be fully removed from Koha tree I ask: what do u think the workflow for syspref removal be? It should be added to the sysprefs wiki too. I can do it if needed.
I would think it should be something like this: [1] Remove all code that uses the syspref. [2] Remove all references to the syspref from preferences/*.pref. [3] Remove all references to the syspref from the installer SQL for all localizations. [4] Add an update to updatedatabase.pl deleting the preference from the systempreferences table. Regards, Galen -- Galen Charlton Director of Support and Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
On Wed, Sep 05, 2012 at 11:41:41AM -0400, Galen Charlton wrote:
Hi,
On 09/05/2012 10:50 AM, Tomas Cohen Arazi wrote:
If you take a look at bug 8724 [2] you'll notice that i followed that path. But as NoZebra is to be fully removed from Koha tree I ask: what do u think the workflow for syspref removal be? It should be added to the sysprefs wiki too. I can do it if needed.
I would think it should be something like this:
[1] Remove all code that uses the syspref. [2] Remove all references to the syspref from preferences/*.pref. [3] Remove all references to the syspref from the installer SQL for all localizations. [4] Add an update to updatedatabase.pl deleting the preference from the systempreferences table.
Do we need to add an explicit step to ensure that the removal is included in the release notes of the upstream release? Or will the commit message from [2] suffice Colin -- Colin Campbell Chief Software Engineer, PTFS Europe Limited Content Management and Library Solutions +44 (0) 800 756 6803 (phone) +44 (0) 7759 633626 (mobile) colin.campbell@ptfs-europe.com skype: colin_campbell2 http://www.ptfs-europe.com
Colin, Do we need to add an explicit step to ensure that the removal is
included in the release notes of the upstream release? Or will the commit message from [2] suffice
The list of sysprefs in the release notes is automatically generated. I will add to the script so that it notes removed sysprefs, too. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
On Wed, Sep 5, 2012 at 1:04 PM, Jared Camins-Esakov <jcamins@cpbibliography.com> wrote:
Colin,
Do we need to add an explicit step to ensure that the removal is included in the release notes of the upstream release? Or will the commit message from [2] suffice
The list of sysprefs in the release notes is automatically generated. I will add to the script so that it notes removed sysprefs, too.
I have added this to the sysprefs wiki section. Any corrections will be welcomed. Quick link http://wiki.koha-community.org/wiki/System_Preferences#Removing_a_system_pre... Regards To+
At 11:41 AM 9/5/2012 -0400, Galen Charlton wrote:
On 09/05/2012 10:50 AM, Tomas Cohen Arazi wrote:
If you take a look at bug 8724 [2] you'll notice that i followed that path. But as NoZebra is to be fully removed from Koha tree I ask: what do u think the workflow for syspref removal be? It should be added to the sysprefs wiki too. I can do it if needed.
I would think it should be something like this:
[1] Remove all code that uses the syspref. [2] Remove all references to the syspref from preferences/*.pref. [3] Remove all references to the syspref from the installer SQL for all localizations. [4] Add an update to updatedatabase.pl deleting the preference from the systempreferences table.
+1 but from an excess of caution, is there any possibility that this could complicate a MySQL {dump form earlier version} ==> {restore to a brand new install}? Best - Paul
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 05-09-12 19:08, Paul schreef:
[4] Add an update to updatedatabase.pl deleting the preference from the systempreferences table.
+1
but from an excess of caution, is there any possibility that this could complicate a MySQL {dump form earlier version} ==> {restore to a brand new install}?
Step [4] should take care of that case. And if it doesn't, the result really is just that the syspref will be there and not do anything. - -- Robin Sheat Catalyst IT Ltd. ? +64 4 803 2204 GPG: 5957 6D23 8B16 EFAB FEF8 7175 14D3 6485 A99C EB6D -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlBHoRIACgkQFNNkhamc623w5ACfaZTnQ3i44YZLd8xEuEp0Kz13 y5EAn3zq0dnmPVpTX0Hla8ZAV3y68kgE =F5xJ -----END PGP SIGNATURE-----
participants (6)
-
Colin Campbell -
Galen Charlton -
Jared Camins-Esakov -
Paul -
Robin Sheat -
Tomas Cohen Arazi