Permission to remove /misc/cronjobs/staticfines.pl
Hi Everyone, In a quest to clean up an unused database field in the issuingrules table (Bug 21753 - issuingrules.chargename is unused and should be removed) I found a fines script which I've never seen before. It looks like a good candidate for removal after a quick query to the irc channels but I wanted to open it here to check if anyone is indeed still using this particular mode of calculating fines. Many thanks, *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize@ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info@ptfs-europe.com
Hi, On 18-11-02 10:39, Renvoize, Martin wrote:
In a quest to clean up an unused database field in the issuingrules table (Bug 21753 - issuingrules.chargename is unused and should be removed) I found a fines script which I've never seen before. It looks like a good candidate for removal after a quick query to the irc channels but I wanted to open it here to check if anyone is indeed still using this particular mode of calculating fines.
We know at least 6 Koha instances that use this script. It's from bug 6858 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858 Cheers, -- Victor Grousset, dev support/maintenance BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Libre/Open Source software and services for libraries
Glad I asked, and good to know it is still useful for some out there. Agree with Katrin though, it would be great to have it documented so others may use it too and not duplicate effort if they have similar needs.
From a developers point of view, I struggled to understand its use and as such when looking at bugs in that area of the codebase I wasn't entirely confident I wouldn't be introducing bugs into this script inadvertently whilst fixing code it utilises.
On Mon, 5 Nov 2018, 2:38 pm Katrin Fischer <Katrin.Fischer.83@web.de wrote:
Hi,
the documentation is not clear about fines.pl being the standard and staticfines being a different use case. We should at least update the manual:
https://koha-community.org/manual/18.05/en/html/cron_jobs.html#cron-jobs-sub...
For example: where do you configure the fine amount, intervals, etc.
Katrin
*Gesendet:* Montag, 05. November 2018 um 15:28 Uhr *Von:* "Victor Grousset" <victor.grousset@biblibre.com> *An:* "Renvoize, Martin" <martin.renvoize@ptfs-europe.com>, koha@lists.katipo.co.nz, "Koha Devel" <koha-devel@lists.koha-community.org
*Betreff:* Re: [Koha-devel] Permission to remove /misc/cronjobs/ staticfines.pl Hi,
On 18-11-02 10:39, Renvoize, Martin wrote:
In a quest to clean up an unused database field in the issuingrules table (Bug 21753 - issuingrules.chargename is unused and should be removed) I found a fines script which I've never seen before. It looks like a good candidate for removal after a quick query to the irc channels but I wanted to open it here to check if anyone is indeed still using this particular mode of calculating fines.
We know at least 6 Koha instances that use this script.
It's from bug 6858 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858
Cheers,
-- Victor Grousset, dev support/maintenance BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Libre/Open Source software and services for libraries _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (3)
-
Katrin Fischer -
Renvoize, Martin -
Victor Grousset