Signed off patches to the patches list?
Hi! http://wiki.koha-community.org/wiki/Git_bz_configuration still says "It is still considered good practice to send the signed off patch to the patches mailing list", but it seems that few folks do it and using git bz seems to have made this practice obsolete. Any objections to deleting this line and the command that accomplishes it? Best regards, Magnus libriotech.no
Le 14/09/2012 11:59, Magnus Enger a écrit :
Hi!
http://wiki.koha-community.org/wiki/Git_bz_configuration still says "It is still considered good practice to send the signed off patch to the patches mailing list", but it seems that few folks do it and using git bz seems to have made this practice obsolete. Any objections to deleting this line and the command that accomplishes it? +1
It's also written somewhere that enhancements must be described on the wiki, and I also think it's not the case. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On 2012-09-14, at 11:22 PM, Paul Poulain wrote:
Le 14/09/2012 11:59, Magnus Enger a écrit :
Hi!
http://wiki.koha-community.org/wiki/Git_bz_configuration still says "It is still considered good practice to send the signed off patch to the patches mailing list", but it seems that few folks do it and using git bz seems to have made this practice obsolete.
Any objections to deleting this line and the command that accomplishes it? +1
+1 for me too :)
On 17 September 2012 15:44, Mason James <mtj@kohaaloha.com> wrote:
On 2012-09-14, at 11:22 PM, Paul Poulain wrote:
Le 14/09/2012 11:59, Magnus Enger a écrit :
Hi!
http://wiki.koha-community.org/wiki/Git_bz_configuration still says "It is still considered good practice to send the signed off patch to the patches mailing list", but it seems that few folks do it and using git bz seems to have made this practice obsolete.
Any objections to deleting this line and the command that accomplishes it? +1
+1 for me too :)
Do make sure you keep a copy of your patches then, either in a offsite repository you push to, or a usb key etc. Since now instead of being in the archives, and in hundreds for peoples inboxes, the one copy is in a database on my linode server. I back up, but ... I don't rely on myself and keep extra copies, you should too. Chris
On 2012-09-17, at 3:46 PM, Chris Cormack wrote:
On 17 September 2012 15:44, Mason James <mtj@kohaaloha.com> wrote:
On 2012-09-14, at 11:22 PM, Paul Poulain wrote:
Le 14/09/2012 11:59, Magnus Enger a écrit :
Hi!
http://wiki.koha-community.org/wiki/Git_bz_configuration still says "It is still considered good practice to send the signed off patch to the patches mailing list", but it seems that few folks do it and using git bz seems to have made this practice obsolete.
Any objections to deleting this line and the command that accomplishes it? +1
+1 for me too :)
Do make sure you keep a copy of your patches then, either in a offsite repository you push to, or a usb key etc. Since now instead of being in the archives, and in hundreds for peoples inboxes, the one copy is in a database on my linode server.
I back up, but ... I don't rely on myself and keep extra copies, you should too.
just thinking... a trivial change to git-bz could email the patch to the patches@list, when uploaded a patch to bugzilla which would be a double-win, i think i'll attempt this sometime soon, and report back to the list...
Greetings, Originally asked:
Any objections to deleting this line and the command that accomplishes it?
I think I've already registered my objection and suggestion to put it in a non-textbox. Mason James replied:
just thinking... a trivial change to git-bz could email the patch to the patches@list, when uploaded a patch to bugzilla which would be a double-win, i think i'll attempt this sometime soon, and report back to the list...
+1 -- And then I wouldn't object to it being deleted. :) GPML, Mark Tompsett
On 2012-09-17, at 4:30 PM, Mason James wrote:
On 2012-09-17, at 3:46 PM, Chris Cormack wrote:
On 17 September 2012 15:44, Mason James <mtj@kohaaloha.com> wrote:
On 2012-09-14, at 11:22 PM, Paul Poulain wrote:
Le 14/09/2012 11:59, Magnus Enger a écrit :
Hi!
http://wiki.koha-community.org/wiki/Git_bz_configuration still says "It is still considered good practice to send the signed off patch to the patches mailing list", but it seems that few folks do it and using git bz seems to have made this practice obsolete.
Any objections to deleting this line and the command that accomplishes it? +1
+1 for me too :)
Do make sure you keep a copy of your patches then, either in a offsite repository you push to, or a usb key etc. Since now instead of being in the archives, and in hundreds for peoples inboxes, the one copy is in a database on my linode server.
I back up, but ... I don't rely on myself and keep extra copies, you should too.
just thinking... a trivial change to git-bz could email the patch to the patches@list, when uploaded a patch to bugzilla
which would be a double-win, i think
i'll attempt this sometime soon, and report back to the list…
well, i finally got round to sorting this one i added a '--mail' arg to git-bz so, to send your patch to the koha-patches list, when attaching to bugzilla, run... $ git-bz attach -m 1234 HEAD i've pushed the change to my git repo, for your pulling pleasure -> https://github.com/KohaAloha/git-bz feedback welcome
just thinking... a trivial change to git-bz could email the patch to the patches@list, when uploaded a patch to bugzilla
which would be a double-win, i think
i'll attempt this sometime soon, and report back to the list...
I was thinking the same thing. I wonder if it would be possible to have the bugzilla server automatically email attached patches to the patches list even. Kyle
Op 27-09-12 00:25, Kyle Hall schreef:
I was thinking the same thing. I wonder if it would be possible to have the bugzilla server automatically email attached patches to the patches list even.
I thought we didn't want signed-off patches going to the mailing list, as it's somewhat unnecessary for the most part... Robin.
Hi, On Sun, Sep 16, 2012 at 11:46 PM, Chris Cormack <chris@bigballofwax.co.nz> wrote:
Do make sure you keep a copy of your patches then, either in a offsite repository you push to, or a usb key etc. Since now instead of being in the archives, and in hundreds for peoples inboxes, the one copy is in a database on my linode server.
I back up, but ... I don't rely on myself and keep extra copies, you should too.
Good point. As a way of giving an easy place for folks to back patches up, we could institute a working Koha Git repository that anybody could push to. Do others think this would be useful? Regards, Galen -- Galen Charlton Director of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Good point. As a way of giving an easy place for folks to back patches up, we could institute a working Koha Git repository that anybody could push to. Do others think this would be useful?
+1..inf I have been very impressed with how convenient the Evergreen working repo is. Regards, Jared -- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
Op 17-09-12 15:54, Jared Camins-Esakov schreef:
I have been very impressed with how convenient the Evergreen working repo is.
This works without people getting confused about what master is? It sounds like a great idea, especially when sharing work with other developers (e.g. I can't give people commit access to the catalyst repo, even if I wanted to.) -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5957 6D23 8B16 EFAB FEF8 7175 14D3 6485 A99C EB6D
Hi, On Mon, Sep 17, 2012 at 10:05 AM, Robin Sheat <robin@catalyst.net.nz> wrote:
This works without people getting confused about what master is? It sounds like a great idea, especially when sharing work with other developers (e.g. I can't give people commit access to the catalyst repo, even if I wanted to.)
Yes. The way it works in Evergreen is that there's a working repository [1] separate from the main Evergreen repository. Anybody who has an SSH key registered with the Gitolite installation managing Evergreen's Git server can push branches to the working repo. It's currently configured so that a person could push a branch starting with user/$username and have exclusive access to push to that branch, or push to a branch starting with collab/$username to allow anybody to also push to that branch. [1] http://git.evergreen-ils.org/?p=working/Evergreen.git;a=summary Regards, Galen -- Galen Charlton Director of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Le 17/09/2012 16:10, Galen Charlton a écrit :
Yes. The way it works in Evergreen is that there's a working repository [1] separate from the main Evergreen repository. Anybody who has an SSH key registered with the Gitolite installation managing Evergreen's Git server can push branches to the working repo. It's currently configured so that a person could push a branch starting with user/$username and have exclusive access to push to that branch, or push to a branch starting with collab/$username to allow anybody to also push to that branch.
I really love the idea of having something where everybody can push, but it can't be adopted "as is": * where would ppl signoff patches ? (ie: in which branch ?) * how would patches be pushed ? through a merge ? For signing-off, there are many possibilities: * the patch to signoff is pushed to collab/bug_NNNN, and, when it's signed-off, the signoffer does a push -f ? * the patch to signoff is pushed to collab/$patchauthor/bug_NNNN, the signed-off patch is pushed to a specific signed-off branch (like collab/signed_off/bug_NNNN) Having a separate repo for wip is also a good way to have an official repo without zillions of branches: koha.git would become koha_wip.git (with all branches) and a new koha.git repo is created, from koha_wip, but only with released & master branches (Is it also time to speak again of putting languages in a specific repo ?) -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On 2012-09-18, at 1:54 AM, Jared Camins-Esakov wrote:
Good point. As a way of giving an easy place for folks to back patches up, we could institute a working Koha Git repository that anybody could push to. Do others think this would be useful?
+1..inf
I have been very impressed with how convenient the Evergreen working repo is.
+1 for me too, this sounds like a great idea
Regards, Jared
-- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
cheers, Mason -- KohaAloha, NZ
Greetings, Not that I have gotten to use this a lot, but I was thinking that perhaps a reorder tweak and putting that tiny part in a paragraph of its own without the text box should be sufficient for people glossing over to skip it. I'm not sure you want to lose the information, but rather just hide it in commentary. --- BEGIN SUGGEST TWEAK --- This is also a good moment to open your bug in bugzilla using http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=xxxx url and change "Patch status" to "Signed Off It is still considered good practice to send the signed off patch to the patches mailing list, but not required. If you wish to do so, it can be done with a single command: git send-email --to 'koha-patches@lists.koha-community.org' origin/master This assumes that you have called the remote for the officia Koha repo "origin" and that you have an up-to-date master branch from there. -- END SUGGEST TWEAK --- Those three lines on their own may get skipped, since the "Bugs with more than one patch" is a header and bolded. And without the text box, there's nothing to draw the eye to it. GPML, Mark Tompsett
No, the point is more that it should be removed because it's no longer really needed as good practice. Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings,
Not that I have gotten to use this a lot, but I was thinking that perhaps a reorder tweak and putting that tiny part in a paragraph of its own without the text box should be sufficient for people glossing over to skip it. I'm not sure you want to lose the information, but rather just hide it in commentary.
--- BEGIN SUGGEST TWEAK --- This is also a good moment to open your bug in bugzilla using http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=xxxx url and change "Patch status" to "Signed Off
It is still considered good practice to send the signed off patch to the patches mailing list, but not required. If you wish to do so, it can be done with a single command: git send-email --to 'koha-patches@lists.koha-community.org' origin/master This assumes that you have called the remote for the officia Koha repo "origin" and that you have an up-to-date master branch from there. -- END SUGGEST TWEAK ---
Those three lines on their own may get skipped, since the "Bugs with more than one patch" is a header and bolded. And without the text box, there's nothing to draw the eye to it.
GPML, Mark Tompsett
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Sent from my Android phone with K-9 Mail. Please excuse my brevity.
participants (9)
-
Chris Cormack -
Galen Charlton -
Jared Camins-Esakov -
Kyle Hall -
Magnus Enger -
Mark Tompsett -
Mason James -
Paul Poulain -
Robin Sheat