I've been struggling for a couple of days with getting plugins to work with koha-testing-docker. I'm using the latest Koha source and koha-testing-docker images, I started the container with the "ku" alias, and it's running correctly. Plugins are enabled in koha-conf.xml; here are the relevant lines: <pluginsdir>/var/lib/koha/kohadev/plugins</pluginsdir> <!-- This entry can be repeated to use multiple directories --> <!--pluginsdir>/kohadevbox/koha_plugin</pluginsdir--> <enable_plugins>1</enable_plugins> But when I log into the Koha staff client using the koha user, which is a superlibrarian, I don't see "Tool plugins" under the "Additional tools" heading on the Tools page. I'm not familiar with debugging Perl; my experience is from years of using GDB with C/C++. The README for koha-testing-docker has only the barest hints about debugging. Before I resort to debugging with print statements (or system("echo something >>/tmp/junk")), is there a better way for me to figure out what's wrong here? -- To any truly impartial person, it would be obvious that I'm always right. --Ashleigh Brilliant
Hi Mark, did you `restart_all` to restart memcached, then plack? Le mer. 25 nov. 2020 à 18:55, Mark Alexander <marka@pobox.com> a écrit :
I've been struggling for a couple of days with getting plugins to work with koha-testing-docker. I'm using the latest Koha source and koha-testing-docker images, I started the container with the "ku" alias, and it's running correctly. Plugins are enabled in koha-conf.xml; here are the relevant lines:
<pluginsdir>/var/lib/koha/kohadev/plugins</pluginsdir> <!-- This entry can be repeated to use multiple directories --> <!--pluginsdir>/kohadevbox/koha_plugin</pluginsdir--> <enable_plugins>1</enable_plugins>
But when I log into the Koha staff client using the koha user, which is a superlibrarian, I don't see "Tool plugins" under the "Additional tools" heading on the Tools page.
I'm not familiar with debugging Perl; my experience is from years of using GDB with C/C++. The README for koha-testing-docker has only the barest hints about debugging. Before I resort to debugging with print statements (or system("echo something >>/tmp/junk")), is there a better way for me to figure out what's wrong here?
-- To any truly impartial person, it would be obvious that I'm always right. --Ashleigh Brilliant _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Excerpts from Jonathan Druart's message of 2020-11-25 19:30:07 +0100:
Hi Mark, did you `restart_all` to restart memcached, then plack?
Yes, I did both, but the problem persists. Here's what I did, in case I misunderstood: $ restart_all [ ok ] Restarting Apache httpd web server: apache2. [ ok ] Restarting Koha ILS: koha-common[....] Stopping Plack daemon for kohadev:. [ ok ] Stopping Z39.50/SRU daemon for kohadev:. [ ok ] Stopping Koha worker daemon for kohadev:. [ ok ] Stopping Koha indexing daemon for kohadev:. [ ok ] Starting Plack daemon for kohadev:. [ ok ] Starting Z39.50/SRU daemon for kohadev:. [ ok ] Starting Koha worker daemon for kohadev:. [ ok ] Starting Koha indexing daemon for kohadev:. . ok $ koha-plack --restart kohadev [ ok ] Stopping Plack daemon for kohadev:. [ ok ] Starting Plack daemon for kohadev:. -- I sometimes forget which side I'm on. --Ashleigh Brilliant
I think the problem is due to change fb59f3f0f04: Author: Fridolin Somers <fridolin.somers@biblibre.com> Date: Tue Sep 1 15:43:19 2020 +0200 Bug 26338: Show tool plugins run in tools home In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home. Also adds the behavior than if there is no tool plugin, "Tool plugins" section is not displayed in tools home. No need of a link that goes to an empty table ;) The relevant bit of code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt is this: [% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool && tool_plugins ) %] <dt><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=tool">Tool plugins</a></dt> <dd> Use tool plugins [... stuff deleted ...] [% END %] Before the change mentioned above, the first line of that snippet looked like this: [% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool ) %] Restoring that line to its previous state fixed the problem. -- Surely I deserve some kind of recognition for all the bad things I haven't done. --Ashleigh Brilliant
I was about to say that sounds like a regression, but it looks like that behaviour is intentional, if you read the commit message: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338#c11 You should be able to manage plugins if you go to "Administration" still. David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Mark Alexander Sent: Thursday, 26 November 2020 1:05 PM To: koha-devel <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] koha-testing-docker and plugins I think the problem is due to change fb59f3f0f04: Author: Fridolin Somers <fridolin.somers@biblibre.com> Date: Tue Sep 1 15:43:19 2020 +0200 Bug 26338: Show tool plugins run in tools home In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home. Also adds the behavior than if there is no tool plugin, "Tool plugins" section is not displayed in tools home. No need of a link that goes to an empty table ;) The relevant bit of code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt is this: [% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool && tool_plugins ) %] <dt><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=tool">Tool plugins</a></dt> <dd> Use tool plugins [... stuff deleted ...] [% END %] Before the change mentioned above, the first line of that snippet looked like this: [% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool ) %] Restoring that line to its previous state fixed the problem. -- Surely I deserve some kind of recognition for all the bad things I haven't done. --Ashleigh Brilliant _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi Indeed, I think it is logical that link only shows when we have a plugin with tool method. We have indeed Administration > Manage plugins. Best regards, Le 26/11/2020 à 04:41, dcook@prosentient.com.au a écrit :
I was about to say that sounds like a regression, but it looks like that behaviour is intentional, if you read the commit message: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338#c11
You should be able to manage plugins if you go to "Administration" still.
David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia
Office: 02 9212 0899 Online: 02 8005 0595
-----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Mark Alexander Sent: Thursday, 26 November 2020 1:05 PM To: koha-devel <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] koha-testing-docker and plugins
I think the problem is due to change fb59f3f0f04:
Author: Fridolin Somers <fridolin.somers@biblibre.com> Date: Tue Sep 1 15:43:19 2020 +0200
Bug 26338: Show tool plugins run in tools home
In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home.
Also adds the behavior than if there is no tool plugin, "Tool plugins" section is not displayed in tools home. No need of a link that goes to an empty table ;)
The relevant bit of code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt is this:
[% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool && tool_plugins ) %] <dt><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=tool">Tool plugins</a></dt> <dd> Use tool plugins [... stuff deleted ...] [% END %]
Before the change mentioned above, the first line of that snippet looked like this:
[% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool ) %]
Restoring that line to its previous state fixed the problem.
-- Surely I deserve some kind of recognition for all the bad things I haven't done. --Ashleigh Brilliant _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄 BibLibre, France
Maybe we could add a link to plugins in staff home page. (if user has permission of course) Le 26/11/2020 à 10:50, Fridolin SOMERS a écrit :
Hi
Indeed, I think it is logical that link only shows when we have a plugin with tool method.
We have indeed Administration > Manage plugins.
Best regards,
Le 26/11/2020 à 04:41, dcook@prosentient.com.au a écrit :
I was about to say that sounds like a regression, but it looks like that behaviour is intentional, if you read the commit message: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338#c11
You should be able to manage plugins if you go to "Administration" still.
David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia
Office: 02 9212 0899 Online: 02 8005 0595
-----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Mark Alexander Sent: Thursday, 26 November 2020 1:05 PM To: koha-devel <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] koha-testing-docker and plugins
I think the problem is due to change fb59f3f0f04:
Author: Fridolin Somers <fridolin.somers@biblibre.com> Date: Tue Sep 1 15:43:19 2020 +0200
Bug 26338: Show tool plugins run in tools home In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home. Also adds the behavior than if there is no tool plugin, "Tool plugins" section is not displayed in tools home. No need of a link that goes to an empty table ;)
The relevant bit of code in koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt is this:
[% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool && tool_plugins ) %] <dt><a href="/cgi-bin/koha/plugins/plugins-home.pl?method=tool">Tool plugins</a></dt> <dd> Use tool plugins [... stuff deleted ...] [% END %]
Before the change mentioned above, the first line of that snippet looked like this:
[% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool ) %]
Restoring that line to its previous state fixed the problem.
-- Surely I deserve some kind of recognition for all the bad things I haven't done. --Ashleigh Brilliant _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄 BibLibre, France
Excerpts from dcook's message of 2020-11-26 14:41:40 +1100:
I was about to say that sounds like a regression, but it looks like that behaviour is intentional, if you read the commit message: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338#c11
You should be able to manage plugins if you go to "Administration" still.
I overlooked that. Sorry! -- Of course I have a purpose -- to find a purpose. --Ashleigh Brilliant
No problem I'm proud that my code is useful ;) Le 26/11/2020 à 14:10, Mark Alexander a écrit :
Excerpts from dcook's message of 2020-11-26 14:41:40 +1100:
I was about to say that sounds like a regression, but it looks like that behaviour is intentional, if you read the commit message: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26338#c11
You should be able to manage plugins if you go to "Administration" still.
I overlooked that. Sorry!
-- Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄 BibLibre, France
participants (4)
-
dcook＠prosentient.com.au -
Fridolin SOMERS -
Jonathan Druart -
Mark Alexander