Suggestion for OPAC theme bug fix patches
Hi, If you're writing a patch that fixes a bug with an OPAC template file, you'll need to at least touch the Bootstrap theme, but you may also want to touch the prog theme if you think the fix should be backported back to 3.12.x or earlier. Here's my suggestion: if you do that, please put your prog and Bootstrap template changes in separate patches. That way, it will be easier for the RMaints for 3.12.x, 3.10.x, and 3.8.x to cherry-pick the appropriate patches without having to manually disentangle out the Bootstrap theme bits that don't apply. This, in turn, will likely increase the chance of your bugfix being backported. Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
+1 I'm glad that you proposed that Galen, thanks! To+ On Fri, Jan 10, 2014 at 12:28 PM, Galen Charlton <gmc@esilibrary.com> wrote:
Hi,
If you're writing a patch that fixes a bug with an OPAC template file, you'll need to at least touch the Bootstrap theme, but you may also want to touch the prog theme if you think the fix should be backported back to 3.12.x or earlier.
Here's my suggestion: if you do that, please put your prog and Bootstrap template changes in separate patches. That way, it will be easier for the RMaints for 3.12.x, 3.10.x, and 3.8.x to cherry-pick the appropriate patches without having to manually disentangle out the Bootstrap theme bits that don't apply. This, in turn, will likely increase the chance of your bugfix being backported.
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 4333190 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F
++, thanks Galen Le 10/01/2014 16:53, Tomas Cohen Arazi a écrit :
+1
I'm glad that you proposed that Galen, thanks! To+
On Fri, Jan 10, 2014 at 12:28 PM, Galen Charlton <gmc@esilibrary.com> wrote:
Hi,
If you're writing a patch that fixes a bug with an OPAC template file, you'll need to at least touch the Bootstrap theme, but you may also want to touch the prog theme if you think the fix should be backported back to 3.12.x or earlier.
Here's my suggestion: if you do that, please put your prog and Bootstrap template changes in separate patches. That way, it will be easier for the RMaints for 3.12.x, 3.10.x, and 3.8.x to cherry-pick the appropriate patches without having to manually disentangle out the Bootstrap theme bits that don't apply. This, in turn, will likely increase the chance of your bugfix being backported.
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolin SOMERS Biblibre - Pôles support et système fridolin.somers@biblibre.com
participants (3)
-
Fridolin SOMERS -
Galen Charlton -
Tomas Cohen Arazi