Explanations in systempreferences options?
Hi, In the midst of working on a new patch on my kohadevbox, I wanted to add a new system preference. In doing so (and debugging as a result!) I noticed some existing system preferences appear to have what I would assume should be the explanation in the option field: mysql> select * from systempreferences where type = "yesno" and variable like "Suspend%"; +----------------------+-------+------------------------------------------------+-------------+-------+ | variable | value | options | explanation | type | +----------------------+-------+------------------------------------------------+-------------+-------+ | SuspendHoldsIntranet | 1 | Allow holds to be suspended from the intranet. | NULL | YesNo | | SuspendHoldsOpac | 1 | Allow holds to be suspended from the OPAC. | NULL | YesNo | +----------------------+-------+------------------------------------------------+-------------+-------+ Yet these appear on the administration system preferences output OK. Are these wrong, or am I misunderstanding how explanation and options are supposed to work? I thought explanation was the human readable text and options were things you could choose from?
That explanation is kept for historical reasons but not used anymore. We handle that in the translatable *.pref files. And options only applies to some type of sysprefs. El mar., 29 de may. de 2018 5:44 a. m., Jon Knight <J.P.Knight@lboro.ac.uk> escribió:
Hi,
In the midst of working on a new patch on my kohadevbox, I wanted to add a new system preference. In doing so (and debugging as a result!) I noticed some existing system preferences appear to have what I would assume should be the explanation in the option field:
mysql> select * from systempreferences where type = "yesno" and variable like "Suspend%";
+----------------------+-------+------------------------------------------------+-------------+-------+ | variable | value | options | explanation | type |
+----------------------+-------+------------------------------------------------+-------------+-------+ | SuspendHoldsIntranet | 1 | Allow holds to be suspended from the intranet. | NULL | YesNo | | SuspendHoldsOpac | 1 | Allow holds to be suspended from the OPAC. | NULL | YesNo |
+----------------------+-------+------------------------------------------------+-------------+-------+
Yet these appear on the administration system preferences output OK. Are these wrong, or am I misunderstanding how explanation and options are supposed to work? I thought explanation was the human readable text and options were things you could choose from? _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
participants (2)
-
Jon Knight -
Tomas Cohen Arazi