TinyMCE Changes Discussion + Initial Patch (part of discussion re: distribution size)
All, I am not sure the proper way to do this, and I hope someone can assist me formalizing and sending this patch to the patches list, or to a maintainer directly -- TinyMCE is only (as far as I can tell) being used for the help editor. This is a 3mb package that is copied to every language specific directory (making the distribution large!). I moved it from: /koha-tmpl/intranet-tmpl/prog/en/js/tinymce to: /koha-tmpl/intranet-tmpl/prog/3rdparty_js/ --- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/edithelp.tmpl @@ -1,6 +1,6 @@ <!-- TMPL_INCLUDE NAME="doc-head-open.inc" --> <title>Online Help</title> -<script language="javascript" type="text/javascript" src="<!-- TMPL_VAR name="themelang" -->/js/tinymce/jscripts/tiny_mce/tiny_mce.js"></script> +<script language="javascript" type="text/javascript" src="/intranet-tmpl/prog/3rdparty_js/tiny_mce/tiny_mce.js"></script> Instead of just moving tinymce, I removed version 2.x, and downloaded 3.latest into the new directory. I also removed some files from the tinymce distribution (it includes an uncompressed and a compressed verison, i removed the unused compressed version, and the examples). These patches end up being 800k in size. I also have a question as to how the Makefile needs to handle this change that I hope someone can assist me with. The patest (against git) are: http://brinkerhoff.org/tinymce_patches.tgz 0002-Moving-TINYMCE-to-non-language-specific-directory.patch -- removes TinyMCE 2.x, and updates the edithelp template above to reference the new location. 0003-Adding-tiny_mce-3.1.patch -- adds TinyMCE 3.1 to /intranet-tmpl/prog/3rdparty_js/ Stan Brinkerhoff
I am not sure the proper way to do this, and I hope someone can assist me formalizing and sending this patch to the patches list, or to a maintainer directly --
Since Koha relies already on YUI, why not switching from TinyMCE to YUI text editor? http://developer.yahoo.com/yui/editor/ -- Frédéric
I am not sure the proper way to do this, and I hope someone can assist me
formalizing and sending this patch to the patches list, or to a maintainer directly --
Since Koha relies already on YUI, why not switching from TinyMCE to YUI text editor?
That would be too logical! I will resubmit with YUI instead of TinyMCE. Stan
On Tue, Dec 30, 2008 at 9:09 AM, Stan Brinkerhoff <koha@vtwireless.com> wrote:
Since Koha relies already on YUI, why not switching from TinyMCE to YUI text editor?
That would be too logical! I will resubmit with YUI instead of TinyMCE.
I'll add a feature / coherence request if I may : the graphical editor is only used for the online help, as noted earlier, but it should also be used for news at koha-news.pl. Could it be added here? Nicolas -- Nicolas Morin Mobile: +33(0)633 19 11 36 http://www.biblibre.com
I'll add a feature / coherence request if I may : the graphical editor is only used for the online help, as noted earlier, but it should also be used for news at koha-news.pl. Could it be added here
I can't agree more. I did it in the past: http://tinyurl.com/9t6epd I don't remember, if I never knew, why it has been lost. -- Frédéric
participants (3)
-
Frederic Demians -
Nicolas Morin -
Stan Brinkerhoff