Hi all, I'm working on biblio deletion in Koha. There are some very annoying bugs in deletion in 1.2.x code, that I want to clean. The deleted biblio is copied into a "deletedbiblio" table, for historic purposes. Note that there is no way to transfer the biblio back to "active DB". And it's a little buggy : the biblio can be deleted without the biblioitems :-\ (see delbiblio.pl & sub delbiblio in C4/Biblio.pm). and you can delete a biblioitem with items attached (deletebiblioitems.pl) I propose the following feature : * a confirmation is needed before any deletion. * delete can be done on biblio or items. If done on biblio, biblioitem and items are deleted too. * deleted biblios are no more stored in deletedbiblio tables : because there is no MARC deletedbiblio, no way to restore a biblio, I think it's a feature we could introduce in a future version of Koha. * deletion require a "superlibrarian" flag, to avoid any librarian deleting biblios. Any opinion/suggestions ? -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
On Tue 21 Oct, paul POULAIN wrote:
I'm working on biblio deletion in Koha. There are some very annoying bugs in deletion in 1.2.x code, that I want to clean.
Not I hope too much off topic, but I have been trying to install v2 from scratch. I have entered several book records manually and each time have got something wrong. ie the entries include one user and, say, two books and there is something wrong with the book entries. I have then tried to click on "catalogue maintenance", thinking that this was the way to correct the errors. This loads http://chamslib/cgi-bin/koha/maint/catmaintain.pl but all that appears in the new page is the single line <HTML> (which unsurprisingly displays as a blank page...). I have tried using a variety of browsers incl. Mozilla under RH9. Roger -- Roger Horne 11 New Square, Lincoln's Inn, London WC2A 3QB, UK roger@hrothgar.co.uk http://www.hrothgar.co.uk/
On 2003-10-21 17:59:06 +0100 Roger Horne <roger@hrothgar.co.uk> wrote:
http://chamslib/cgi-bin/koha/maint/catmaintain.pl but all that appears in the new page is the single line <HTML> (which unsurprisingly displays as a blank page...).
I think I fixed this bug in CVS a while ago. Paul, can we have a date for new release, please? pre4 is looking very old and outdated. -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
On Wed 22 Oct, MJ Ray wrote:
I think I fixed this bug in CVS a while ago. Paul, can we have a date for new release, please? pre4 is looking very old and outdated.
A small point which may just be me.. I tried, as I suggested elsewhere, using location to store a particular physical location in a single library. I entered "RH's room" as the location (unquoted) and used that in the biblio (manually entered) for a single book. It did not show as such when I searched for the book, another location (without a ') taking its place. Is the "location" qq() ed (so that eg ' is escaped? (I could not work it out from the source.) Roger -- Roger Horne, 11 New Square, Lincoln's Inn, London WC2A 3QB http://hrothgar.co.uk/ mailto:roger@hrothgar.co.uk
On 2003-10-22 22:12:58 +0100 Roger Horne <roger@hrothgar.co.uk> wrote:
I entered "RH's room" as the location (unquoted) and used that in the biblio (manually entered) for a single book.
Can you tell me the URL in the address bar of the page that you entered this on? For extra help, can you tell me the URL of the next page to appear, as soon as you clicked the send button? My first look for this didn't find the problem I was expecting. Really, qq() shouldn't be used. All DBI database calls should be done by preparing a statement with ? placeholders and then using execute to fill in the variables. I've not spotted too many cases of other things in koha, but I've not been looking too hard yet. I think far more common in koha is the SQL phrase: INSERT INTO tablename VALUES (?,?,?,?,?) which causes problems if the order or numbers of the columns in tablename changes. Sometimes the name of the table can be a reserved word in future versions of MySQL too. I think that developers should use INSERT INTO "tablename" ("column1","column2") VALUES (?,?) instead but ICBW. -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
MJ Ray wrote:
On 2003-10-22 22:12:58 +0100 Roger Horne <roger@hrothgar.co.uk> wrote:
Can you tell me the URL in the address bar of the page that you entered this on? For extra help, can you tell me the URL of the next page to appear, as soon as you clicked the send button? My first look for this didn't find the problem I was expecting.
Really, qq() shouldn't be used. All DBI database calls should be done by preparing a statement with ? placeholders and then using execute to fill in the variables. I've not spotted too many cases of other things in koha, but I've not been looking too hard yet.
we try to clean sql without ? when we discover them. There should not be so many of them now.
I think far more common in koha is the SQL phrase: INSERT INTO tablename VALUES (?,?,?,?,?) which causes problems if the order or numbers of the columns in tablename changes. Sometimes the name of the table can be a reserved word in future versions of MySQL too. I think that developers should use INSERT INTO "tablename" ("column1","column2") VALUES (?,?) instead but ICBW.
I never use "short version" of insert. I usually use INSERT INTO "tablename" ("column1","column2") VALUES (?,?) . some dev use insert into biblioitems set biblioitemnumber = ?, biblionumber = ?, which is OK too. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
MJ Ray wrote:
On 2003-10-21 17:59:06 +0100 Roger Horne <roger@hrothgar.co.uk> wrote:
http://chamslib/cgi-bin/koha/maint/catmaintain.pl but all that appears in the new page is the single line <HTML> (which unsurprisingly displays as a blank page...).
I think I fixed this bug in CVS a while ago. Paul, can we have a date for new release, please? pre4 is looking very old and outdated.
I'll work on Koha 2.0.0RC1 tonight/saturday morning. Expect it in sourceforge monday morning (or sunday if your work during the week end) PS : the 1st draft of release notes is already in CVS ($koharoot/release_notes200rc1.txt), feel free to complete/check it :-) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
On Tue, Oct 21, 2003 at 05:10:13PM +0200, paul POULAIN said:
Hi all,
I'm working on biblio deletion in Koha. There are some very annoying bugs in deletion in 1.2.x code, that I want to clean. The deleted biblio is copied into a "deletedbiblio" table, for historic purposes. Note that there is no way to transfer the biblio back to "active DB". And it's a little buggy : the biblio can be deleted without the biblioitems :-\ (see delbiblio.pl & sub delbiblio in C4/Biblio.pm). and you can delete a biblioitem with items attached (deletebiblioitems.pl)
I propose the following feature : * a confirmation is needed before any deletion.
Yep
* delete can be done on biblio or items. If done on biblio, biblioitem and items are deleted too.
Currently it wont let you delete a biblio that has items attached, or has orders for more items on it.
* deleted biblios are no more stored in deletedbiblio tables : because there is no MARC deletedbiblio, no way to restore a biblio, I think it's a feature we could introduce in a future version of Koha.
Can we leave them storing them there anyway. I have had to move biblios back from deleted before for HLT. When an item is long long overdue, and is marked lost, after a while they delete the item and if they dont/cant buy a replacement, they delete the biblio too. Then suddenly the item is returned. Being able to run some sql to move the data out of deletedbiblio is lot faster than having them recatalog. Basically I never throw away data, as soon as you do .. its needed again. So if we could still store the data somewhere that would be good.
* deletion require a "superlibrarian" flag, to avoid any librarian deleting biblios.
Yep, I think that would work. Chris -- Chris Cormack Programmer 027 4500 789 Katipo Communications Ltd chris@katipo.co.nz www.katipo.co.nz
participants (4)
-
Chris Cormack -
MJ Ray -
paul POULAIN -
Roger Horne