Update bugzilla - Restore style on quotes
Hi devs, Our favorite bug tracker has been updated today/yesterday. There are plenty of useful stuffs everywhere, but one thing is quite irritating: the quotes are now displayed in block (i.e. with an horizontal scrollbar). Ok it was not really nice to see the text overflowed the comment block, but now you have to scroll to see the content (example: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988#c31). You can restore the previous style on installing/using the stylish add-on [1] and add the following rule: @-moz-document domain("bugs.koha-community.org") { .bz_comment_text span.quote { display: inline; } } Note: It seems there is a bug on sending patch using git bz attach -e (works without -e), could someone confirm? Cheers, Jonathan [1] for Firefox: https://addons.mozilla.org/en-US/firefox/addon/stylish/
Marcel De Rooy schrieb am 10.07.2015
Note: It seems there is a bug on sending patch using git bz attach -e (works without -e), could someone confirm?
Yes, I had some trouble too with submitting patches. I can't send patches with or without -e, I get a socket error.
Attach? [yn] y Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2633, in <module> do_attach(*args) File "/usr/local/bin/git-bz", line 1999, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/local/bin/git-bz", line 1947, in attach_commits bug.create_patch(description, body, filename, patch, obsoletes=obsoletes, status=status) File "/usr/local/bin/git-bz", line 1347, in create_patch response = self.server.send_post("/attachment.cgi", fields, files) File "/usr/local/bin/git-bz", line 1039, in send_post return self.send_request("POST", url, data=body, headers={ 'Content-Type': content_type }) File "/usr/local/bin/git-bz", line 974, in send_request connection.request(method, url, data, headers) File "/usr/lib/python2.7/httplib.py", line 962, in request self._send_request(method, url, body, headers) File "/usr/lib/python2.7/httplib.py", line 996, in _send_request self.endheaders(body) File "/usr/lib/python2.7/httplib.py", line 958, in endheaders self._send_output(message_body) File "/usr/lib/python2.7/httplib.py", line 818, in _send_output self.send(msg) File "/usr/lib/python2.7/httplib.py", line 794, in send self.sock.sendall(data) File "/usr/lib/python2.7/socket.py", line 224, in meth return getattr(self._sock,name)(*args) socket.error: [Errno 32] Broken pipe -- Mirko -- Mirko Tietgen mirko@abunchofthings.net http://koha.abunchofthings.net http://meinkoha.de
On 10 July 2015 at 21:29, Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:
Hi devs,
Our favorite bug tracker has been updated today/yesterday.
There are plenty of useful stuffs everywhere, but one thing is quite irritating: the quotes are now displayed in block (i.e. with an horizontal scrollbar). Ok it was not really nice to see the text overflowed the comment block, but now you have to scroll to see the content (example: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988#c31). You can restore the previous style on installing/using the stylish add-on [1] and add the following rule:
@-moz-document domain("bugs.koha-community.org") { .bz_comment_text span.quote { display: inline; } }
Whats the consensus here, if people prefer the old style, we can add this to the stylesheett
Note: It seems there is a bug on sending patch using git bz attach -e (works without -e), could someone confirm?
Hmm can't replicate, http://paste.koha-community.org/172 I wonder if it's a time thing? IE if you take to long to edit it times out? Chris
Cheers, Jonathan
[1] for Firefox: https://addons.mozilla.org/en-US/firefox/addon/stylish/ _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Am 12.07.2015 um 23:01 schrieb Chris Cormack:
@-moz-document domain("bugs.koha-community.org") { .bz_comment_text span.quote { display: inline; } }
Whats the consensus here, if people prefer the old style, we can add this to the stylesheett
Hi Chris, I just took a quick look and +1 for the old style! Katrin
Note: It seems there is a bug on sending patch using git bz attach -e (works without -e), could someone confirm?
Actually, it works if you don’t Obsolete AND change status at the same time. If you run the same command again after failing the status is changed, but the patch attach wasn't done, and it succeeds. GPML, Mark Tompsett
On 13 July 2015 at 11:23, Mark Tompsett <mtompset@hotmail.com> wrote:
Note: It seems there is a bug on sending patch using git bz attach -e (works without -e), could someone confirm?
Actually, it works if you don’t Obsolete AND change status at the same time. If you run the same command again after failing the status is changed, but the patch attach wasn't done, and it succeeds.
I concur It works if you are only doing one or the other, if you do both, it fails. Now I can consistently replicate it, I might be able to fix it. Chris
On 13 July 2015 at 16:19, Chris Cormack <chris@bigballofwax.co.nz> wrote:
On 13 July 2015 at 11:23, Mark Tompsett <mtompset@hotmail.com> wrote:
Note: It seems there is a bug on sending patch using git bz attach -e (works without -e), could someone confirm?
Actually, it works if you don’t Obsolete AND change status at the same time. If you run the same command again after failing the status is changed, but the patch attach wasn't done, and it succeeds.
I concur
It works if you are only doing one or the other, if you do both, it fails. Now I can consistently replicate it, I might be able to fix it.
Chris
And yes it is all to do with the fact they are screen scraping, the code says if not check_for_success(response, response_data, r"<title>\s*Bug[\S\s]*processed\s*</title>"): die ("Failed to update bug %d, status=%d" % (self.id, response.status)) But when you change the status of a bug, it says <title> 6473 processed</title> So this if is failing and the script is dying, before it gets to the code to attach the file. Once I figure out how regex in python work, I'll patch git-bz Sometime, we should rewrite it to use the API instead of screen scraping, so this stops happening Chris
And it should be fixed now You will want to pull the latest version of the fishsoup branch at http://git.koha-community.org/gitweb/?p=git-bz.git;a=summary http://git.koha-community.org/gitweb/?p=git-bz.git;a=commitdiff;h=6eb891692c... is the diff if you are interested. Chris
Chris, Will this require any changes to be made to the git-bz configuration page on the wiki? http://wiki.koha-community.org/wiki/Git_bz_configuration I've been making small tweaks to that page recently, and I'd be happy to update it -- I presume that anyone using git-bz will need to do a git pull on the fishsoup branch. Just let me know, I'll test any instructions and update the page accordingly. Thanks, --Barton On Mon, Jul 13, 2015 at 12:41 AM, Chris Cormack <chris@bigballofwax.co.nz> wrote:
And it should be fixed now
You will want to pull the latest version of the fishsoup branch at http://git.koha-community.org/gitweb/?p=git-bz.git;a=summary
http://git.koha-community.org/gitweb/?p=git-bz.git;a=commitdiff;h=6eb891692c... is the diff if you are interested.
Chris _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
No. You just need to update your repo. Nothing to do for new installs. 2015-07-13 15:11 GMT+01:00 Barton Chittenden <barton@bywatersolutions.com>:
Chris,
Will this require any changes to be made to the git-bz configuration page on the wiki?
http://wiki.koha-community.org/wiki/Git_bz_configuration
I've been making small tweaks to that page recently, and I'd be happy to update it -- I presume that anyone using git-bz will need to do a git pull on the fishsoup branch. Just let me know, I'll test any instructions and update the page accordingly.
Thanks,
--Barton
On Mon, Jul 13, 2015 at 12:41 AM, Chris Cormack <chris@bigballofwax.co.nz> wrote:
And it should be fixed now
You will want to pull the latest version of the fishsoup branch at http://git.koha-community.org/gitweb/?p=git-bz.git;a=summary
http://git.koha-community.org/gitweb/?p=git-bz.git;a=commitdiff;h=6eb891692c... is the diff if you are interested.
Chris _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Ah, that's what I meant -- sorry, I was being ambiguous. --Barton On Mon, Jul 13, 2015 at 10:16 AM, Jonathan Druart < jonathan.druart@bugs.koha-community.org> wrote:
No. You just need to update your repo. Nothing to do for new installs.
: Chris,
Will this require any changes to be made to the git-bz configuration
the wiki?
http://wiki.koha-community.org/wiki/Git_bz_configuration
I've been making small tweaks to that page recently, and I'd be happy to update it -- I presume that anyone using git-bz will need to do a git
2015-07-13 15:11 GMT+01:00 Barton Chittenden <barton@bywatersolutions.com page on pull
on the fishsoup branch. Just let me know, I'll test any instructions and update the page accordingly.
Thanks,
--Barton
On Mon, Jul 13, 2015 at 12:41 AM, Chris Cormack < chris@bigballofwax.co.nz> wrote:
And it should be fixed now
You will want to pull the latest version of the fishsoup branch at http://git.koha-community.org/gitweb/?p=git-bz.git;a=summary
http://git.koha-community.org/gitweb/?p=git-bz.git;a=commitdiff;h=6eb891692c...
is the diff if you are interested.
Chris _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (7)
-
Barton Chittenden -
Chris Cormack -
Jonathan Druart -
Katrin Fischer -
Marcel de Rooy -
Mark Tompsett -
Mirko Tietgen