Hi Katrin,

Ahh yes bug 23713 looks like the same bug. Thank you so much Katrin for this pointer!

Thanks,

Alex


On 13/06/22 22:00, koha-translate-request@lists.koha-community.org wrote:
Send Koha-translate mailing list submissions to
	koha-translate@lists.koha-community.org

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-translate

or, via email, send a message with subject or body 'help' to
	koha-translate-request@lists.koha-community.org

You can reach the person managing the list at
	koha-translate-owner@lists.koha-community.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Koha-translate digest..."


Today's Topics:

   1. opac-overdrive-search.tt translation bug (Alex Buckley)
   2. Re: opac-overdrive-search.tt translation bug (Katrin Fischer)


----------------------------------------------------------------------


Message: 2
Date: Mon, 13 Jun 2022 08:17:09 +0200
From: Katrin Fischer <katrin.fischer.83@web.de>
To: koha-translate@lists.koha-community.org
Subject: Re: [Koha-translate] opac-overdrive-search.tt translation bug
Message-ID: <63f705e5-f85c-6df5-3c8a-f8a294c39b3d@web.de>
Content-Type: text/plain; charset="utf-8"; Format="flowed"

Hi Alex,

I believe this was the same bug/using the same TT construct:

*Bug 23713*
<https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713> -
Subscription add form broken for translations

Hope this helps,

Katrin

On 13.06.22 08:13, Alex Buckley wrote:

Hi there,

I see this line
https://github.com/Koha-Community/Koha/blob/beb663836b45a77f45195774133cc9b78957fcd5/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt#L75
does not get translated correctly.

The 0 in the ELSE is lost in the translated versions of
opac-overdrive-search.tt, for example below:

/var OD_password_required = [% IF
Koha.Preference('OverDrivePasswordRequired') %]1[% ELSE %][% END %];/

This in turn throws a JavaScript error if a library does not have the
/OverDrivePasswordRequired/ syspref enabled./
/

I checked the en-NZ-opac-bootstrap.po
<https://translate.koha-community.org/export/22.05/en_NZ/en-NZ-opac-bootstrap.po>
and it has no translation for that JS line.

Could someone please give me some pointers on how we could stop the 0
being lost?

Any help gratefully received!

Many thanks,

Alex