[Koha-bugs] [Bug 577] New: Move HTML out of authorised_values.pl and marctagstructure.pl

[bugzilla-daemon at wilbur.katipo.co.nz]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=577

           Summary: Move HTML out of authorised_values.pl and
                    marctagstructure.pl
           Product: Koha
           Version: CVS
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Parameters
        AssignedTo: tonnesen at cmsd.bc.ca
        ReportedBy: oleonard at athenscounty.lib.oh.us
         QAContact: koha-bugs at lists.sourceforge.net


In authorisedvalues.pl and marctagstruture.pl, variables are created to enable
'previous page' and 'next page' links.  This is done like this:

		$template->param(previous => "<a
href=\"$script_name?offset=$prevpage&searchfield=$searchfield\">");

...So the template reads something like this:

    <TMPL_VAR NAME="previous">Previous Page</a>

It makes more sense to me to create individual variables for $prevpage and
$searchfield so that the link could be constructed more flexibly:

<a href="<TMPL_VAR NAME="script_name">?offset=<TMPL_VAR
NAME="offset">&amp;searchfield=<TMPL_VAR NAME="searchfield">">Previous Page</a>

This would allow alternatives like:

<form action="<TMPL_VAR NAME="script_name">" method="get">
<input type="hidden" name="offset" value="<TMPL_VAR NAME="offset">
<input type="hidden" name="searchfield" value="<TMPL_VAR NAME="searchfield">">
<input type="submit" value="Previous Page">
</form>



------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.