[Koha-bugs] [Bug 436] circulation.pl only partially templated

bugzilla-daemon at wilbur.katipo.co.nz bugzilla-daemon at wilbur.katipo.co.nz
Sat Oct 18 16:49:31 CEST 2003


http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=436

oleonard at athenscounty.lib.oh.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From oleonard at athenscounty.lib.oh.us  2003-10-19 03:49 -------
I think Pierre's fixes are working fine, but there is still presentational code
in the Perl script.  Any time HTML is generated by the script, like here in line
160:

    $responsesform.="<input type=hidden name=response-$_ value=$responses{$_}>\n";

...you're removing control from the template-writer.  In this case, I wouldn't
be able to get my page to validate as XHTML because the attributes aren't
quoted.  Error messages embedded in the script as in line 346:

    $invalidduedate="Invalid Due Date Specified. Book was not issued.<p>\n";

...will prevent template translators from being able to fully translate Koha
into their language.



------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Koha-bugs mailing list