[Koha-bugs] [Bug 1400] New: Branch transfers missing some template variables

[bugzilla-daemon at pippin.metavore.com]

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=1400

           Summary: Branch transfers missing some template variables
           Product: Koha
           Version: rel_3_0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Circulation
        AssignedTo: chris.cormack at liblime.com
        ReportedBy: oleonard at myacpl.org
         QAContact: koha-bugs at nongnu.org


The branch transfers template contains this section, used when a book is
transferred which was checked out:

Item was on loan to <a
href="/cgi-bin/koha/members/moremember.pl?borrowernumber=<!-- TMPL_VAR
Name="borrowernumber" -->"><!-- TMPL_VAR Name="borrowernumber" --></a>
<!-- TMPL_VAR Name="name" --> and has been returned.

Neither <!-- TMPL_VAR Name="borrowernumber" --> or <!-- TMPL_VAR Name="name"
--> is being passed to the template by the script.

Also: the script seems to be building <!-- TMPL_VAR Name="name" --> out of
borrowers.title, borrowers.surname, and borrowers.firstname (sub name, line
222). I think this is bad practice, concatenating fields in the script where
they could just as easily be passed individually to the template. Processing
the text in the script limits the options for how the text can be displayed in
the template.




------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.